Skip to contentSkip to conversation

serial: s5p: set automatically clears after resetting Rx FIFO

PATCH New Inha Song 3 participants 3 messages Feb 4, 2014 – Feb 6, 2014

lore
Share & tools
lore

Inha Song

author
#0 lore raw

PATCH 1/1 serial: s5p: set automatically clears after resetting Rx FIFO

This patch fix the u-boot shell problem on TRATS2 board.
- If hold the key while booting is in progress, white spaces are written in u-boot shell.

Set Automatically clears after resetting Rx FIFO.

---
 drivers/serial/serial_s5p.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/serial/serial_s5p.c +2 -2
index 89f5d68..98c62b4 100644
@@ -100,8 +100,8 @@ static int serial_init_dev(const int dev_index)
 {
 	struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
 
-	/* enable FIFOs */
-	writel(0x1, &uart->ufcon);
+	/* enable FIFOs, auto clear Rx FIFO */
+	writel(0x3, &uart->ufcon);
 	writel(0, &uart->umcon);
 	/* 8N1 */
 	writel(0x3, &uart->ulcon);
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 serial: s5p: set automatically clears after resetting Rx FIFO

Hi Inha,

Quoted 5 lines

This patch fix the u-boot shell problem on TRATS2 board.
- If hold the key while booting is in progress, white spaces are written in u-boot shell.

Set Automatically clears after resetting Rx FIFO.

Quoted 22 lines
---
 drivers/serial/serial_s5p.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/serial/serial_s5p.c +2 -2
index 89f5d68..98c62b4 100644
@@ -100,8 +100,8 @@ static int serial_init_dev(const int dev_index)
 {
 	struct s5p_uart *const uart = s5p_get_base_uart(dev_index);
 
-	/* enable FIFOs */
-	writel(0x1, &uart->ufcon);
+	/* enable FIFOs, auto clear Rx FIFO */
+	writel(0x3, &uart->ufcon);
 	writel(0, &uart->umcon);
 	/* 8N1 */
 	writel(0x3, &uart->ulcon);
Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
#2 lore raw

PATCH 1/1 serial: s5p: set automatically clears after resetting Rx FIFO

In reply to Inha Song
Quoted 4 lines · Inha Song

This patch fix the u-boot shell problem on TRATS2 board.
- If hold the key while booting is in progress, white spaces are written in u-boot shell.

Quoted 8 lines

Set Automatically clears after resetting Rx FIFO.

---
 drivers/serial/serial_s5p.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

applied to u-boot-samsung

Thanks,
Minkyu Kang.