vlc: new package
PATCH 1/1 vlc: new package
From: Alexey Brodkin <[email protected]>
Based on "[PATCHv6] vlc: New package" found here http://patchwork.ozlabs.org/patch/171335/
--- package/multimedia/Config.in | 1 + package/multimedia/vlc/Config.in | 305 ++++++++++++++++++++ package/multimedia/vlc/vlc-uclibc-fixes.patch | 27 ++ package/multimedia/vlc/vlc.mk | 372 +++++++++++++++++++++++++ 4 files changed, 705 insertions(+) create mode 100644 package/multimedia/vlc/Config.in create mode 100644 package/multimedia/vlc/vlc-uclibc-fixes.patch create mode 100644 package/multimedia/vlc/vlc.mk
package/multimedia/Config.in +1 -0
@@ -23,6 +23,7 @@ source "package/multimedia/musepack/Config.in" source "package/opus-tools/Config.in" source "package/multimedia/pulseaudio/Config.in" source "package/multimedia/tidsp-binaries/Config.in" +source "package/multimedia/vlc/Config.in" source "package/multimedia/vorbis-tools/Config.in" source "package/multimedia/wavpack/Config.in" source "package/yavta/Config.in"
package/multimedia/vlc/Config.in new file +305 -0
305 lines not on this page · raw message
package/multimedia/vlc/vlc-uclibc-fixes.patch new file +27 -0
@@ -0,0 +1,27 @@ +Fixes compilation with uClibc, which doesn't provide gnu/libc-version.h nor +gnu_get_libc_version. + +Upstream Status: Rejected + +Signed-off-by: Ismael Luceno <[email protected]> + +diff -u a/src/posix/linux_specific.c b/src/posix/linux_specific.c +--- a/src/posix/linux_specific.c 2012-02-08 16:43:30.000000000 -0200 ++++ b/src/posix/linux_specific.c 2012-02-09 03:51:20.925504594 -0200 +@@ -74,14 +74,14 @@ + return (path != NULL) ? path : strdup (PKGLIBDIR); + } + +-#ifdef __GLIBC__ ++#if defined(__GLIBC__) && !defined(__UCLIBC__) + # include <gnu/libc-version.h> + # include <stdlib.h> + #endif + + void system_Init (void) + { +-#ifdef __GLIBC__ ++#if defined(__GLIBC__) && !defined(__UCLIBC__) + const char *glcv = gnu_get_libc_version (); + + /* gettext in glibc 2.5-2.7 is not thread-safe. LibVLC keeps crashing,
package/multimedia/vlc/vlc.mk new file +372 -0
372 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH 1/1 vlc: new package
Hi,
Alexey Brodkin <[email protected]>
wrote in news:1363687526-8469-1-git-send-email-abrodkin at synopsys.com:
Quoted 1 line
+ifeq ($(BR2_PACKAGE_AVCODEC),y)
shouldn?t this be called BR2_PACKAGE_VLC_AVCODEC?
Quoted 1 line
+ifeq ($(BR2_PACKAGE_LUA),y)
and this BR2_PACKAGE_VLC_LUA?
Regards, Bernd
PATCH 1/1 vlc: new package
Quoted 4 lines · Bernd Kuhls
Hi,
Alexey Brodkin <Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/[email protected]> wrote in
news:1363687526-8469-1-git-send-email-abrodkin-HKixBCOQz3hWk0Htik3J/w at public.gmane.org:
Quoted 10 lines
Quoted 2 lines
+ifeq ($(BR2_PACKAGE_AVCODEC),y)
shouldn?t this be called
BR2_PACKAGE_VLC_AVCODEC?Quoted 1 line
+ifeq ($(BR2_PACKAGE_LUA),y)
and this
BR2_PACKAGE_VLC_LUA?Regards, Bernd
Hi Bernd,
The idea is to check if "avcodec" and "lua" packages were selected in configuration utility (menuconfig/xconfig etc).
Indeed we may rely on VLC's symbols BR2_PACKAGE_AVCODEC and BR2_PACKAGE_LUA that select BR2_PACKAGE_FFMPEG and BR2_PACKAGE_LUA accordingly.
So initial proposal is to sort of double check if we do have "avcodec" and "lua" selected.
Even though you believe it's better to check VLC's own symbols I may do a re-spin.
-Alexey
PATCH 1/1 vlc: new package
In reply to Alexey BrodkinQuoted 6 lines · Alexey Brodkin
From: Alexey Brodkin<alexey.brodkin-HKixBCOQz3hWk0Htik3J/[email protected]>
Based on "[PATCHv6] vlc: New package" found herehttp://patchwork.ozlabs.org/patch/171335/
Signed-off-by Ismael Luceno<[email protected]>
Hi Yann,
from here http://patchwork.ozlabs.org/patch/228982/ I see that you are assigned for this patch review.
I'm wondering if there's a chance to get it finally reviewed?
Regards,
Alexey
PATCH 1/1 vlc: new package
In reply to Alexey BrodkinDear Alexey Brodkin,
Quoted 6 lines · Alexey Brodkin
From: Alexey Brodkin <[email protected]>
Based on "[PATCHv6] vlc: New package" found here http://patchwork.ozlabs.org/patch/171335/
Signed-off-by Ismael Luceno <[email protected]>Signed-off-by Alexey Brodkin <[email protected]>
Quoted 9 lines
--- package/multimedia/Config.in | 1 + package/multimedia/vlc/Config.in | 305 ++++++++++++++++++++ package/multimedia/vlc/vlc-uclibc-fixes.patch | 27 ++ package/multimedia/vlc/vlc.mk | 372 +++++++++++++++++++++++++ 4 files changed, 705 insertions(+) create mode 100644 package/multimedia/vlc/Config.in create mode 100644 package/multimedia/vlc/vlc-uclibc-fixes.patch create mode 100644 package/multimedia/vlc/vlc.mk
We have merged a separate proposal to introduce VLC recently, see:
http://git.buildroot.net/buildroot/tree/package/vlc/.
It does not include as many features as the patch you were proposing, but your patch was introducing so many configuration options at once that it was a bit hard to do some good testing of it. Therefore, we've merged something slightly simpler, and we invite you do send follow-up patches to improve what we have now to support the additional features that you think are missing.
Thanks a lot for your contribution, and sorry for the time it took to get a VLC package merged.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 vlc: new package
Hello Thomas,
Quoted 29 lines · Thomas Petazzoni
Dear Alexey Brodkin,
Quoted 6 lines · Alexey Brodkin
From: Alexey Brodkin <[email protected]>
Based on "[PATCHv6] vlc: New package" found here http://patchwork.ozlabs.org/patch/171335/
Signed-off-by Ismael Luceno <[email protected]>Signed-off-by Alexey Brodkin <[email protected]>Quoted 9 lines
--- package/multimedia/Config.in | 1 + package/multimedia/vlc/Config.in | 305 ++++++++++++++++++++ package/multimedia/vlc/vlc-uclibc-fixes.patch | 27 ++ package/multimedia/vlc/vlc.mk | 372 +++++++++++++++++++++++++ 4 files changed, 705 insertions(+) create mode 100644 package/multimedia/vlc/Config.in create mode 100644 package/multimedia/vlc/vlc-uclibc-fixes.patch create mode 100644 package/multimedia/vlc/vlc.mkWe have merged a separate proposal to introduce VLC recently, see:
http://git.buildroot.net/buildroot/tree/package/vlc/.It does not include as many features as the patch you were proposing, but your patch was introducing so many configuration options at once that it was a bit hard to do some good testing of it. Therefore, we've merged something slightly simpler, and we invite you do send follow-up patches to improve what we have now to support the additional features that you think are missing.
Quoted 3 lines
Thanks a lot for your contribution, and sorry for the time it took to get a VLC package merged.
This is a very good news - VLC was missign from buildroot for so long and now it's there.
Frankly these days I don't [need to] use VLC on embedded devices so I don't really have any requirements for any extra configurability of VLC in buildroot.
As soon as I face any lacking option I'll submit a new patch.
Thank you guys so much for driving development of U-Boot!
Regards,
Alexey