Fix the syslogd initscript pidfile handling - Fix name to pidfile - Enable CONFIG_FEATURE_PIDFILE
PATCH 1/1 Fix the syslogd initscript pidfile handling - Fix name to pidfile - Enable CONFIG_FEATURE_PIDFILE
From: Tilman Keskin?z <[email protected]>
--- package/busybox/S01logging | 4 ++-- package/busybox/busybox-1.20.x.config | 2 +- package/busybox/busybox-1.21.x.config | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
package/busybox/S01logging +2 -2
@@ -6,13 +6,13 @@ case "$1" in start) echo -n "Starting logging: " - start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0 + start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0 start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd echo "OK" ;; stop) echo -n "Stopping logging: " - start-stop-daemon -K -q -p /var/run/syslog.pid + start-stop-daemon -K -q -p /var/run/syslogd.pid start-stop-daemon -K -q -p /var/run/klogd.pid echo "OK" ;;
package/busybox/busybox-1.20.x.config +1 -1
@@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y CONFIG_FEATURE_CLEAN_UP=y CONFIG_FEATURE_UTMP=y CONFIG_FEATURE_WTMP=y -# CONFIG_FEATURE_PIDFILE is not set +CONFIG_FEATURE_PIDFILE=y CONFIG_FEATURE_SUID=y # CONFIG_FEATURE_SUID_CONFIG is not set # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
package/busybox/busybox-1.21.x.config +1 -1
@@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y CONFIG_FEATURE_CLEAN_UP=y CONFIG_FEATURE_UTMP=y CONFIG_FEATURE_WTMP=y -# CONFIG_FEATURE_PIDFILE is not set +CONFIG_FEATURE_PIDFILE=Y CONFIG_PID_FILE_PATH="" CONFIG_FEATURE_SUID=y # CONFIG_FEATURE_SUID_CONFIG is not set
Signature · 1 line
1.7.10.4
PATCH 1/1 Fix the syslogd initscript pidfile handling - Fix name to pidfile - Enable CONFIG_FEATURE_PIDFILE
Hello,
Quoted 15 lines · arved at arved.at
From: Tilman Keskin?z <[email protected]>
Signed-off-by Tilman Keskin?z <[email protected]>--- package/busybox/S01logging | 4 ++-- package/busybox/busybox-1.20.x.config | 2 +- package/busybox/busybox-1.21.x.config | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)package/busybox/S01logging +0
-0
package/busybox/S01logging line 11
Quoted 7 lines
package/busybox/S01logging +1
-1@@ -6,13 +6,13 @@ case "$1" in start) echo -n "Starting logging: " - start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0 + start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0 start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd echo "OK"
Sorry for taking so long to get back to you about this. We are doing some cleanup in patchwork and are currently looking at old patches.
In the end, the problem you mentioned was resolved by adding the '-m' option when calling start-stop-daemon, which means that start-stop-daemon is now responsible for creating the PID file. This was implemented in:
The part changing the path to the PID file was fixed by a patch from you:
Thanks for your contributions, and sorry for the long delay!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com