Skip to contentSkip to conversation

xfstests updated to 197f773

ANNOUNCE Dave Chinner 3 participants 6 messages Jan 24, 2014 – Feb 4, 2014 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Hi all,

The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has just been updated. Patches often get missed, so please check if your outstanding patches were in this update. If they have not been in this update, please resubmit them to [email protected] so they can be picked up in the next update.

The new head of the master branch is commit:

197f773 xfstests: define $seqres in btrfs/026-029

New Commits:

Dave Chinner (7):
[ea0b6eb] xfs: test scratch device mkfs features [b9b5d74] xfs: New _require_* tests for CRC enabled filesystems [86e91cc] xfs: add fsstress/recovery test
[5b524ee] xfs/073, 208: remove .full output before starting the test [b04b0fd] xfs: support xfs_metadump with external logs [3ed573e] xfs/104: use fixed log size
[7657a10] generic/204: use fixed log size for XFS

David Sterba (3):
[80622a6] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0 [586a06c] xfstests: use value of FSTYP if defined externally [1ed9046] xfstests: clean command names in btrfs tests

Eric Sandeen (1):
[a93b1dd] ext4: regression test for ext4 resize with non-extent files

Filipe David Borba Manana (1):
[8c427eb] xfstests: add test for btrfs incremental send infinite loop issue

Koen De Wit (2):
[0c58766] xfstests: btrfs: cross-subvolume sparse copy [197f773] xfstests: define $seqres in btrfs/026-029

Code Diffstat:

 README              |   3 ++
 check               |  13 ++---
 common/attr         |   6 +++
 common/rc           | 122 +++++++++++++++++++++++++++---------------
 tests/btrfs/003     |   2 +-
 tests/btrfs/004     |   2 +-
 tests/btrfs/007     |   4 +-
 tests/btrfs/008     |  12 ++---
 tests/btrfs/009     |   6 +--
 tests/btrfs/013     |   2 +-
 tests/btrfs/014     |   6 +--
 tests/btrfs/015     |   2 +-
 tests/btrfs/016     |  14 ++---
 tests/btrfs/017     |   2 +-
 tests/btrfs/019     |  14 ++---
 tests/btrfs/022     |   6 +--
 tests/btrfs/024     |   2 +-
 tests/btrfs/025     |   4 +-
 tests/btrfs/026     |   1 +
 tests/btrfs/027     |   1 +
 tests/btrfs/028     |   1 +
 tests/btrfs/029     |   1 +
 tests/btrfs/030     | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/030.out |   1 +
 tests/btrfs/031     | 138 ++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/031.out |  48 +++++++++++++++++
 tests/btrfs/group   |   2 +
 tests/ext4/306      |  82 +++++++++++++++++++++++++++++
 tests/ext4/306.out  |  13 +++++
 tests/ext4/group    |   1 +
 tests/generic/204   |   4 ++
 tests/generic/208   |   2 +
 tests/shared/298    |   2 +-
 tests/xfs/073       |   2 +
 tests/xfs/104       |   2 +-
 tests/xfs/186       |   1 +
 tests/xfs/187       |  32 ++++++-----
 tests/xfs/244       |   1 +
 tests/xfs/253       |   3 +-
 tests/xfs/278       |   1 +
 tests/xfs/287       |   3 +-
 tests/xfs/291       |   4 +-
 tests/xfs/306       | 105 ++++++++++++++++++++++++++++++++++++
 tests/xfs/306.out   |   2 +
 tests/xfs/group     |   1 +
 45 files changed, 716 insertions(+), 109 deletions(-)
Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#1 lore raw

Hi Dave,
are all tests in xfstests (those relevant for XFS) in principle supposed to pass on XFS?
I am running these tests on a pristine XFS from kernel 3.8.13 (srcversion 9862FA08CF42E06A4151111) and I get:

root@vc-13-12-1095-35-dev:/mnt/work/alex/xfstests# ./check tests/generic/013
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 vc-13-12-1095-35-dev 3.8.13-030813-generic
MKFS_OPTIONS  -- -f -bsize=4096 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/SCRATCH_DIR

generic/013 34s
_check_xfs_filesystem: filesystem on /dev/vda is inconsistent (c) (see /mnt/work/alex/xfstests/results//generic/013.full)
Ran: generic/013
Passed all 1 tests

root@vc-13-12-1095-35-dev:/mnt/work/alex/xfstests# echo $?
1

Thanks,
Alex.

Quoted 88 lines · Dave Chinner

Hi all,

The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has just been updated. Patches often get missed, so please check if your outstanding patches were in this update. If they have not been in this update, please resubmit them to [email protected] so they can be picked up in the next update.

The new head of the master branch is commit:

197f773 xfstests: define $seqres in btrfs/026-029

New Commits:

Dave Chinner (7):
[ea0b6eb] xfs: test scratch device mkfs features [b9b5d74] xfs: New _require_* tests for CRC enabled filesystems [86e91cc] xfs: add fsstress/recovery test
[5b524ee] xfs/073, 208: remove .full output before starting the test [b04b0fd] xfs: support xfs_metadump with external logs [3ed573e] xfs/104: use fixed log size
[7657a10] generic/204: use fixed log size for XFS

David Sterba (3):
[80622a6] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0 [586a06c] xfstests: use value of FSTYP if defined externally [1ed9046] xfstests: clean command names in btrfs tests

Eric Sandeen (1):
[a93b1dd] ext4: regression test for ext4 resize with non-extent files

Filipe David Borba Manana (1):
[8c427eb] xfstests: add test for btrfs incremental send infinite loop issue

Koen De Wit (2):
[0c58766] xfstests: btrfs: cross-subvolume sparse copy [197f773] xfstests: define $seqres in btrfs/026-029

Code Diffstat:

 README              |   3 ++
 check               |  13 ++---
 common/attr         |   6 +++
 common/rc           | 122 +++++++++++++++++++++++++++---------------
 tests/btrfs/003     |   2 +-
 tests/btrfs/004     |   2 +-
 tests/btrfs/007     |   4 +-
 tests/btrfs/008     |  12 ++---
 tests/btrfs/009     |   6 +--
 tests/btrfs/013     |   2 +-
 tests/btrfs/014     |   6 +--
 tests/btrfs/015     |   2 +-
 tests/btrfs/016     |  14 ++---
 tests/btrfs/017     |   2 +-
 tests/btrfs/019     |  14 ++---
 tests/btrfs/022     |   6 +--
 tests/btrfs/024     |   2 +-
 tests/btrfs/025     |   4 +-
 tests/btrfs/026     |   1 +
 tests/btrfs/027     |   1 +
 tests/btrfs/028     |   1 +
 tests/btrfs/029     |   1 +
 tests/btrfs/030     | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/030.out |   1 +
 tests/btrfs/031     | 138 ++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/031.out |  48 +++++++++++++++++
 tests/btrfs/group   |   2 +
 tests/ext4/306      |  82 +++++++++++++++++++++++++++++
 tests/ext4/306.out  |  13 +++++
 tests/ext4/group    |   1 +
 tests/generic/204   |   4 ++
 tests/generic/208   |   2 +
 tests/shared/298    |   2 +-
 tests/xfs/073       |   2 +
 tests/xfs/104       |   2 +-
 tests/xfs/186       |   1 +
 tests/xfs/187       |  32 ++++++-----
 tests/xfs/244       |   1 +
 tests/xfs/253       |   3 +-
 tests/xfs/278       |   1 +
 tests/xfs/287       |   3 +-
 tests/xfs/291       |   4 +-
 tests/xfs/306       | 105 ++++++++++++++++++++++++++++++++++++
 tests/xfs/306.out   |   2 +
 tests/xfs/group     |   1 +
 45 files changed, 716 insertions(+), 109 deletions(-)
Quoted 7 lines

--
Dave Chinner
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 12 lines · Alex Lyakas

Hi Dave,
are all tests in xfstests (those relevant for XFS) in principle supposed to pass on XFS?
I am running these tests on a pristine XFS from kernel 3.8.13 (srcversion 9862FA08CF42E06A4151111) and I get:

root@vc-13-12-1095-35-dev:/mnt/work/alex/xfstests# ./check tests/generic/013
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 vc-13-12-1095-35-dev 3.8.13-030813-generic
MKFS_OPTIONS  -- -f -bsize=4096 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/SCRATCH_DIR
Quoted 3 lines

generic/013 34s
_check_xfs_filesystem: filesystem on /dev/vda is inconsistent (c) (see /mnt/work/alex/xfstests/results//generic/013.full)

uh, so it failed

Quoted 2 lines

Ran: generic/013
Passed all 1 tests

but it passed? ;)

The fact that you saw:

Quoted 1 line

generic/013 34s

and not:

Quoted 1 line

generic/013 34s ... 33s

or

Quoted 1 line

generic/013 34s ... output mismatch

or similar, makes me think the test did not even start, and /dev/vda was corrupted before you even started the test, but I'm not certain.

/mnt/work/alex/xfstests/results//generic/013.full has more info.

Anyway, 013 generally passes AFAIK.

-Eric

Quoted 104 lines
root@vc-13-12-1095-35-dev:/mnt/work/alex/xfstests# echo $?
1

Thanks,
Alex.

Quoted 88 lines · Dave Chinner

Hi all,

The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has just been updated. Patches often get missed, so please check if your outstanding patches were in this update. If they have not been in this update, please resubmit them to [email protected] so they can be picked up in the next update.

The new head of the master branch is commit:

197f773 xfstests: define $seqres in btrfs/026-029

New Commits:

Dave Chinner (7):
[ea0b6eb] xfs: test scratch device mkfs features [b9b5d74] xfs: New _require_* tests for CRC enabled filesystems [86e91cc] xfs: add fsstress/recovery test
[5b524ee] xfs/073, 208: remove .full output before starting the test [b04b0fd] xfs: support xfs_metadump with external logs [3ed573e] xfs/104: use fixed log size
[7657a10] generic/204: use fixed log size for XFS

David Sterba (3):
[80622a6] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0 [586a06c] xfstests: use value of FSTYP if defined externally [1ed9046] xfstests: clean command names in btrfs tests

Eric Sandeen (1):
[a93b1dd] ext4: regression test for ext4 resize with non-extent files

Filipe David Borba Manana (1):
[8c427eb] xfstests: add test for btrfs incremental send infinite loop issue

Koen De Wit (2):
[0c58766] xfstests: btrfs: cross-subvolume sparse copy [197f773] xfstests: define $seqres in btrfs/026-029

Code Diffstat:

 README              |   3 ++
 check               |  13 ++---
 common/attr         |   6 +++
 common/rc           | 122 +++++++++++++++++++++++++++---------------
 tests/btrfs/003     |   2 +-
 tests/btrfs/004     |   2 +-
 tests/btrfs/007     |   4 +-
 tests/btrfs/008     |  12 ++---
 tests/btrfs/009     |   6 +--
 tests/btrfs/013     |   2 +-
 tests/btrfs/014     |   6 +--
 tests/btrfs/015     |   2 +-
 tests/btrfs/016     |  14 ++---
 tests/btrfs/017     |   2 +-
 tests/btrfs/019     |  14 ++---
 tests/btrfs/022     |   6 +--
 tests/btrfs/024     |   2 +-
 tests/btrfs/025     |   4 +-
 tests/btrfs/026     |   1 +
 tests/btrfs/027     |   1 +
 tests/btrfs/028     |   1 +
 tests/btrfs/029     |   1 +
 tests/btrfs/030     | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/030.out |   1 +
 tests/btrfs/031     | 138 ++++++++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/031.out |  48 +++++++++++++++++
 tests/btrfs/group   |   2 +
 tests/ext4/306      |  82 +++++++++++++++++++++++++++++
 tests/ext4/306.out  |  13 +++++
 tests/ext4/group    |   1 +
 tests/generic/204   |   4 ++
 tests/generic/208   |   2 +
 tests/shared/298    |   2 +-
 tests/xfs/073       |   2 +
 tests/xfs/104       |   2 +-
 tests/xfs/186       |   1 +
 tests/xfs/187       |  32 ++++++-----
 tests/xfs/244       |   1 +
 tests/xfs/253       |   3 +-
 tests/xfs/278       |   1 +
 tests/xfs/287       |   3 +-
 tests/xfs/291       |   4 +-
 tests/xfs/306       | 105 ++++++++++++++++++++++++++++++++++++
 tests/xfs/306.out   |   2 +
 tests/xfs/group     |   1 +
 45 files changed, 716 insertions(+), 109 deletions(-)
Quoted 7 lines

--
Dave Chinner
[email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#3 lore raw
Quoted 17 lines · Eric Sandeen
Quoted 12 lines · Alex Lyakas

Hi Dave,
are all tests in xfstests (those relevant for XFS) in principle supposed to pass on XFS?
I am running these tests on a pristine XFS from kernel 3.8.13 (srcversion 9862FA08CF42E06A4151111) and I get:

root@vc-13-12-1095-35-dev:/mnt/work/alex/xfstests# ./check tests/generic/013
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 vc-13-12-1095-35-dev 3.8.13-030813-generic
MKFS_OPTIONS  -- -f -bsize=4096 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/SCRATCH_DIR
Quoted 3 lines

generic/013 34s
_check_xfs_filesystem: filesystem on /dev/vda is inconsistent (c) (see /mnt/work/alex/xfstests/results//generic/013.full)

Quoted 6 lines

uh, so it failed

Quoted 2 lines

Ran: generic/013
Passed all 1 tests

but it passed? ;)

It passed the test, but failed the post test filesystem checks.

Quoted 4 lines

The fact that you saw:

Quoted 1 line

generic/013 34s

Quoted 8 lines

and not:

Quoted 1 line

generic/013 34s ... 33s

or

Quoted 1 line

generic/013 34s ... output mismatch

or similar, makes me think the test did not even start, and /dev/vda was corrupted before you even started the test, but I'm not certain.

No, what that means is that there was no results/check.time file that had previous runtime information in it. i.e. this is the first time the test was run, or that it has always failed like this in the past on this machine.

As it is:

http://xfs.org/index.php/XFS_FAQ#Q:_What_information_should_I_include_when_reporting_a_problem.3F

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#4 lore raw

Hi Eric and Dave,
Thank you for your comments.

I don't know whether my information is of any value to you or anybody else, because I am using an EOL kernel 3.8.13.
I have run xfstests several times on two different kinds of block devices. One is a local file attached to a KVM instance through virtio, second is a custom Device Mapper. My local.config file is:
export TEST_DEV=/dev/mapper/vol-0x5
export SCRATCH_DEV=/dev/mapper/vol-0x6
export TEST_DIR=/mnt/TEST_DIR
export SCRATCH_MNT=/mnt/SCRATCH_DIR
export FSTYP="xfs"

A good amount of tests did not run, because, e.g., I do not have dump device etc. I list below the tests that failed for me consistently. I analyzed to a very limited extent these failures. At some point I decided to focus on making the tests that pass on a pristine XFS from my kernel, pass on XFS with my changes.

xfstests/xfsprogs/xfsdumps were built from latest git. fio was build on a "golden" commit aeb32dfccbd05.

tests/generic:
generic/091 - dowrite: write: Invalid argument
generic/204 - echo: write error: No space left on device
generic/240 - silence is golden, but then: AIO write offset 512 expected 4096 got -22 ... generic/263 - ???
generic/299 - fio crash
generic/300 - fio crash
generic/314 - need XFS fix for that, which is not in kernel 3.8.13

tests/xfs:
xfs/016 - log size 853 blocks too small, minimum size is 1605 blocks
xfs/018 - ???
xfs/033 - Corrupting root inode - setting bits to 0, xfsrepair: xfs_imap_to_bp: xfs_trans_read_buf() returned error 117.
xfs/041 - for some reason, in my case the log occupies much more blocks, and the 32-mb FS has no free space, so fill2fs fails
xfs/073 - after copying, the target device has dirty log..
xfs/081 - logprint with quotas
xfs/082 - v2 stripe logs with logprint
xfs/096 - mkfs.xfs: Specified data stripe width 520 is not the same as the volume stripe width 1024
xfs/104 - log size 1280 blocks too small, minimum size is 1605 blocks
xfs/109 - fails with ENOSPC
xfs/111 - Overwrote IN @offset 16384
xfs/119 - log size 1200 blocks too small, minimum size is 1968 blocks
xfs/122 - sizes/offsets of some structs/fields differ
xfs/136 - difference in internal structure's content
xfs/171 - failed, 4 streams with matching AGs
xfs/172 - expected failure, matching AGs
xfs/199 - different feature flags, like 0x8a instead of 0xa
xfs/201 - pwrite64: Invalid argument
xfs/206 - existing superblock read failed: Invalid argument
xfs/216 - number of blocks for FS's up to 64g is 12800 (constant); fssize=1g existing superblock read failed: Invalid argument
xfs/250 - xfs_repair: read failed: Invalid argument, _check_xfs_filesystem: filesystem on /mnt/TEST_DIR/250.fs is inconsistent (r) (see /mnt/work/alex/xfstests/results//xfs/250.full) xfs/262 - hard limit 0 bytes, expected 524288000
xfs/279 - mkfs failures and ERROR: Module scsi_debug is in use
xfs/291 - *** glibc detected *** xfs_repair: double free or corruption (!prev): 0x00007fbd3c0008c0 ***
xfs/292 - output differs only in spaces
xfs/296 - output is identical, except missing: missing: RESTORE_DIR/DUMP_SUBDIR/testfile cap_setgid,cap_setuid+ep
xfs/297 - output is identical, at the end: _check_xfs_filesystem: filesystem on /dev/vdb is inconsistent (c) (see /mnt/work/alex/xfstests/results//xfs/297.full) xfs/298 - single difference: core.nextents = 1 vs 0

xfs/306 doesn't fail, but sometimes triggers a memleak in xfs_trans

Thanks,
Alex.

-----Original Message----- From: Dave Chinner
Sent: 03 February, 2014 12:35 AM
To: Eric Sandeen
Cc: Alex Lyakas ; [email protected]
Subject: Re: [ANNOUNCE] xfstests updated to 197f773

Quoted 17 lines · Eric Sandeen
Quoted 12 lines · Alex Lyakas

Hi Dave,
are all tests in xfstests (those relevant for XFS) in principle supposed to pass on XFS?
I am running these tests on a pristine XFS from kernel 3.8.13 (srcversion 9862FA08CF42E06A4151111) and I get:

root@vc-13-12-1095-35-dev:/mnt/work/alex/xfstests# ./check tests/generic/013
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 vc-13-12-1095-35-dev 3.8.13-030813-generic
MKFS_OPTIONS  -- -f -bsize=4096 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/SCRATCH_DIR
Quoted 3 lines

generic/013 34s
_check_xfs_filesystem: filesystem on /dev/vda is inconsistent (c) (see /mnt/work/alex/xfstests/results//generic/013.full)

Quoted 6 lines

uh, so it failed

Quoted 2 lines

Ran: generic/013
Passed all 1 tests

but it passed? ;)

It passed the test, but failed the post test filesystem checks.

Quoted 4 lines

The fact that you saw:

Quoted 1 line

generic/013 34s

Quoted 8 lines

and not:

Quoted 1 line

generic/013 34s ... 33s

or

Quoted 1 line

generic/013 34s ... output mismatch

or similar, makes me think the test did not even start, and /dev/vda was corrupted before you even started the test, but I'm not certain.

No, what that means is that there was no results/check.time file that had previous runtime information in it. i.e. this is the first time the test was run, or that it has always failed like this in the past on this machine.

As it is:

http://xfs.org/index.php/XFS_FAQ#Q:_What_information_should_I_include_when_reporting_a_problem.3F

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected] 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#5 lore raw
Quoted 13 lines · Alex Lyakas

Hi Eric and Dave,
Thank you for your comments.

I don't know whether my information is of any value to you or anybody else, because I am using an EOL kernel 3.8.13. I have run xfstests several times on two different kinds of block devices. One is a local file attached to a KVM instance through virtio, second is a custom Device Mapper. My local.config file is:
export TEST_DEV=/dev/mapper/vol-0x5
export SCRATCH_DEV=/dev/mapper/vol-0x6
export TEST_DIR=/mnt/TEST_DIR
export SCRATCH_MNT=/mnt/SCRATCH_DIR
export FSTYP="xfs"

I'm not going to go into every test failure, but it definitely sounds like you are running on a RAID device that exposes sunit/swidth to mkfs. That is the likely cause of all the log size and stripe unit related failure. Also, you are running deprecated tests and some that are known to fail. You should run the "auto" group tests as those are the known "good" tests that should be regularly run. i.e. Try running:

# MKFS_OPTIONS="-d noalign" ./check -g auto

and that should solve amny of the log size and enospc failures that you are seeing. What is left is likely to be things we really need to fix.

FYI, we know there are things that need to be fixed - I currently see 13 tests from the auto group fail on CRC enabled filesystems:

Failures: generic/263 generic/313 xfs/021 xfs/033 xfs/066 xfs/073 xfs/189 xfs/216 xfs/295 xfs/296 xfs/299 xfs/301 xfs/302 Failed 13 of 240 tests

Several of these are test issues, some of them are bugs that need triage and fixing. We're slowly working our way through them fixing the test issues - we've been fixing 3-4 a week for the past few weeks, so the situation is getting much better - 3 weeks ago the same test machine was seeing ~25 failures in a run.

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs