Skip to contentSkip to conversation

arm64: add DSB after icache flush in __flush_icache_all()

PATCH New Vinayak Kale 3 participants 3 messages Feb 5, 2014 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: add DSB after icache flush in __flush_icache_all()

Add DSB after icache flush to complete the cache maintenance operation. The function __flush_icache_all() is used only for user space mappings and an ISB is not required because of an exception return before executing user instructions. An exception return would behave like an ISB.

---
 arch/arm64/include/asm/cacheflush.h |    1 +
 1 file changed, 1 insertion(+)
arch/arm64/include/asm/cacheflush.h +1 -0
index fea9ee3..88932498 100644
@@ -116,6 +116,7 @@ extern void flush_dcache_page(struct page *);
 static inline void __flush_icache_all(void)
 {
 	asm("ic	ialluis");
+	dsb();
 }
 
 #define flush_dcache_mmap_lock(mapping) \
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 arm64: add DSB after icache flush in __flush_icache_all()

Quoted 9 lines · Vinayak Kale

Add DSB after icache flush to complete the cache maintenance operation. The function __flush_icache_all() is used only for user space mappings and an ISB is not required because of an exception return before executing user instructions. An exception return would behave like an ISB.

---
 arch/arm64/include/asm/cacheflush.h |    1 +
 1 file changed, 1 insertion(+)

Will

maintainer
#2 lore raw

PATCH 1/1 arm64: add DSB after icache flush in __flush_icache_all()

In reply to Vinayak Kale
Quoted 6 lines · Vinayak Kale

Add DSB after icache flush to complete the cache maintenance operation. The function __flush_icache_all() is used only for user space mappings and an ISB is not required because of an exception return before executing user instructions. An exception return would behave like an ISB.

Thanks. Applied.

Signature · 1 line
Catalin