board: Add support for B&R T-Series Motherboard
PATCH 1/1 board: Add support for B&R T-Series Motherboard
Adds support for Bernecker & Rainer Industrieelektronik GmbH T-Series Motherboard, using TI's AM3352 SoC.
Most of code is derived from TI's AM335x_EVM
--- board/BuR/bur_tseries/Makefile | 13 + board/BuR/bur_tseries/board.c | 333 +++++++++++++++++++++++++ board/BuR/bur_tseries/board.h | 18 ++ board/BuR/bur_tseries/mux.c | 224 +++++++++++++++++ board/BuR/bur_tseries/u-boot.lds | 101 ++++++++ include/configs/bur_tseries.h | 512 ++++++++++++++++++++++++++++++++++++++ 6 files changed, 1201 insertions(+) create mode 100644 board/BuR/bur_tseries/Makefile create mode 100644 board/BuR/bur_tseries/board.c create mode 100644 board/BuR/bur_tseries/board.h create mode 100644 board/BuR/bur_tseries/mux.c create mode 100644 board/BuR/bur_tseries/u-boot.lds create mode 100644 include/configs/bur_tseries.h
board/BuR/bur_tseries/Makefile new file +13 -0
@@ -0,0 +1,13 @@ +# +# Makefile +# +# Copyright (C) 2013 Hannes Petermaier <[email protected]> +# Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com +# +# SPDX-License-Identifier: GPL-2.0+ +# + +ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y) +obj-y := mux.o +endif +obj-y += board.o
board/BuR/bur_tseries/board.c new file +333 -0
333 lines not on this page · raw message
board/BuR/bur_tseries/board.h new file +18 -0
@@ -0,0 +1,18 @@ +/* +* board.h +* +* BUR-LEIT boards information header +* +* Copyright (C) 2013 Hannes Petermaier <[email protected]> +* Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#ifndef _BOARD_H_ +#define _BOARD_H_ + +void enable_uart0_pin_mux (void ); +void enable_i2c0_pin_mux (void ); +void enable_board_pin_mux (void ); +#endif
board/BuR/bur_tseries/mux.c new file +224 -0
224 lines not on this page · raw message
board/BuR/bur_tseries/u-boot.lds new file +101 -0
101 lines not on this page · raw message
include/configs/bur_tseries.h new file +512 -0
512 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v2 1/1 board: Add support for B&R T-Series Motherboard
Adds support for Bernecker & Rainer Industrieelektronik GmbH T-Series Motherboard, using TI's AM3352 SoC.
Most of code is derived from TI's AM335x_EVM
---
Changes for v2:
- added T-Series to boards.cfg (forgotten before)
board/BuR/bur_tseries/Makefile | 13 + board/BuR/bur_tseries/board.c | 333 +++++++++++++++++++++++++ board/BuR/bur_tseries/board.h | 18 ++ board/BuR/bur_tseries/mux.c | 224 +++++++++++++++++ board/BuR/bur_tseries/u-boot.lds | 101 ++++++++ boards.cfg | 3 + include/configs/bur_tseries.h | 512 ++++++++++++++++++++++++++++++++++++++ 7 files changed, 1204 insertions(+) create mode 100644 board/BuR/bur_tseries/Makefile create mode 100644 board/BuR/bur_tseries/board.c create mode 100644 board/BuR/bur_tseries/board.h create mode 100644 board/BuR/bur_tseries/mux.c create mode 100644 board/BuR/bur_tseries/u-boot.lds create mode 100644 include/configs/bur_tseries.h
board/BuR/bur_tseries/Makefile new file +13 -0
@@ -0,0 +1,13 @@ +# +# Makefile +# +# Copyright (C) 2013 Hannes Petermaier <[email protected]> +# Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com +# +# SPDX-License-Identifier: GPL-2.0+ +# + +ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y) +obj-y := mux.o +endif +obj-y += board.o
board/BuR/bur_tseries/board.c new file +333 -0
333 lines not on this page · raw message
board/BuR/bur_tseries/board.h new file +18 -0
@@ -0,0 +1,18 @@ +/* +* board.h +* +* BUR-LEIT boards information header +* +* Copyright (C) 2013 Hannes Petermaier <[email protected]> +* Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#ifndef _BOARD_H_ +#define _BOARD_H_ + +void enable_uart0_pin_mux (void ); +void enable_i2c0_pin_mux (void ); +void enable_board_pin_mux (void ); +#endif
board/BuR/bur_tseries/mux.c new file +224 -0
224 lines not on this page · raw message
board/BuR/bur_tseries/u-boot.lds new file +101 -0
101 lines not on this page · raw message
boards.cfg +3 -0
@@ -255,6 +255,9 @@ Active arm armv7 am33xx phytec pcm051 Active arm armv7 am33xx siemens dxr2 dxr2 - Roger Meier <[email protected]> Active arm armv7 am33xx siemens pxm2 pxm2 - Roger Meier <[email protected]> Active arm armv7 am33xx siemens rut rut - Roger Meier <[email protected]> +Active arm armv7 am33xx BuR bur_tseries bur_tseries_nand bur_tseries:SERIAL1,CONS_INDEX=1,NAND Hannes Petermaier <[email protected]> +Active arm armv7 am33xx BuR bur_tseries bur_tseries_mmc bur_tseries:SERIAL1,CONS_INDEX=1,EMMC_BOOT Hannes Petermaier <[email protected]> +Active arm armv7 am33xx BuR bur_tseries bur_tseries_spi bur_tseries:SERIAL1,CONS_INDEX=1,SPI_BOOT,EMMC_BOOT Hannes Petermaier <[email protected]> Active arm armv7 am33xx ti am335x am335x_boneblack am335x_evm:SERIAL1,CONS_INDEX=1,EMMC_BOOT Tom Rini <[email protected]> Active arm armv7 am33xx ti am335x am335x_evm am335x_evm:SERIAL1,CONS_INDEX=1,NAND Tom Rini <[email protected]> Active arm armv7 am33xx ti am335x am335x_evm_nor am335x_evm:SERIAL1,CONS_INDEX=1,NAND,NOR Tom Rini <[email protected]>
include/configs/bur_tseries.h new file +512 -0
512 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v2 1/1 board: Add support for B&R T-Series Motherboard
Dear Hannes,
Quoted 11 lines · In message <[email protected]> you wrote:
Adds support for Bernecker & Rainer Industrieelektronik GmbH T-Series Motherboard, using TI's AM3352 SoC.
Most of code is derived from TI's
AM335x_EVMSigned-off-by Hannes Petermaier <[email protected]>Cc trini at ti.com---
Changes for v2:
- added T-Series to boards.cfg (forgotten before)
Quoted 7 lines
board/BuR/bur_tseries/Makefile | 13 + board/BuR/bur_tseries/board.c | 333 +++++++++++++++++++++++++ board/BuR/bur_tseries/board.h | 18 ++ board/BuR/bur_tseries/mux.c | 224 +++++++++++++++++ board/BuR/bur_tseries/u-boot.lds | 101 ++++++++ boards.cfg | 3 + include/configs/bur_tseries.h | 512 ++++++++++++++++++++++++++++++++++++++
This is soemwhat redundant naming - you have the vendor name already encoded in the vendor directory, so it is not necessary to repeat it in the board directory name.
I think it would be better to have:
board/BuR/tseries/*
Quoted 1 line
+++
b/board/BuR/bur_tseries/board.c
...
Quoted 2 lines
+ * 04.02.2014 hpm very first board support for T-SERIES,
+ * based onboard/ti/am335x/board.c
Please do not add any such changelog information to the source code. We use git to track code modifications, which is much more powerful.
board/BuR/bur_tseries/board.c line 45
Quoted 4 lines
board/BuR/bur_tseries/board.c new file +4
-0+/* --------------------------------------------------------------------------*/ +/* -- defines for GPIO -- */ +#define ETHLED_ORANGE (96+16)/* GPIO3_16 */ +#define REPSWITCH (0+20)/* GPIO0_20 */
Should these not rather go to the board config header file?
board/BuR/bur_tseries/u-boot.lds
Quoted 5 lines
board/BuR/bur_tseries/u-boot.lds new file +0
-0
Are you sure you need a board specific linker script? Why?
Quoted 6 lines
include/configs/bur_tseries.h new file +0
-0@@ -0,0 +1,512 @@
...
Quoted 1 line
+/*#define DEBUG */
...
include/configs/bur_tseries.h line 25
Quoted 6 lines
include/configs/bur_tseries.h new file +6
-0+#if _HPMTEST +#define CONFIG_SILENT_CONSOLE +#define CONFIG_SILENT_U_BOOT_ONLY +#define CONFIG_SILENT_CONSOLE_UPDATE_ON_SET +#define CONFIG_SYS_DEVICE_NULLDEV +#endif /* _HPMTEST */
Please remove such dead code.
Quoted 1 line
+#define
CONFIG_ENV_VARS_UBOOT_CONFIG/* Strongly encouraged */
Really? What exactly do you use these for?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Success is not the opposite of failure. Failure is the vital ingredient in the recipe for success. - Mario Cortes
PATCH v3 1/1 board: Add support for B&R T-Series Motherboard
In reply to Hannes PetermaierAdds support for Bernecker & Rainer Industrieelektronik GmbH T-Series Motherboard, using TI's AM3352 SoC.
Most of code is derived from TI's AM335x_EVM
---
Changes for v3:
- created a bur_am335x_common.h config file
- shared common B&R code into .../BuR/common/
- fixed style problems
- many cosmetical changes
Changes for v2:
- added T-Series to boards.cfg (forgotten before)
board/BuR/common/bur_common.h | 22 +++ board/BuR/common/common.c | 216 ++++++++++++++++++++++++++++ board/BuR/tseries/Makefile | 14 ++ board/BuR/tseries/board.c | 148 +++++++++++++++++++ board/BuR/tseries/mux.c | 226 +++++++++++++++++++++++++++++ boards.cfg | 3 + include/configs/bur_am335x_common.h | 197 ++++++++++++++++++++++++++ include/configs/tseries.h | 265 +++++++++++++++++++++++++++++++++++ 8 files changed, 1091 insertions(+) create mode 100644 board/BuR/common/bur_common.h create mode 100644 board/BuR/common/common.c create mode 100644 board/BuR/tseries/Makefile create mode 100644 board/BuR/tseries/board.c create mode 100644 board/BuR/tseries/mux.c create mode 100644 include/configs/bur_am335x_common.h create mode 100644 include/configs/tseries.h
board/BuR/common/bur_common.h new file +22 -0
@@ -0,0 +1,22 @@ +/* +* bur_comon.h +* +* common board information header for B&R boards +* +* Copyright (C) 2013 Hannes Petermaier <[email protected]> +* Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com +* +* SPDX-License-Identifier: GPL-2.0+ +*/ + +#ifndef _BUR_COMMON_H_ +#define _BUR_COMMON_H_ + +void blink (u32 blinks,u32 intervall,u32 pin); +void pmicsetup (u32 mpupll); +void enable_uart0_pin_mux (void ); +void enable_i2c0_pin_mux (void ); +void enable_board_pin_mux (void ); +int board_eth_init (bd_t *bis); + +#endif
board/BuR/common/common.c new file +216 -0
216 lines not on this page · raw message
board/BuR/tseries/Makefile new file +14 -0
@@ -0,0 +1,14 @@ +# +# Makefile +# +# Copyright (C) 2013 Hannes Petermaier <[email protected]> +# Bernecker & Rainer Industrieelektronik GmbH - http://www.br-automation.com +# +# SPDX-License-Identifier: GPL-2.0+ +# + +ifeq ($(CONFIG_SPL_BUILD),y) +obj-y := mux.o +endif +obj-y += ../common/common.o +obj-y += board.o
board/BuR/tseries/board.c new file +148 -0
148 lines not on this page · raw message
board/BuR/tseries/mux.c new file +226 -0
226 lines not on this page · raw message
boards.cfg +3 -0
@@ -255,6 +255,9 @@ Active arm armv7 am33xx phytec pcm051 Active arm armv7 am33xx siemens dxr2 dxr2 - Roger Meier <[email protected]> Active arm armv7 am33xx siemens pxm2 pxm2 - Roger Meier <[email protected]> Active arm armv7 am33xx siemens rut rut - Roger Meier <[email protected]> +Active arm armv7 am33xx BuR tseries tseries_nand tseries:SERIAL1,CONS_INDEX=1,NAND Hannes Petermaier <[email protected]> +Active arm armv7 am33xx BuR tseries tseries_mmc tseries:SERIAL1,CONS_INDEX=1,EMMC_BOOT Hannes Petermaier <[email protected]> +Active arm armv7 am33xx BuR tseries tseries_spi tseries:SERIAL1,CONS_INDEX=1,SPI_BOOT,EMMC_BOOT Hannes Petermaier <[email protected]> Active arm armv7 am33xx ti am335x am335x_boneblack am335x_evm:SERIAL1,CONS_INDEX=1,EMMC_BOOT Tom Rini <[email protected]> Active arm armv7 am33xx ti am335x am335x_evm am335x_evm:SERIAL1,CONS_INDEX=1,NAND Tom Rini <[email protected]> Active arm armv7 am33xx ti am335x am335x_evm_nor am335x_evm:SERIAL1,CONS_INDEX=1,NAND,NOR Tom Rini <[email protected]>
include/configs/bur_am335x_common.h new file +197 -0
197 lines not on this page · raw message
include/configs/tseries.h new file +265 -0
265 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v3 1/1 board: Add support for B&R T-Series Motherboard
Quoted 6 lines · Hannes Petermaier
Adds support for Bernecker & Rainer Industrieelektronik GmbH T-Series Motherboard, using TI's AM3352 SoC.
Most of code is derived from TI's
AM335x_EVMSigned-off-by Hannes Petermaier <[email protected]>
Applied to u-boot-ti/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140221/ee432c7f/attachment.pgp>