Skip to contentSkip to conversation

filter BR2_DEFCONFIG out of defconfig files

PATCH New Jérémy Rosen 4 participants 9 messages Feb 4, 2014 – Feb 6, 2014 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 4a675d4..f63a058 100644
@@ -772,6 +772,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 	@$(COMMON_CONFIG_ENV) $< \
 		--savedefconfig=$(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) \
 		$(CONFIG_CONFIG_IN)
+	sed -i '/^BR2_DEFCONFIG=/d' $(DEFCONFIG)
 
 # check if download URLs are outdated
 source-check:
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

Hi,

Quoted 5 lines · J?r?my Rosen

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

The entire BR2_DEFCONFIG mechanism has never done what I expected. What I want is that 'make savedefconfig' (or a similar command) saves the configuration back to where it originated from. BR2_DEFCONFIG does more or less that, but only if you set the configuration initially with 'make defconfig BR2_DEFCONFIG=...' instead of the normal 'make xxxx_defconfig'. Isn't this possible to achieve?

Best regards,
Thomas

#2 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

Quoted 9 lines · Thomas De Schampheleire

Hi,

Quoted 5 lines · J?r?my Rosen

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

Quoted 6 lines

The entire BR2_DEFCONFIG mechanism has never done what I expected. What I want is that 'make savedefconfig' (or a similar command) saves the configuration back to where it originated from. BR2_DEFCONFIG does more or less that, but only if you set the configuration initially with 'make defconfig BR2_DEFCONFIG=...' instead of the normal 'make xxxx_defconfig'. Isn't this possible to achieve?

Sure, quite easily. However, is that really what we want?

make rpi_defconfig
add some packages
test test test
add more packages
test test test
make savedefconfig

Oops I've just overwritten rpi_defconfig.

It's probably what you want when using BR2_EXTERNAL, but not when using
a buildroot defconfig. Unless, of course, you don't use BR2_EXTERNAL but add directly to the buildroot directory...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

Arnout, All,

On 2014-02-05 23:46 +0100, Arnout Vandecappelle spake thusly:

Quoted 8 lines

make rpi_defconfig
add some packages
test test test
add more packages
test test test
make savedefconfig

Oops I've just overwritten rpi_defconfig.

Oh no! Not rpi_defconfig!

Sorry, couldn't resist... ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

In reply to Arnout Vandecappelle

Hi Arnout,

Quoted 27 lines · Arnout Vandecappelle
Quoted 9 lines · Thomas De Schampheleire

Hi,

Quoted 5 lines · J?r?my Rosen

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

Quoted 6 lines

The entire BR2_DEFCONFIG mechanism has never done what I expected. What I want is that 'make savedefconfig' (or a similar command) saves the configuration back to where it originated from. BR2_DEFCONFIG does more or less that, but only if you set the configuration initially with 'make defconfig BR2_DEFCONFIG=...' instead of the normal 'make xxxx_defconfig'. Isn't this possible to achieve?

Sure, quite easily. However, is that really what we want?

make rpi_defconfig
add some packages
test test test
add more packages
test test test
make savedefconfig

Quoted 6 lines

Oops I've just overwritten rpi_defconfig.

It's probably what you want when using BR2_EXTERNAL, but not when using
a buildroot defconfig. Unless, of course, you don't use BR2_EXTERNAL but add directly to the buildroot directory...

The question is how you define 'a buildroot defconfig'. Not so long ago, our recommendation for 'real' projects was to also put project defconfigs in configs/. For these defconfigs, I do expect the described behavior. It's true that an end-user with a raspberrypi should create his own private defconfig, from which point the described behavior is again desirable. A buildroot developer improving the raspberrypi defconfig (on purpose) wants the behavior as well. So the only situation where it is not desirable is when you start from a non-project defconfig and make private modifications.

One way forward is to introduce a new config variable, enabled on all non-project defconfigs, stating that we do not want this behavior. The buildroot developer improving the raspberrypi defconfig will have to do something special, but this may be acceptable.

The project developer now has a useful improvement in workflow.

What do you think of that?

Thanks,
Thomas

#5 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

Quoted 47 lines · Thomas De Schampheleire

Hi Arnout,

Quoted 27 lines · Arnout Vandecappelle
Quoted 9 lines · Thomas De Schampheleire

Hi,

Quoted 5 lines · J?r?my Rosen

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

Quoted 6 lines

The entire BR2_DEFCONFIG mechanism has never done what I expected. What I want is that 'make savedefconfig' (or a similar command) saves the configuration back to where it originated from. BR2_DEFCONFIG does more or less that, but only if you set the configuration initially with 'make defconfig BR2_DEFCONFIG=...' instead of the normal 'make xxxx_defconfig'. Isn't this possible to achieve?

Sure, quite easily. However, is that really what we want?

make rpi_defconfig
add some packages
test test test
add more packages
test test test
make savedefconfig

Quoted 6 lines

Oops I've just overwritten rpi_defconfig.

It's probably what you want when using BR2_EXTERNAL, but not when using
a buildroot defconfig. Unless, of course, you don't use BR2_EXTERNAL but add directly to the buildroot directory...

The question is how you define 'a buildroot defconfig'. Not so long ago, our recommendation for 'real' projects was to also put project defconfigs in configs/. For these defconfigs, I do expect the described behavior. It's true that an end-user with a raspberrypi should create his own private defconfig, from which point the described behavior is again desirable. A buildroot developer improving the raspberrypi defconfig (on purpose) wants the behavior as well. So the only situation where it is not desirable is when you start from a non-project defconfig and make private modifications.

Quoted 8 lines

One way forward is to introduce a new config variable, enabled on all non-project defconfigs, stating that we do not want this behavior. The buildroot developer improving the raspberrypi defconfig will have to do something special, but this may be acceptable.

The project developer now has a useful improvement in workflow.

What do you think of that?

OK, so in most cases we really want the original defconfig to be
overwritten on savedefconfig. It is only when it's one of buildroot's own config files that we prefer to protect the user.

I'm not happy with the solution you propose, though, because it adds
complexity and yet another config option for not much of a feature. How about this one, though: for users who clone the git tree, it's not much of a problem since they'll see they made a mistake; for the release tarballs, we can just make configs/*_defconfig readonly while creating the tarball.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#6 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

In reply to Jérémy Rosen

J?r?my, All,

On 2014-02-04 15:12 +0100, J?r?my Rosen spake thusly:

Quoted 16 lines

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +0 -0
index 4a675d4..f63a058 100644

Makefile savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile · line 775

Quoted 4 lines
Makefile +1 -0
@@ -772,6 +772,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 	@$(COMMON_CONFIG_ENV) $< \
 		--savedefconfig=$(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) \
 		$(CONFIG_CONFIG_IN)
+	sed -i '/^BR2_DEFCONFIG=/d' $(DEFCONFIG)

Should be:

    $(SED) '/blabla/'

$(SED) already contains -i

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

In reply to Jérémy Rosen
Quoted 7 lines · J?r?my Rosen

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

Jeremy, I guess this patch is superseded by mine?

Regards,
Arnout

Quoted 17 lines
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 4a675d4..f63a058 100644
@@ -772,6 +772,7 @@ savedefconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 	@$(COMMON_CONFIG_ENV) $< \
 		--savedefconfig=$(if $(DEFCONFIG),$(DEFCONFIG),$(CONFIG_DIR)/defconfig) \
 		$(CONFIG_CONFIG_IN)
+	sed -i '/^BR2_DEFCONFIG=/d' $(DEFCONFIG)
 
 # check if download URLs are outdated
 source-check:
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#8 lore raw

PATCH 1/1 filter BR2_DEFCONFIG out of defconfig files

----- Mail original -----

Quoted 11 lines · J?r?my Rosen
Quoted 7 lines

When it is set, BR2_DEFCONFIG is saved like any config variable. However, at this point it is a completely expanded, absolute path It is not a good idea to save absolute paths in defconfig files moreover it makes little sense to save the defconfig location within the defconfig

Jeremy, I guess this patch is superseded by mine?

yes, I should have pointed that out, sorry