Skip to contentSkip to conversation

spi: orion: Remove unused pointer in orion_spi_write_read()

PATCH In review Christian Engelmayer 2 participants 5 messages Feb 5, 2014 2 messages not in the archive SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: orion: Remove unused pointer in orion_spi_write_read()

Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read().

Detected by Coverity: CID 1077860.

---
 drivers/spi/spi-orion.c | 2 --
 1 file changed, 2 deletions(-)
drivers/spi/spi-orion.c +0 -2
index 7f2121f..75871d4 100644
@@ -260,11 +260,9 @@ orion_spi_write_read_16bit(struct spi_device *spi,
 static unsigned int
 orion_spi_write_read(struct spi_device *spi, struct spi_transfer *xfer)
 {
-	struct orion_spi *orion_spi;
 	unsigned int count;
 	int word_len;
 
-	orion_spi = spi_master_get_devdata(spi->master);
 	word_len = spi->bits_per_word;
 	count = xfer->len;
 
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 5 lines · Christian Engelmayer

Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read().

Detected by Coverity: CID 1077860.

I'll apply this but please follow the patch submission process in SubmittingPatches, in particular please always CC maintainers on patches.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 3 lines

I'll apply this but please follow the patch submission process in SubmittingPatches, in particular please always CC maintainers on patches.

Thanks. For trivial patches like this I tend to rely on get_maintainer.pl which clearly pointed me to You. I'll put more investigation into it again next time.

#4 lore raw
Quoted 7 lines · Christian Engelmayer
Quoted 3 lines

I'll apply this but please follow the patch submission process in SubmittingPatches, in particular please always CC maintainers on patches.

Thanks. For trivial patches like this I tend to rely on get_maintainer.pl which clearly pointed me to You. I'll put more investigation into it again next time.

It should've listed the maintainer as [email protected] rather at linaro.org which was where you sent this - IIRC you posted some other
stuff recently which missed my comaintainer on that subsystem. Checking
right now I can't get it to give my Linaro address at all for that file,
odd. It could find that via signoffs but it seems to have squashed
those into the maintainer section.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 9 lines · Mark Brown
Quoted 7 lines · Christian Engelmayer
Quoted 3 lines

I'll apply this but please follow the patch submission process in SubmittingPatches, in particular please always CC maintainers on patches.

Thanks. For trivial patches like this I tend to rely on get_maintainer.pl which clearly pointed me to You. I'll put more investigation into it again next time.

Quoted 6 lines

It should've listed the maintainer as [email protected] rather at linaro.org which was where you sent this - IIRC you posted some other
stuff recently which missed my comaintainer on that subsystem. Checking
right now I can't get it to give my Linaro address at all for that file,
odd. It could find that via signoffs but it seems to have squashed
those into the maintainer section.

You are right, I already recently used Your linaro address and the referenced
commit that led me to addressing You and just CC the list was signed-off-by [email protected] Interestingly I had both Your linaro/kernel.org addresses in my MUA's address book - prefering linaro. So get_maintainer.pl in this case
chose Mark Brown, but isn't to blame for the wrong address. Again, my apologies
for the noise.