Skip to contentSkip to conversation

Add Ether's PHY IRQ support for Lager/Koelsh boards

PATCH New Sergei Shtylyov 3 participants 7 messages Feb 4, 2014 – Feb 6, 2014 SuperH

lore
Share & tools
lore
#0 lore raw

cover Add Ether's PHY IRQ support for Lager/Koelsh boards

Hello.

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

PS: Sorry for the previous mail, I've hit Ctrl-Enter unexpectedly.

WBR, Sergei

#1 lore raw

PATCH v2 1/2 ARM: shmobile: Lager: pass Ether PHY IRQ

Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ trigger type to be low-level as per the Micrel PHY driver's setup.

---
Changes in version 2:
- refreshed the patch.

 arch/arm/mach-shmobile/board-lager.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-lager.c =================================--- renesas.orig/arch/arm/mach-shmobile/board-lager.c +++ renesas/arch/arm/mach-shmobile/board-lager.c
@@ -22,6 +22,7 @@
#include <linux/gpio_keys.h>
#include <linux/input.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/mmc/host.h>
@@ -233,6 +234,7 @@ static const struct resource mmcif1_reso
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -618,6 +620,8 @@ static void __init lager_init(void)
{
lager_add_standard_devices();

+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7790-ether-ff:01",
lager_ksz8041_fixup);

#2 lore raw

PATCH v2 2/2 ARM: shmobile: Koelsch: pass Ether PHY IRQ

In reply to Sergei Shtylyov

Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ trigger type to be low-level as per the Micrel PHY driver's setup.

---
Changes in version 2:
- refreshed the patch.

 arch/arm/mach-shmobile/board-koelsch.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-koelsch.c =================================--- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c +++ renesas/arch/arm/mach-shmobile/board-koelsch.c
@@ -23,6 +23,7 @@
#include <linux/gpio.h>
#include <linux/gpio_keys.h>
#include <linux/input.h>
+#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/leds.h>
#include <linux/phy.h>
@@ -92,6 +93,7 @@ static void __init koelsch_add_du_device
/* Ether */
static const struct sh_eth_plat_data ether_pdata __initconst = {
.phy = 0x1,
+ .phy_irq = irq_pin(0),
.edmac_endian = EDMAC_LITTLE_ENDIAN,
.phy_interface = PHY_INTERFACE_MODE_RMII,
.ether_link_active_low = 1,
@@ -232,6 +234,8 @@ static void __init koelsch_init(void)
{
koelsch_add_standard_devices();

+ irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_id("r8a7791-ether-ff:01",
koelsch_ksz8041_fixup);

#3 lore raw

cover Add Ether's PHY IRQ support for Lager/Koelsh boards

In reply to Sergei Shtylyov

Hi Sergei,

Quoted 8 lines · Sergei Shtylyov

Hello.

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

Thanks, looking good!

/ magnus

#4 lore raw

cover Add Ether's PHY IRQ support for Lager/Koelsh boards

Hello.

Quoted 8 lines · Magnus Damm
Quoted 6 lines

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

Thanks, looking good!

Not at all, you've already tested these patches, IIRC.

Quoted 1 line

/ magnus

WBR, Sergei

#5 lore raw

cover Add Ether's PHY IRQ support for Lager/Koelsh boards

Quoted 8 lines · Sergei Shtylyov

Hello.

Quoted 3 lines · Magnus Damm
Quoted 3 lines

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

Thanks, looking good!

Not at all, you've already tested these patches, IIRC.

Thanks, I have queued these up with Magnus's ack which he supplied the previous time that you posted them.

#6 lore raw

cover Add Ether's PHY IRQ support for Lager/Koelsh boards

Hello.

Quoted 7 lines · Simon Horman
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Thanks, looking good!

Not at all, you've already tested these patches, IIRC.

Thanks, I have queued these up with Magnus's ack which he supplied the previous time that you posted them.

Oh, sorry, I forgot to pick it up myself. :-/

WBR, Sergei