RDMA/nes: clean up a conditon
Subsystems (2)
PATCH 1/1 RDMA/nes: clean up a conditon
We don't need to test "ret" twice and also the white space is messed up.
drivers/infiniband/hw/nes/nes_verbs.c +1 -3
@@ -3134,9 +3134,7 @@ int nes_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr," original_last_aeq = 0x%04X. last_aeq = 0x%04X.\n" , nesqp->hwqp.qp_id,atomic_read (&nesqp->refcount), original_last_aeq, nesqp->last_aeq); -if ((!ret) || - ((original_last_aeq !=NES_AEQE_AEID_RDMAP_ROE_BAD_LLP_CLOSE ) && - (ret))) { +if (!ret || original_last_aeq !=NES_AEQE_AEID_RDMAP_ROE_BAD_LLP_CLOSE ) {if (dont_wait) {if (nesqp->cm_id && nesqp->hw_tcp_state !=0 ) { nes_debug(NES_DBG_MOD_QP, "QP%u Queuing fake disconnect for QP refcount (%d),"
Hello Dan,
Your patch seems fine. If you want, feel free to add:
Thank you,
Tatyana
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Dan Carpenter
Sent: Thursday, February 06, 2014 6:48 AM
To: Latif, Faisal
Cc: Roland Dreier; Hefty, Sean; Hal Rosenstock; [email protected]; [email protected]
Subject: [patch] RDMA/nes: clean up a conditon
We don't need to test "ret" twice and also the white space is messed up.
drivers/infiniband/hw/nes/nes_verbs.c +2 -3
@@ -3134,9 +3134,7 @@ int nes_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr," original_last_aeq = 0x%04X. last_aeq = 0x%04X.\n" , nesqp->hwqp.qp_id,atomic_read (&nesqp->refcount), original_last_aeq, nesqp->last_aeq); -if ((!ret) || - ((original_last_aeq !=NES_AEQE_AEID_RDMAP_ROE_BAD_LLP_CLOSE ) && - (ret))) { +if (!ret || original_last_aeq != +NES_AEQE_AEID_RDMAP_ROE_BAD_LLP_CLOSE ) {if (dont_wait) {if (nesqp->cm_id && nesqp->hw_tcp_state !=0 ) {
nes_debug(NES_DBG_MOD_QP, "QP%u Queuing fake disconnect for QP refcount (%d),"
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html