spi: davinci: Use of_match_ptr at appropriate place
PATCH 1/1 spi: davinci: Use of_match_ptr at appropriate place
It's pointless to use of_match_ptr within CONFIG_OF guard.
Use of_match_ptr around davinci_spi_of_match when setting .of_match_table.
Signed-off-by Axel Lin <[email protected]>
--- drivers/spi/spi-davinci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/spi/spi-davinci.c +2 -4
@@ -802,8 +802,7 @@ static int spi_davinci_get_pdata(struct platform_device *pdev, pdata = &dspi->pdata; pdata->version =SPI_VERSION_1 ; - match =of_match_device (of_match_ptr (davinci_spi_of_match), - &pdev->dev); + match =of_match_device (davinci_spi_of_match, &pdev->dev);if (!match)return -ENODEV ;
@@ -824,7 +823,6 @@ static int spi_davinci_get_pdata(struct platform_device *pdev, return 0; }#else -#define davinci_spi_of_match NULLstatic struct davinci_spi_platform_data *spi_davinci_get_pdata (struct platform_device *pdev,struct davinci_spi *dspi)
@@ -1032,7 +1030,7 @@ static struct platform_driver davinci_spi_driver = { .driver = { .name = "spi_davinci", .owner = THIS_MODULE, - .of_match_table = davinci_spi_of_match, + .of_match_table = of_match_ptr(davinci_spi_of_match), }, .probe = davinci_spi_probe, .remove = davinci_spi_remove,
Signature · 8 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Brown
AppliedQuoted 2 lines · Axel Lin
It's pointless to use
of_match_ptrwithinCONFIG_OFguard.
Useof_match_ptrarounddavinci_spi_of_matchwhen setting .of_match_table.
Applied, thanks.