Skip to contentSkip to conversation

Qt5: update to 5.2.1

PATCH New Peter Kuemmel 2 participants 5 messages Feb 6, 2014

lore
Share & tools
lore
#2 lore raw

PATCH 1/2 Qt5: update to 5.2.1

In reply to Peter Kuemmel

Dear Peter Kuemmel,

Quoted 7 lines · Peter Kuemmel

From 315027aef2dec428857bcd0699ea60a7bcc80a8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Peter=20K=C3=BCmmel?= <[email protected]>
Date: Wed, 5 Feb 2014 20:49:47 +0100
Subject: [PATCH 1/2] Qt5: update to 5.2.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As explained in the documentation, could you use "git send-email" to send your patches? For the moment, they are sent as attached files, which is very unpractical for review.

Thanks a lot for these contributions!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/2 Qt5: update to 5.2.1

Quoted 3 lines

Von: "Thomas Petazzoni" <[email protected]>

As explained in the documentation, could you use "git send-email" to

Sorry, I thought using send-email is just optional.

So someone else interested should put it into the queue, but don't use my signed-off patches.

The qttools patch needs a change:

+ cp -dpf $(STAGING_DIR)/usr/lib/libQt5Help.so.* $(TARGET_DIR)/usr/lib
+ cp -dpf $(STAGING_DIR)/usr/lib/libQt5CLucene.so.* $(TARGET_DIR)/usr/lib

Thanks,
Peter

Quoted 11 lines

send your patches? For the moment, they are sent as attached files, which is very unpractical for review.

Thanks a lot for these contributions!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/2 Qt5: update to 5.2.1

Dear Peter Kuemmel,

Quoted 3 lines · Peter Kuemmel
Quoted 1 line

As explained in the documentation, could you use "git send-email" to

Sorry, I thought using send-email is just optional.

It is in some sense optional, if you do send patches "the right way". But the easiest solution to send them "the right way" is to use git send-email.

Quoted 2 lines

So someone else interested should put it into the queue, but don't use my signed-off patches.

Unfortunately, this often doesn't work: once someone sends patches, there are review comments, and the submitter often has to make a few changes, and resubmit. So if someone else picks up your patches, he will have to do this work, while as the original author of the patches, it would be much easier if you did this work.

Those contributions are very useful to Buildroot, so it would very appreciated if you could go through the contribution process completely. I know it takes a bit of time, but it is a necessary process to ensure that the quality of patches merged is up to the standards the community has defined.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com