ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
Subsystems (3)
PATCH 1/1 ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
This brings the implementation into line with the documentation.
This problem was introduced when SYS DMAC clock defines were added by ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT sources") in v3.13-rc2. I do not believe this results in any problems as these defines do not appear to be used anywhere yet.
--- include/dt-bindings/clock/r8a7790-clock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/dt-bindings/clock/r8a7790-clock.h +2 -2
@@ -46,8 +46,8 @@#define R8A7790_CLK_MSIOF1 8#define R8A7790_CLK_MSIOF3 15#define R8A7790_CLK_SCIFB2 16 -#define R8A7790_CLK_SYS_DMAC0 18 -#define R8A7790_CLK_SYS_DMAC1 19 +#define R8A7790_CLK_SYS_DMAC1 18 +#define R8A7790_CLK_SYS_DMAC0 19/* MSTP3 */ #define R8A7790_CLK_TPU0 4
Signature · 1 line
1.8.5.2
PATCH 1/1 ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
Hi Simon,
Thank you for the patch.
Quoted 9 lines · On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
This brings the implementation into line with the documentation.
This problem was introduced when SYS DMAC clock defines were added by
ac991dce6498b5fc("ARM: shmobile: r8a7790: Add clock index macros for DT sources") in v3.13-rc2. I do not believe this results in any problems as these defines do not appear to be used anywhere yet.Cc Laurent Pinchart <[email protected]>Signed-off-by Simon Horman <[email protected]>
Quoted 19 lines
--- include/dt-bindings/clock/r8a7790-clock.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/include/dt-bindings/clock/r8a7790-clock.hindex 859e9be..6548a5f 100644include/dt-bindings/clock/r8a7790-clock.h +2
-2@@ -46,8 +46,8 @@#define R8A7790_CLK_MSIOF1 8#define R8A7790_CLK_MSIOF3 15#define R8A7790_CLK_SCIFB2 16 -#define R8A7790_CLK_SYS_DMAC0 18 -#define R8A7790_CLK_SYS_DMAC1 19 +#define R8A7790_CLK_SYS_DMAC1 18 +#define R8A7790_CLK_SYS_DMAC0 19/* MSTP3 */ #define R8A7790_CLK_TPU0 4
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
Quoted 12 lines · Laurent Pinchart
Hi Simon,
Thank you for the patch.
Quoted 7 lines · On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
This brings the implementation into line with the documentation.
This problem was introduced when SYS DMAC clock defines were added by
ac991dce6498b5fc("ARM: shmobile: r8a7790: Add clock index macros for DT sources") in v3.13-rc2. I do not believe this results in any problems as these defines do not appear to be used anywhere yet.
Quoted 4 lines
Quoted 2 lines
Cc Laurent Pinchart <[email protected]>Signed-off-by Simon Horman <[email protected]>Acked-by Laurent Pinchart <[email protected]>
Thanks, I have queued this up.
PATCH 1/1 ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
In reply to Simon HormanQuoted 9 lines · Simon Horman
This brings the implementation into line with the documentation.
This problem was introduced when SYS DMAC clock defines were added by
ac991dce6498b5fc("ARM: shmobile: r8a7790: Add clock index macros for DT sources") in v3.13-rc2. I do not believe this results in any problems as these defines do not appear to be used anywhere yet.Cc Laurent Pinchart <[email protected]>Signed-off-by Simon Horman <[email protected]>
I agree, although I have yet to get the DMA working.
Signature · 2 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius