Skip to contentSkip to conversation

SoC: wm8991: Remove unused pointer in wm8991_probe()

PATCH Superseded Christian Engelmayer 2 participants 4 messages Feb 4, 2014 – Feb 7, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SoC: wm8991: Remove unused pointer in wm8991_probe()

Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)

Detected by Coverity: CID 1162831

---
 sound/soc/codecs/wm8991.c | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/codecs/wm8991.c +0 -3
index dba0306..244eb09 100644
@@ -1251,11 +1251,8 @@ static int wm8991_remove(struct snd_soc_codec *codec)
 
 static int wm8991_probe(struct snd_soc_codec *codec)
 {
-	struct wm8991_priv *wm8991;
 	int ret;
 
-	wm8991 = snd_soc_codec_get_drvdata(codec);
-
 	ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
 	if (ret < 0) {
 		dev_err(codec->dev, "Failed to set cache i/o: %d\n", ret);
Signature · 1 line
1.8.3.2
maintainer
#1 lore raw
Quoted 4 lines · Christian Engelmayer

Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)

Detected by Coverity: CID 1162831

This doesn't apply against current code, please check and resend and please also remember to CC maintainers on patches.

#2 lore raw

PATCH v2 1/1 ASoC: wm8991: Remove unused pointer in wm8991_probe()

Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)

Detected by Coverity: CID 1162831

---
v2: Resend after input by Mark Brown

* Added ASoC maintainer CC.
* Added driver maintainer CC.
* Verified that the patch applies against v3.14-rc1 as well as branch for-next in git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git.
* Fixed a typo in the summary phrase.

---
 sound/soc/codecs/wm8991.c | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/codecs/wm8991.c +0 -3
index dba0306..244eb09 100644
@@ -1251,11 +1251,8 @@ static int wm8991_remove(struct snd_soc_codec *codec)
 
 static int wm8991_probe(struct snd_soc_codec *codec)
 {
-	struct wm8991_priv *wm8991;
 	int ret;
 
-	wm8991 = snd_soc_codec_get_drvdata(codec);
-
 	ret = snd_soc_codec_set_cache_io(codec, 8, 16, SND_SOC_REGMAP);
 	if (ret < 0) {
 		dev_err(codec->dev, "Failed to set cache i/o: %d\n", ret);
Signature · 1 line
1.8.3.2
maintainer Applied
#3 lore raw

Re: [PATCH v2] ASoC: wm8991: Remove unused pointer in wm8991_probe()

Quoted 4 lines · Christian Engelmayer

Remove unused pointer 'wm8991' in function wm8991_probe(). The last user vanished with a86652e5 (ASoC: wm8991: Convert to direct regmap API usage)

Detected by Coverity: CID 1162831

Applied, thanks.