Skip to contentSkip to conversation

Second preview of imx-drm cleanup series

RFC PATCH In review Russell King - ARM Linux 8 participants 18 messages Feb 10, 2014 – Feb 18, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Second preview of imx-drm cleanup series

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

 arch/arm/boot/dts/imx51-babbage.dts        |  10 +-
 arch/arm/boot/dts/imx53-m53evk.dts         |   8 +-
 arch/arm/boot/dts/imx53-mba53.dts          |   6 +
 arch/arm/boot/dts/imx53-qsb.dts            |   8 +-
 arch/arm/boot/dts/imx6dl.dtsi              |   5 +
 arch/arm/boot/dts/imx6q-sabresd.dts        |   4 +
 arch/arm/boot/dts/imx6q.dtsi               |   5 +
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi     |   6 +
 arch/arm/boot/dts/imx6qdl.dtsi             |   9 +
 drivers/staging/imx-drm/Makefile           |   3 +-
 drivers/staging/imx-drm/imx-drm-core.c     | 831 ++++++++++-------------------
 drivers/staging/imx-drm/imx-drm.h          |  39 +-
 drivers/staging/imx-drm/imx-fb.c           |  47 --
 drivers/staging/imx-drm/imx-fbdev.c        |  74 ---
 drivers/staging/imx-drm/imx-hdmi.c         | 680 +++++++++--------------
 drivers/staging/imx-drm/imx-ldb.c          | 125 ++---
 drivers/staging/imx-drm/imx-tve.c          | 134 +++--
 drivers/staging/imx-drm/ipu-v3/ipu-di.c    | 317 +++++------
 drivers/staging/imx-drm/ipuv3-crtc.c       |  56 +-
 drivers/staging/imx-drm/parallel-display.c | 100 ++--
 20 files changed, 934 insertions(+), 1533 deletions(-)
#1 lore raw

RFC PATCH v2 13/35 imx-drm: add imx6 DT configuration for HDMI

Extracted from another patch by Fabio Estevam, this adds the DT configuration for HDMI output on the IMX6 SoCs

---
 arch/arm/boot/dts/imx6dl.dtsi  |  4 ++++
 arch/arm/boot/dts/imx6q.dtsi   |  4 ++++
 arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++
 3 files changed, 18 insertions(+)
arch/arm/boot/dts/imx6dl.dtsi +4 -0
index 9e8ae118fdd4..65e54b4529c5 100644
@@ -88,3 +88,7 @@
 		crtcs = <&ipu1 0>, <&ipu1 1>;
 	};
 };
+
+&hdmi {
+	crtcs = <&ipu1 0>, <&ipu1 1>;
+}
arch/arm/boot/dts/imx6q.dtsi +4 -0
index f024ef28b34b..d2467f532de6 100644
@@ -159,3 +159,7 @@
 		crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>;
 	};
 };
+
+&hdmi {
+	crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>;
+};
arch/arm/boot/dts/imx6qdl.dtsi +10 -0
index fb28b2ecb1db..400bbc624f25 100644
@@ -1368,6 +1368,16 @@
 				};
 			};
 
+			hdmi: hdmi at 0120000 {
+				compatible = "fsl,imx6q-hdmi";
+				reg = <0x00120000 0x9000>;
+				interrupts = <0 115 0x04>;
+				gpr = <&gpr>;
+				clocks = <&clks 123>, <&clks 124>;
+				clock-names = "iahb", "isfr";
+				status = "disabled";
+			};
+
 			dcic1: dcic at 020e4000 {
 				reg = <0x020e4000 0x4000>;
 				interrupts = <0 124 0x04>;
Signature · 1 line
1.8.3.1
#2 lore raw

RFC PATCH v2 14/35 imx-drm: update and fix imx6 DT descriptions for v3 HDMI driver

In reply to Russell King - ARM Linux
---
 arch/arm/boot/dts/imx6dl.dtsi  | 3 ++-
 arch/arm/boot/dts/imx6q.dtsi   | 1 +
 arch/arm/boot/dts/imx6qdl.dtsi | 1 -
 3 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6dl.dtsi +2 -1
index 65e54b4529c5..6dc397022214 100644
@@ -90,5 +90,6 @@
 };
 
 &hdmi {
+	compatible = "fsl,imx6dl-hdmi";
 	crtcs = <&ipu1 0>, <&ipu1 1>;
-}
+};
arch/arm/boot/dts/imx6q.dtsi +1 -0
index d2467f532de6..187fe33ba515 100644
@@ -161,5 +161,6 @@
 };
 
 &hdmi {
+	compatible = "fsl,imx6q-hdmi";
 	crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>;
 };
arch/arm/boot/dts/imx6qdl.dtsi +0 -1
index 400bbc624f25..930ebe0c2937 100644
@@ -1369,7 +1369,6 @@
 			};
 
 			hdmi: hdmi at 0120000 {
-				compatible = "fsl,imx6q-hdmi";
 				reg = <0x00120000 0x9000>;
 				interrupts = <0 115 0x04>;
 				gpr = <&gpr>;
Signature · 1 line
1.8.3.1
#3 lore raw

RFC PATCH v2 19/35 imx-drm: convert to componentised device support

In reply to Russell King - ARM Linux

Use the componentised device support for imx-drm. This requires all the sub-components and the master device to register with the component device support.

---
 arch/arm/boot/dts/imx51-babbage.dts        |  10 ++-
 arch/arm/boot/dts/imx53-m53evk.dts         |   8 ++-
 arch/arm/boot/dts/imx53-mba53.dts          |   6 ++
 arch/arm/boot/dts/imx53-qsb.dts            |   8 ++-
 arch/arm/boot/dts/imx6q-sabresd.dts        |   4 ++
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi     |   6 ++
 drivers/staging/imx-drm/imx-drm-core.c     | 105 +++++++++++++++++++++++------
 drivers/staging/imx-drm/imx-ldb.c          |  40 +++++++----
 drivers/staging/imx-drm/imx-tve.c          |  63 ++++++++++-------
 drivers/staging/imx-drm/ipuv3-crtc.c       |  46 +++++++++----
 drivers/staging/imx-drm/parallel-display.c |  30 +++++++--
 11 files changed, 246 insertions(+), 80 deletions(-)
arch/arm/boot/dts/imx51-babbage.dts +8 -2
index be1407cf5abd..6ff15a0eacb3 100644
@@ -21,7 +21,7 @@
 		reg = <0x90000000 0x20000000>;
 	};
 
-	display at di0 {
+	display0: display at di0 {
 		compatible = "fsl,imx-parallel-display";
 		crtcs = <&ipu 0>;
 		interface-pix-fmt = "rgb24";
@@ -43,7 +43,7 @@
 		};
 	};
 
-	display at di1 {
+	display1: display at di1 {
 		compatible = "fsl,imx-parallel-display";
 		crtcs = <&ipu 1>;
 		interface-pix-fmt = "rgb565";
@@ -81,6 +81,12 @@
 		};
 	};
 
+	imx-drm {
+		compatible = "fsl,imx-drm";
+		crtcs = <&ipu 0>, <&ipu 1>;
+		connectors = <&display0>, <&display1>;
+	};
+
 	sound {
 		compatible = "fsl,imx51-babbage-sgtl5000",
 			     "fsl,imx-audio-sgtl5000";
arch/arm/boot/dts/imx53-m53evk.dts +7 -1
index 7d304d02ed38..ee6107b6484c 100644
@@ -21,7 +21,7 @@
 	};
 
 	soc {
-		display at di1 {
+		display1: display at di1 {
 			compatible = "fsl,imx-parallel-display";
 			crtcs = <&ipu 1>;
 			interface-pix-fmt = "bgr666";
@@ -53,6 +53,12 @@
 		default-brightness-level = <6>;
 	};
 
+	imx-drm {
+		compatible = "fsl,imx-drm";
+		crtcs = <&ipu 1>;
+		connectors = <&display1>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
arch/arm/boot/dts/imx53-mba53.dts +6 -0
index a63090267941..9b6e76980a74 100644
@@ -43,6 +43,12 @@
 		status = "disabled";
 	};
 
+	imx-drm {
+		compatible = "fsl,imx-drm";
+		crtcs = <&ipu 1>;
+		connectors = <&disp1>, <&tve>;
+	};
+
 	reg_3p2v: 3p2v {
 		compatible = "regulator-fixed";
 		regulator-name = "3P2V";
arch/arm/boot/dts/imx53-qsb.dts +7 -1
index 91a5935a4aac..3cb4f7791a91 100644
@@ -21,7 +21,7 @@
 		reg = <0x70000000 0x40000000>;
 	};
 
-	display at di0 {
+	display0: display at di0 {
 		compatible = "fsl,imx-parallel-display";
 		crtcs = <&ipu 0>;
 		interface-pix-fmt = "rgb565";
@@ -72,6 +72,12 @@
 		};
 	};
 
+	imx-drm {
+		compatible = "fsl,imx-drm";
+		crtcs = <&ipu 0>;
+		connectors = <&display0>;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
arch/arm/boot/dts/imx6q-sabresd.dts +4 -0
index 9cbdfe7a0931..66f220a82e45 100644
@@ -20,6 +20,10 @@
 	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
 };
 
+&imx_drm {
+	crtcs = <&ipu1 0>, <&ipu1 1>, <&ipu2 0>, <&ipu2 1>;
+};
+
 &sata {
 	status = "okay";
 };
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +6 -0
index e75e11b36dff..dfca3e001398 100644
@@ -62,6 +62,12 @@
 		};
 	};
 
+	imx_drm: imx-drm {
+		compatible = "fsl,imx-drm";
+		crtcs = <&ipu1 0>, <&ipu1 1>;
+		connectors = <&ldb>;
+	};
+
 	sound {
 		compatible = "fsl,imx6q-sabresd-wm8962",
 			   "fsl,imx-audio-wm8962";
drivers/staging/imx-drm/imx-drm-core.c +85 -20

177 lines not on this page · raw message

drivers/staging/imx-drm/imx-ldb.c +28 -12
index dd29a4aad376..d00f93f3440d 100644
@@ -20,6 +20,7 @@
 
 #include <linux/module.h>
 #include <linux/clk.h>
+#include <linux/component.h>
 #include <drm/drmP.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_crtc_helper.h>
@@ -450,11 +451,11 @@ static const struct of_device_id imx_ldb_dt_ids[] = {
 };
 MODULE_DEVICE_TABLE(of, imx_ldb_dt_ids);
 
-static int imx_ldb_probe(struct platform_device *pdev)
+static int imx_ldb_bind(struct device *dev, struct device *master, void *data)
 {
-	struct device_node *np = pdev->dev.of_node;
+	struct device_node *np = dev->of_node;
 	const struct of_device_id *of_id =
-			of_match_device(imx_ldb_dt_ids, &pdev->dev);
+			of_match_device(imx_ldb_dt_ids, dev);
 	struct device_node *child;
 	const u8 *edidp;
 	struct imx_ldb *imx_ldb;
@@ -464,17 +465,17 @@ static int imx_ldb_probe(struct platform_device *pdev)
 	int ret;
 	int i;
 
-	imx_ldb = devm_kzalloc(&pdev->dev, sizeof(*imx_ldb), GFP_KERNEL);
+	imx_ldb = devm_kzalloc(dev, sizeof(*imx_ldb), GFP_KERNEL);
 	if (!imx_ldb)
 		return -ENOMEM;
 
 	imx_ldb->regmap = syscon_regmap_lookup_by_phandle(np, "gpr");
 	if (IS_ERR(imx_ldb->regmap)) {
-		dev_err(&pdev->dev, "failed to get parent regmap\n");
+		dev_err(dev, "failed to get parent regmap\n");
 		return PTR_ERR(imx_ldb->regmap);
 	}
 
-	imx_ldb->dev = &pdev->dev;
+	imx_ldb->dev = dev;
 
 	if (of_id)
 		imx_ldb->lvds_mux = of_id->data;
@@ -512,7 +513,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
 			return -EINVAL;
 
 		if (dual && i > 0) {
-			dev_warn(&pdev->dev, "dual-channel mode, ignoring second output\n");
+			dev_warn(dev, "dual-channel mode, ignoring second output\n");
 			continue;
 		}
 
@@ -551,7 +552,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
 			break;
 		case LVDS_BIT_MAP_JEIDA:
 			if (datawidth == 18) {
-				dev_err(&pdev->dev, "JEIDA standard only supported in 24 bit\n");
+				dev_err(dev, "JEIDA standard only supported in 24 bit\n");
 				return -EINVAL;
 			}
 			if (i == 0 || dual)
@@ -560,7 +561,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
 				imx_ldb->ldb_ctrl |= LDB_DATA_WIDTH_CH1_24 | LDB_BIT_MAP_CH1_JEIDA;
 			break;
 		default:
-			dev_err(&pdev->dev, "data mapping not specified or invalid\n");
+			dev_err(dev, "data mapping not specified or invalid\n");
 			return -EINVAL;
 		}
 
@@ -571,14 +572,15 @@ static int imx_ldb_probe(struct platform_device *pdev)
 		imx_drm_encoder_add_possible_crtcs(channel->imx_drm_encoder, child);
 	}
 
-	platform_set_drvdata(pdev, imx_ldb);
+	dev_set_drvdata(dev, imx_ldb);
 
 	return 0;
 }
 
-static int imx_ldb_remove(struct platform_device *pdev)
+static void imx_ldb_unbind(struct device *dev, struct device *master,
+	void *data)
 {
-	struct imx_ldb *imx_ldb = platform_get_drvdata(pdev);
+	struct imx_ldb *imx_ldb = dev_get_drvdata(dev);
 	int i;
 
 	for (i = 0; i < 2; i++) {
@@ -591,7 +593,21 @@ static int imx_ldb_remove(struct platform_device *pdev)
 		imx_drm_remove_connector(channel->imx_drm_connector);
 		imx_drm_remove_encoder(channel->imx_drm_encoder);
 	}
+}
 
+static const struct component_ops imx_ldb_ops = {
+	.bind	= imx_ldb_bind,
+	.unbind	= imx_ldb_unbind,
+};
+
+static int imx_ldb_probe(struct platform_device *pdev)
+{
+	return component_add(&pdev->dev, &imx_ldb_ops);
+}
+
+static int imx_ldb_remove(struct platform_device *pdev)
+{
+	component_del(&pdev->dev, &imx_ldb_ops);
 	return 0;
 }
 
drivers/staging/imx-drm/imx-tve.c +40 -23

169 lines not on this page · raw message

drivers/staging/imx-drm/ipuv3-crtc.c +32 -14

81 lines not on this page · raw message

drivers/staging/imx-drm/parallel-display.c +23 -7
index 12bcf4f58bdf..4019cae35ff9 100644
@@ -18,6 +18,7 @@
  * MA 02110-1301, USA.
  */
 
+#include <linux/component.h>
 #include <linux/module.h>
 #include <drm/drmP.h>
 #include <drm/drm_fb_helper.h>
@@ -192,15 +193,15 @@ static int imx_pd_register(struct imx_parallel_display *imxpd)
 	return 0;
 }
 
-static int imx_pd_probe(struct platform_device *pdev)
+static int imx_pd_bind(struct device *dev, struct device *master, void *data)
 {
-	struct device_node *np = pdev->dev.of_node;
+	struct device_node *np = dev->of_node;
 	const u8 *edidp;
 	struct imx_parallel_display *imxpd;
 	int ret;
 	const char *fmt;
 
-	imxpd = devm_kzalloc(&pdev->dev, sizeof(*imxpd), GFP_KERNEL);
+	imxpd = devm_kzalloc(dev, sizeof(*imxpd), GFP_KERNEL);
 	if (!imxpd)
 		return -ENOMEM;
 
@@ -218,7 +219,7 @@ static int imx_pd_probe(struct platform_device *pdev)
 			imxpd->interface_pix_fmt = V4L2_PIX_FMT_BGR666;
 	}
 
-	imxpd->dev = &pdev->dev;
+	imxpd->dev = dev;
 
 	ret = imx_pd_register(imxpd);
 	if (ret)
@@ -226,14 +227,15 @@ static int imx_pd_probe(struct platform_device *pdev)
 
 	ret = imx_drm_encoder_add_possible_crtcs(imxpd->imx_drm_encoder, np);
 
-	platform_set_drvdata(pdev, imxpd);
+	dev_set_drvdata(dev, imxpd);
 
 	return 0;
 }
 
-static int imx_pd_remove(struct platform_device *pdev)
+static void imx_pd_unbind(struct device *dev, struct device *master,
+	void *data)
 {
-	struct imx_parallel_display *imxpd = platform_get_drvdata(pdev);
+	struct imx_parallel_display *imxpd = dev_get_drvdata(dev);
 	struct drm_connector *connector = &imxpd->connector;
 	struct drm_encoder *encoder = &imxpd->encoder;
 
@@ -241,7 +243,21 @@ static int imx_pd_remove(struct platform_device *pdev)
 
 	imx_drm_remove_connector(imxpd->imx_drm_connector);
 	imx_drm_remove_encoder(imxpd->imx_drm_encoder);
+}
 
+static const struct component_ops imx_pd_ops = {
+	.bind	= imx_pd_bind,
+	.unbind	= imx_pd_unbind,
+};
+
+static int imx_pd_probe(struct platform_device *pdev)
+{
+	return component_add(&pdev->dev, &imx_pd_ops);
+}
+
+static int imx_pd_remove(struct platform_device *pdev)
+{
+	component_del(&pdev->dev, &imx_pd_ops);
 	return 0;
 }
 
Signature · 1 line
1.8.3.1
Acked-by on the v2 series
#4 lore raw
In reply to Russell King - ARM Linux

Am Montag, den 10.02.2014, 12:28 +0000 schrieb Russell King - ARM Linux:

Quoted 13 lines

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 7 lines

If I can have some acks for this, I'll start sending some of it to

Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

For the first 9 patches up to (including) "imx-drm: ipu-v3: more clocking fixes":

As you say, comments about the device tree bindings still apply. I'd prefer if the patches that currently use the crtcs property were reworked to use the v4l2 style device tree bindings before they hit mainline.

regards
Philipp

#5 lore raw
Quoted 22 lines · Philipp Zabel

Am Montag, den 10.02.2014, 12:28 +0000 schrieb Russell King - ARM Linux:

Quoted 13 lines

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 7 lines

If I can have some acks for this, I'll start sending some of it to

Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

Quoted 8 lines

For the first 9 patches up to (including) "imx-drm: ipu-v3: more clocking fixes":

As you say, comments about the device tree bindings still apply. I'd prefer if the patches that currently use the crtcs property were reworked to use the v4l2 style device tree bindings before they hit mainline.

I'm trying /not/ to do that much more work on this because there's other things that need my attention, like a complete rewrite of the SDHCI mess. I want to get the imx-drm stuff off my plate so I don't have to worry about it.

So, I'd really like _all_ these patches to go into mainline for v3.15 with the least rework possible so I can spend the next few months working on rewriting SDHCI.

What I don't want is carrying hundreds of patches across multiple kernel versions.

Now, mind explaining what "v4l2 style device tree bindings" means? I've no idea since I'm relatively new to DT.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
#6 lore raw
Quoted 2 lines · On Mon, 10 Feb 2014 15:18:21 +0000 Russell King - ARM Linux…

Now, mind explaining what "v4l2 style device tree bindings" means? I've no idea since I'm relatively new to DT.

Documentation/devicetree/bindings/media/video-interfaces.txt

For the Cubox, I have:

	tda998x: hdmi-encoder {
		compatible = "nxp,tda998x";
		...
		port {
			tda998x_0: endpoint@0 {
				remote-endpoint = <&lcd0_0>;
			};
		};
	};
&lcd0 {
	status = "okay";
	...
	port {
		lcd0_0: endpoint@0 {
			remote-endpoint = <&tda998x_0>;
		};
	};
};
Signature · 6 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
#7 lore raw
In reply to Russell King - ARM Linux

Hi Russell,

Quoted 32 lines · Russell King - ARM Linux
Quoted 22 lines · Philipp Zabel

Am Montag, den 10.02.2014, 12:28 +0000 schrieb Russell King - ARM Linux:

Quoted 13 lines

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 7 lines

If I can have some acks for this, I'll start sending some of it to

Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

Quoted 8 lines

For the first 9 patches up to (including) "imx-drm: ipu-v3: more clocking fixes":

As you say, comments about the device tree bindings still apply. I'd prefer if the patches that currently use the crtcs property were reworked to use the v4l2 style device tree bindings before they hit mainline.

Quoted 7 lines

I'm trying /not/ to do that much more work on this because there's other things that need my attention, like a complete rewrite of the SDHCI mess. I want to get the imx-drm stuff off my plate so I don't have to worry about it.

So, I'd really like _all_ these patches to go into mainline for v3.15

with the least rework possible so I can spend the next few months

Quoted 2 lines

working on rewriting SDHCI.

I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me synchronize somehow:

http://archive.arm.linux.org.uk/lurker/message/20140106.145159.a1d82ba9.en.html

I'll prepare an updated more complete version that should work on the CarrierOne.
Some feedback would be appreciated so I can improve them in time for your series' final submission.
The only thing I'd like to avoid is to have a stable v3.15 release with the old IPU specific bindings widely used due to the newly added HDMI support.

What I don't want is carrying hundreds of patches across multiple

Quoted 2 lines

kernel versions.

No complaints there.

Now, mind explaining what "v4l2 style device tree bindings" means? I've

Quoted 2 lines

no idea since I'm relatively new to DT.

Sorry, I was under the impression that people at the 2013 kernel summit drm/dt discussion were aware of those bindings and kind of agreed on (or at least did not oppose) them:

Documentation/devicetree/bindings/media/video-interfaces.txt

The first patch of the above patchset adds the i.MX6 specific connections for
the output paths according to this binding:
http://archive.arm.linux.org.uk/lurker/message/20140106.145200.24ed4a48.en.html

regards
Philipp

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#8 lore raw
Quoted 6 lines · Philipp Zabel

I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me synchronize somehow:

http://archive.arm.linux.org.uk/lurker/message/20140106.145159.a1d82ba9.en.html

I replied to your 2nd patch there...

I'm not happy ending up with a hard dependency between v4l2 code and code needed for the display side to work, especially when we can end up with imx-drm being the primary console display. I've outlined my thoughts about what I think needs to happen in the reply to patch 2.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
#9 lore raw

Hi Russell,

Am Montag, den 10.02.2014, 17:56 +0000 schrieb Russell King - ARM Linux:

Quoted 6 lines · Philipp Zabel
Quoted 5 lines

I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me synchronize somehow:

Quoted 8 lines
Quoted 1 line

http://archive.arm.linux.org.uk/lurker/message/20140106.145159.a1d82ba9.en.html

I replied to your 2nd patch there...

I'm not happy ending up with a hard dependency between v4l2 code and code needed for the display side to work, especially when we can end up with imx-drm being the primary console display. I've outlined my thoughts about what I think needs to happen in the reply to patch 2.

Thanks for your comments there. I have just updated and resent this series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary local copy of the v4l2_of functions, as long as the final resting place of the v4l2_of/of_graph functions seems to be a matter of discussion.

regards
Philipp

#10 lore raw
Quoted 4 lines · Philipp Zabel

Thanks for your comments there. I have just updated and resent this series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary local copy of the v4l2_of functions, as long as the final resting place of the v4l2_of/of_graph functions seems to be a matter of discussion.

Okay. My plans are to send more of these patches imminently to Greg. I've just pulled them forward to -rc3, which means that four have now dropped out of the series (as three have been recently merged and one due to that build fix for imx-hdmi.)

I'm just debating whether I need to send the whole series out again or not before doing that... any opinion?

Nothing's really changed in the patch set since the last time.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
#11 lore raw
In reply to Russell King - ARM Linux
Quoted 13 lines · Russell King - ARM Linux

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

So far, only the first few patches have been acked by one person. What about the remainder? There's been no comments on them either...

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
Acked-by
#12 lore raw

Am Mittwoch, den 12.02.2014, 09:56 +0000 schrieb Russell King - ARM Linux:

Quoted 14 lines · Russell King - ARM Linux
Quoted 13 lines

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 8 lines
Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

So far, only the first few patches have been acked by one person. What about the remainder? There's been no comments on them either...

With the understanding that I loathe the current DT bindings, which are not the fault of this series:

regards
Philipp

reviewer Reviewed-by on the v2 series
#13 lore raw
In reply to Russell King - ARM Linux
Quoted 13 lines · Russell King - ARM Linux

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

Series looks good:

Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.

Regards,

Fabio Estevam

#14 lore raw

2014-02-12 12:53 GMT+01:00 Fabio Estevam <[email protected]>:

Quoted 21 lines
Quoted 13 lines · Russell King - ARM Linux

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

Quoted 7 lines

Series looks good:

Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.

I am the only one who does not get the whole series?

Even here ony a handfull of patches are listed:
http://www.spinics.net/lists/arm-kernel/threads.html#306292

--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner

#15 lore raw
Quoted 26 lines · Christian Gmeiner

2014-02-12 12:53 GMT+01:00 Fabio Estevam <[email protected]>:

Quoted 25 lines
Quoted 13 lines · Russell King - ARM Linux

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

Series looks good:

Quoted 8 lines
Quoted 3 lines

Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.

I am the only one who does not get the whole series?

Even here ony a handfull of patches are listed:
http://www.spinics.net/lists/arm-kernel/threads.html#306292

You will find it all on the [email protected] archive.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
#16 lore raw

2014-02-12 13:45 GMT+01:00 Russell King - ARM Linux <[email protected]>:

Quoted 31 lines · Christian Gmeiner
Quoted 30 lines

2014-02-12 12:53 GMT+01:00 Fabio Estevam <[email protected]>:

Quoted 28 lines
Quoted 13 lines · Russell King - ARM Linux

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

Series looks good:

Patch 04/35 will not be needed in the final submission, as there is already a fix for the build issue in Greg's tree.

Quoted 7 lines
Quoted 4 lines

I am the only one who does not get the whole series?

Even here ony a handfull of patches are listed:
http://www.spinics.net/lists/arm-kernel/threads.html#306292

You will find it all on the devel at driverdev.osuosl.org archive.

thanks - thumbs up for this series.
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner

Acked-by on the v2 series
#17 lore raw
In reply to Russell King - ARM Linux
Quoted 13 lines · Russell King - ARM Linux

This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2.

Since the last round of patches were posted, the component support has been merged into mainline, and thus dropped from this series. Greg has taken the first three patches and merged them into his linux-next tree - however, I include them here for completness.

Most of the comments from last time still apply, and I'll look at incorporating some of the other patches that were posted in the coming week.

Quoted 5 lines

If I can have some acks for this, I'll start sending some of it to Greg - I'd like to at least get the five or six initial imx-hdmi patches to Greg and queued up for the next merge window sooner rather than later, preferably getting most of this ready for that window too.

For the series,