libtorrent: disable on ARC arch
PATCH 1/1 libtorrent: disable on ARC arch
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled.
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/
--- package/libtorrent/Config.in | 2 ++ 1 file changed, 2 insertions(+)
package/libtorrent/Config.in +2 -0
@@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix
Signature · 1 line
1.8.4.1
PATCH 1/1 libtorrent: disable on ARC arch
Hi Anton,
Quoted 16 lines · Anton Kolesov
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled.
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/Signed-off-by Anton Kolesov <[email protected]>--- package/libtorrent/Config.in | 2 ++ 1 file changed, 2 insertions(+)package/libtorrent/Config.in +0
-0
package/libtorrent/Config.in config BR2_PACKAGE_LIBTORRENT · line 9
Quoted 8 lines
package/libtorrent/Config.in +2
-0@@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix
This extra 'depends on' should be repeated on the comment about
toolchain options below, so that this comment is only visible when the
actual package is visible.
Have a look at http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options
(Note: you don't have to repeat the "# ARG GCC doesn't support ..." on the comment)
Best regards,
Thomas
PATCH 1/1 libtorrent: disable on ARC arch
Thomas, Anton,
Quoted 2 lines · Thomas De Schampheleire
package/libtorrent/Config.in config BR2_PACKAGE_LIBTORRENT · line 6
Quoted 2 lines
package/libtorrent/Config.in +2
-0+ # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc
Wrong indentation: one tab should be used.
Quoted 11 lines
Quoted 3 lines
select
BR2_PACKAGE_LIBSIGC
help
BitTorrent library written in C++ for *nixThis extra 'depends on' should be repeated on the comment about
toolchain options below, so that this comment is only visible when the
actual package is visible.
Have a look at http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options(Note: you don't have to repeat the "# ARG GCC doesn't support ..." on the comment)
And this additional dependency should be propagated to the reverse dependencies of libtorrent, i.e the rtorrent package.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 libtorrent: disable on ARC arch
Is that better?
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent.
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/
--- package/libtorrent/Config.in | 3 +++ package/rtorrent/Config.in | 1 + 2 files changed, 4 insertions(+)
package/libtorrent/Config.in +3 -0
@@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix
@@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT comment "libtorrent needs a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_arc
package/rtorrent/Config.in +1 -0
@@ -17,3 +17,4 @@ config BR2_PACKAGE_RTORRENT comment "rtorrent needs a toolchain w/ C++, threads, wchar" depends on BR2_USE_MMU depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS) + depends on !BR2_arc
Signature · 1 line
1.8.4.1
PATCH v2 1/1 libtorrent: disable on ARC arch
Dear Anton Kolesov,
Quoted 1 line · Anton Kolesov
Is that better?
This "Is that better?" shouldn't be part of the commit log. Instead, it should be below the "---" sign.
Quoted 37 lines
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent.
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/Signed-off-by Anton Kolesov <[email protected]>--- package/libtorrent/Config.in | 3 +++ package/rtorrent/Config.in | 1 + 2 files changed, 4 insertions(+)package/libtorrent/Config.in +3
-0@@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix@@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT comment "libtorrent needs a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_arcpackage/rtorrent/Config.in +0
-0
package/rtorrent/Config.in config BR2_PACKAGE_RTORRENT · line 20
Quoted 4 lines
package/rtorrent/Config.in +1
-0@@ -17,3 +17,4 @@ config BR2_PACKAGE_RTORRENT comment "rtorrent needs a toolchain w/ C++, threads, wchar" depends on BR2_USE_MMU depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS) + depends on !BR2_arc
It should also be propagated as a dependency of the BR2_PACKAGE_RTORRENT option itself, so that this package cannot be selected on ARC.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 libtorrent: disable on ARC arch
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent.
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/
--- package/libtorrent/Config.in | 3 +++ package/rtorrent/Config.in | 3 +++ 2 files changed, 6 insertions(+)
package/libtorrent/Config.in +3 -0
@@ -2,6 +2,8 @@ config BR2_PACKAGE_LIBTORRENT bool "libtorrent" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS + # ARC GCC doesn't support atomic instructions required by this lib + depends on !BR2_arc select BR2_PACKAGE_LIBSIGC help BitTorrent library written in C++ for *nix
@@ -10,3 +12,4 @@ config BR2_PACKAGE_LIBTORRENT comment "libtorrent needs a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_arc
package/rtorrent/Config.in +3 -0
@@ -4,6 +4,8 @@ config BR2_PACKAGE_RTORRENT depends on BR2_USE_WCHAR depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU # fork() + # ARC GCC doesn't support atomic instructions required by libtorrent + depends on !BR2_arc select BR2_PACKAGE_LIBCURL select BR2_PACKAGE_LIBSIGC select BR2_PACKAGE_LIBTORRENT
@@ -17,3 +19,4 @@ config BR2_PACKAGE_RTORRENT comment "rtorrent needs a toolchain w/ C++, threads, wchar" depends on BR2_USE_MMU depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS) + depends on !BR2_arc
Signature · 1 line
1.8.4.1
PATCH v3 1/1 libtorrent: disable on ARC arch
Dear Anton Kolesov,
Quoted 4 lines · Anton Kolesov
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent.
Quoted 8 lines
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/Signed-off-by Anton Kolesov <[email protected]>--- package/libtorrent/Config.in | 3 +++ package/rtorrent/Config.in | 3 +++ 2 files changed, 6 insertions(+)
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v3 1/1 libtorrent: disable on ARC arch
In reply to Anton KolesovQuoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Anton" == Anton Kolesov <[email protected]> writes:
Libtorrent has dependencies on atomic operations. However ARC GCC doesn't implement those at the moment so package should be disabled. Rtorrent depends on libtorrent.
This fixes:
http://autobuild.buildroot.net/results/51414e22c8ea47c38df20d864526a370c5a895d7/Signed-off-by Anton Kolesov <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard