nohz: ensure users are aware boot CPU is not NO_HZ_FULL
PATCH 1/1 nohz: ensure users are aware boot CPU is not NO_HZ_FULL
This bit of information is in the Kconfig help text:
Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
However neither the variable NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.
--- kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all (but boot) CPUs by default" depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option to
Signature · 1 line
1.8.5.2
Quoted 5 lines · Paul Gortmaker
This bit of information is in the
Kconfighelp text:Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
Quoted 7 lines
However neither the variable
NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.Cc Frederic Weisbecker <[email protected]>Cc "Paul E. McKenney" <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Quoted 20 lines
--- kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/time/Kconfig +1
-1@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all (but boot) CPUs by default" depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option toSignature · 1 line
1.8.5.2
Quoted 27 lines · Paul E. McKenney
Quoted 5 lines · Paul Gortmaker
This bit of information is in the
Kconfighelp text:Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
Quoted 7 lines
However neither the variable
NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.Cc Frederic Weisbecker <[email protected]>Cc "Paul E. McKenney" <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>Acked-by Paul E. McKenney <[email protected]>Quoted 11 lines
--- kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/time/Kconfig +0
-0@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice
Quoted 3 lines
kernel/time/Kconfig config NO_HZ_FULL · line 127
Quoted 3 lines
kernel/time/Kconfig +1
-1config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all (but boot) CPUs by default"
Looks good. Now we are all using "boot CPU" to refer to the CPU 0, but it may not sound that obvious to everyone.
How about: "Full dynticks system on all CPUs by default (expect CPU 0)" ?
Sure this is a temporary behaviour until I get the sysidle detection use patchset in shape, but indeed worth a big fat warning until we sort it out.
Thanks!
Quoted 7 lines
Quoted 6 lines
kernel/time/Kconfig +0
-0depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option toSignature · 1 line
1.8.5.2
Quoted 28 lines · Frederic Weisbecker
Quoted 27 lines · Paul E. McKenney
Quoted 5 lines · Paul Gortmaker
This bit of information is in the
Kconfighelp text:Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
Quoted 7 lines
However neither the variable
NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.Cc Frederic Weisbecker <[email protected]>Cc "Paul E. McKenney" <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>Acked-by Paul E. McKenney <[email protected]>Quoted 11 lines
--- kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/time/Kconfig +0
-0@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice
Quoted 8 lines
Quoted 3 lines
kernel/time/Kconfig config NO_HZ_FULL · line 127
Quoted 3 lines
kernel/time/Kconfig +1
-1config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all (but boot) CPUs by default"Looks good. Now we are all using "boot CPU" to refer to the CPU 0, but it may not sound that obvious to everyone.
How about: "Full dynticks system on all CPUs by default (expect CPU 0)" ?
Sure, I'll send a v2 with the above, but I'll s/expect/except/ :)
Thanks,
Paul.
--
Quoted 13 lines
Sure this is a temporary behaviour until I get the sysidle detection use patchset in shape, but indeed worth a big fat warning until we sort it out.
Thanks!
Quoted 7 lines
Quoted 6 lines
kernel/time/Kconfig +0
-0depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option toSignature · 1 line
1.8.5.2
PATCH v2 1/1 nohz: ensure users are aware boot CPU is not NO_HZ_FULL
This bit of information is in the Kconfig help text:
Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
However neither the variable NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.
---
v2: use "CPU 0" instead of "boot CPU".
kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all CPUs by default (except CPU 0)" depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option to
Signature · 1 line
1.8.5.2
Frederic Weisbecker
AppliedQuoted 11 lines · Paul Gortmaker
This bit of information is in the
Kconfighelp text:Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
However neither the variable
NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.Cc Frederic Weisbecker <[email protected]>Cc "Paul E. McKenney" <[email protected]>
Paul, I guess I can keep your ack on this 2nd version?
Quoted 1 line
Signed-off-by Paul Gortmaker <[email protected]>
Applied, thanks a lot!
Quoted 28 lines
---
v2: use "CPU 0" instead of "boot CPU".
kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/time/Kconfig +1
-1@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all CPUs by default (except CPU 0)" depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option toSignature · 7 lines
1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Quoted 6 lines · Frederic Weisbecker
Quoted 5 lines · Paul Gortmaker
This bit of information is in the
Kconfighelp text:Note the boot CPU will still be kept outside the range to handle the timekeeping duty.
Quoted 8 lines
Quoted 6 lines
However neither the variable
NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.Cc Frederic Weisbecker <[email protected]>Cc "Paul E. McKenney" <[email protected]>Paul, I guess I can keep your ack on this 2nd version?
Please do!
Thanx, Paul
Quoted 33 lines
Quoted 1 line
Signed-off-by Paul Gortmaker <[email protected]>Applied, thanks a lot!
Quoted 28 lines
---
v2: use "CPU 0" instead of "boot CPU".
kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/time/Kconfig +1
-1@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all CPUs by default (except CPU 0)" depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option toSignature · 7 lines
1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
tip-bot for Paul Gortmaker
merge botnohz: ensure users are aware boot CPU is not NO_HZ_FULL
Commit-ID: f96a34e27df19335155394a235ea3a096bc52a71 Gitweb: http://git.kernel.org/tip/f96a34e27df19335155394a235ea3a096bc52a71 Author: Paul Gortmaker <[email protected]> AuthorDate: Thu, 6 Feb 2014 13:36:21 -0500 Committer: Frederic Weisbecker <[email protected]> CommitDate: Fri, 14 Feb 2014 17:59:17 +0100
nohz: ensure users are aware boot CPU is not NO_HZ_FULL
This bit of information is in the Kconfig help text:
"Note the boot CPU will still be kept outside the range to handle the timekeeping duty."
However neither the variable NO_HZ_FULL_ALL, or the prompt convey this important detail, so lets add it to the prompt to make it more explicitly obvious to the average user.
--- kernel/time/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/Kconfig +1 -1
@@ -124,7 +124,7 @@ config NO_HZ_FULL endchoice config NO_HZ_FULL_ALL - bool "Full dynticks system on all CPUs by default" + bool "Full dynticks system on all CPUs by default (except CPU 0)" depends on NO_HZ_FULL help If the user doesn't pass the nohz_full boot option to