Skip to contentSkip to conversation

arch-at91: Gets ethernet working on at91sam9g20 board

PATCH New johnd 2 participants 2 messages Feb 11, 2014

Subsystems (2)
lore
Share & tools
lore

johnd

author
#0 lore raw

PATCH 1/1 arch-at91: Gets ethernet working on at91sam9g20 board

---
 arch/arm/include/asm/arch-at91/at91_rstc.h |    2 +-
 include/configs/at91sam9260ek.h            |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-at91/at91_rstc.h +1 -1
index a942342..59be96b 100644
@@ -25,7 +25,7 @@ typedef struct at91_rstc {
 
 #endif /* __ASSEMBLY__ */
 
-#define AT91_RSTC_KEY		0xA5000000
+#define AT91_RSTC_KEY		0xA5
 
 #define AT91_RSTC_CR_PROCRST	0x00000001
 #define AT91_RSTC_CR_PERRST	0x00000004
include/configs/at91sam9260ek.h +1 -0
index 73917b0..53bef35 100644
@@ -177,6 +177,7 @@
 #define CONFIG_SYS_NO_FLASH			1
 
 /* Ethernet */
+#define CONFIG_MACB_SEARCH_PHY
 #define CONFIG_MACB			1
 #define CONFIG_RMII			1
 #define CONFIG_NET_RETRY_COUNT		20
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 arch-at91: Gets ethernet working on at91sam9g20 board

Dear johnd,

SoB line missing!

Quoted 10 lines · johnd
---
 arch/arm/include/asm/arch-at91/at91_rstc.h |    2 +-
 include/configs/at91sam9260ek.h            |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-at91/at91_rstc.h +0 -0
index a942342..59be96b 100644

arch/arm/include/asm/arch-at91/at91_rstc.h typedef struct at91_rstc { · line 28

Quoted 5 lines
arch/arm/include/asm/arch-at91/at91_rstc.h +1 -1
@@ -25,7 +25,7 @@ typedef struct at91_rstc {
 
 #endif /* __ASSEMBLY__ */
 
-#define AT91_RSTC_KEY		0xA5000000
+#define AT91_RSTC_KEY		0xA5

This change is wrong, the RSTC key is located in RSTC_CR[31:24], your change will move the constant to RSTC_CR[8:0]!

include/configs/at91sam9260ek.h line 180

Quoted 12 lines
arch/arm/include/asm/arch-at91/at91_rstc.h +0 -0
 #define AT91_RSTC_CR_PROCRST	0x00000001
 #define AT91_RSTC_CR_PERRST	0x00000004
include/configs/at91sam9260ek.h +1 -0
index 73917b0..53bef35 100644
@@ -177,6 +177,7 @@
 #define CONFIG_SYS_NO_FLASH			1
 
 /* Ethernet */
+#define CONFIG_MACB_SEARCH_PHY

That change would be accepted, if the SoB line is available.

include/configs/at91sam9260ek.h line 183

Quoted 4 lines
include/configs/at91sam9260ek.h +0 -0
 #define CONFIG_MACB			1
 #define CONFIG_RMII			1
 #define CONFIG_NET_RETRY_COUNT		20

Best regards

Andreas Bie?mann