staging: android: binder: use whitespace consistently
PATCH 1/2 staging: android: binder: use whitespace consistently
Whitespace between #define keyword and BINDER_* constants are space in some point and tab in some point. Using space or tab is just writer's choice. But, let's use them more consistently.
--- drivers/staging/android/binder.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/android/binder.h +5 -5
@@ -85,11 +85,11 @@ struct binder_version {#define BINDER_CURRENT_PROTOCOL_VERSION 7#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read) -#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64) -#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32) -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32) -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32) -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32) +#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64) +#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32) +#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32) +#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32) +#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)#define BINDER_VERSION _IOWR('b', 9, struct binder_version)/*
Signature · 1 line
1.8.1.2
PATCH 2/2 staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY
Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from anywhere.
--- drivers/staging/android/binder.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/android/binder.h +3 -4
@@ -87,10 +87,9 @@ struct binder_version {#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32) -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32) -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32) -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32) -#define BINDER_VERSION _IOWR('b', 9, struct binder_version) +#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32) +#define BINDER_THREAD_EXIT _IOW('b', 7, __s32) +#define BINDER_VERSION _IOWR('b', 8, struct binder_version)/* * NOTE: Two special error codes you should check for when calling
Signature · 1 line
1.8.1.2
Greg KH
maintainerRe: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY
Quoted 14 lines · SeongJae Park
Remove constant
BINDER_SET_IDLE_PRIORITYbecause it is not used from anywhere.Signed-off-by SeongJae Park <[email protected]>--- drivers/staging/android/binder.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/staging/android/binder.h +0
-0
drivers/staging/android/binder.h struct binder_version { · line 92
Quoted 10 lines
drivers/staging/android/binder.h +3
-4@@ -87,10 +87,9 @@ struct binder_version {#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32) -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32) -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32) -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32) -#define BINDER_VERSION _IOWR('b', 9, struct binder_version) +#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32) +#define BINDER_THREAD_EXIT _IOW('b', 7, __s32) +#define BINDER_VERSION _IOWR('b', 8, struct binder_version)
And you just broke all userspace code that uses this interface :(
Please be more careful, and test your patches properly.
greg k-h
Re: [PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY
Quoted 28 lines · Greg KH
Quoted 14 lines · SeongJae Park
Remove constant
BINDER_SET_IDLE_PRIORITYbecause it is not used from anywhere.Signed-off-by SeongJae Park <[email protected]>--- drivers/staging/android/binder.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/staging/android/binder.h +0
-0drivers/staging/android/binder.h struct binder_version { · line 92
Quoted 10 lines
drivers/staging/android/binder.h +3
-4@@ -87,10 +87,9 @@ struct binder_version {#define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)#define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32) -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32) -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32) -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32) -#define BINDER_VERSION _IOWR('b', 9, struct binder_version) +#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32) +#define BINDER_THREAD_EXIT _IOW('b', 7, __s32) +#define BINDER_VERSION _IOWR('b', 8, struct binder_version)And you just broke all userspace code that uses this interface :(
Quoted 1 line
Please be more careful, and test your patches properly.
Definitely my fault... Sorry.
I will be more careful and will not do such mistake again.
Quoted 2 lines
greg k-h