arm64: add new support Samsung GH7 SoC and SSDK board
Subsystems (4)
cover arm64: add new support Samsung GH7 SoC and SSDK board
This adds support for Samsung ARMv8 core based GH7 SoC and its evaluation SSDK board.
[PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board [PATCH 2/3] arm64: Add Kconfig option for Samsung GH7 SoC family [PATCH 3/3] Documentation: DT: add new entry for Samsung GH7 SoC and SSDK board
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
--- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ 2 files changed, 134 insertions(+) create mode 100644 arch/arm64/boot/dts/samsung-gh7.dtsi create mode 100644 arch/arm64/boot/dts/samsung-ssdk-gh7.dts
arch/arm64/boot/dts/samsung-gh7.dtsi new file +108 -0
@@ -0,0 +1,108 @@ +/* + * SAMSUNG GH7 SoC device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +/dts-v1/; + +/memreserve/ 0x80000000 0x0C400000; + +/ { + model = "SAMSUNG GH7"; + compatible = "samsung,gh7"; + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + cpus { + #address-cells = <2>; + #size-cells = <0>; + + cpu@000 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x000>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu@001 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x001>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu@002 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x002>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu@003 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x003>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + }; + + gic: interrupt-controller@1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; + #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x0 0x1C001000 0 0x1000>, /* GIC Dist */ + <0x0 0x1C002000 0 0x1000>, /* GIC CPU */ + <0x0 0x1C004000 0 0x2000>, /* GIC VCPU Control */ + <0x0 0x1C006000 0 0x2000>; /* GIC VCPU */ + interrupts = <1 9 0xf04>; /* GIC Maintenence IRQ */ + }; + + timer { + compatible = "arm,armv8-timer"; + interrupts = <1 13 0xff01>, /* Secure Phys IRQ */ + <1 14 0xff01>, /* Non-secure Phys IRQ */ + <1 11 0xff01>, /* Virt IRQ */ + <1 10 0xff01>; /* Hyp IRQ */ + clock-frequency = <100000000>; + }; + + pmu { + compatible = "arm,armv8-pmuv3"; + interrupts = <0 294 8>, + <0 295 8>, + <0 296 8>, + <0 297 8>, + <0 298 8>, + <0 299 8>, + <0 300 8>, + <0 301 8>; + }; + + amba { + compatible = "arm,amba-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + serial@12c00000 { + compatible = "arm,pl011", "arm,primecell"; + reg = <0x12c00000 0x10000>; + interrupts = <418>; + }; + + serial@12c20000 { + compatible = "arm,pl011", "arm,primecell"; + reg = <0x12c20000 0x10000>; + interrupts = <420>; + }; + }; +};
arch/arm64/boot/dts/samsung-ssdk-gh7.dts new file +26 -0
@@ -0,0 +1,26 @@ +/* + * SAMSUNG SSDK-GH7 board device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +/dts-v1/; +#include "samsung-gh7.dtsi" + +/ { + model = "SAMSUNG SSDK-GH7 board based on GH7 SoC"; + compatible = "samsung,ssdk-gh7", "samsung,gh7"; + + chosen { + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x00000000 0x80000000 0 0x80000000>; + }; +};
Signature · 1 line
1.7.10.4
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Hi,
Besides what Mark Rutland already commented on:
arch/arm64/boot/dts/samsung-gh7.dtsi line 18
Quoted 3 lines · Kukjin Kim
arch/arm64/boot/dts/samsung-gh7.dtsi new file +3
-0+/ { + model = "SAMSUNG GH7"; + compatible = "samsung,gh7";
Model and compatible in the dtsi should probably always be overridden by a dts that includes it, so there's little use in having it here.
arch/arm64/boot/dts/samsung-gh7.dtsi line 30
Quoted 12 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +12
-0+ interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + cpus { + #address-cells = <2>; + #size-cells = <0>; + + cpu at 000 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x000>;
No need to zero-pad cpu numbers in unit address or reg.
Quoted 18 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +18
-0+ enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu at 001 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x001>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu at 002 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x002>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu at 003 {
arch/arm64/boot/dts/samsung-gh7.dtsi line 58
Quoted 10 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +10
-0+ device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x003>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + }; + + gic: interrupt-controller at 1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
Quoted 89 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +50
-0+ #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x0 0x1C001000 0 0x1000>, /* GIC Dist */ + <0x0 0x1C002000 0 0x1000>, /* GIC CPU */ + <0x0 0x1C004000 0 0x2000>, /* GIC VCPU Control */ + <0x0 0x1C006000 0 0x2000>; /* GIC VCPU */ + interrupts = <1 9 0xf04>; /* GIC Maintenence IRQ */ + }; + + timer { + compatible = "arm,armv8-timer"; + interrupts = <1 13 0xff01>, /* Secure Phys IRQ */ + <1 14 0xff01>, /* Non-secure Phys IRQ */ + <1 11 0xff01>, /* Virt IRQ */ + <1 10 0xff01>; /* Hyp IRQ */ + clock-frequency = <100000000>; + }; + + pmu { + compatible = "arm,armv8-pmuv3"; + interrupts = <0 294 8>, + <0 295 8>, + <0 296 8>, + <0 297 8>, + <0 298 8>, + <0 299 8>, + <0 300 8>, + <0 301 8>; + }; + + amba { + compatible = "arm,amba-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + serial at 12c00000 { + compatible = "arm,pl011", "arm,primecell"; + reg = <0x12c00000 0x10000>; + interrupts = <418>; + }; + + serial at 12c20000 { + compatible = "arm,pl011", "arm,primecell"; + reg = <0x12c20000 0x10000>; + interrupts = <420>; + }; + }; +};arch/arm64/boot/dts/samsung-ssdk-gh7.dts new file +26
-1@@ -0,0 +1,26 @@ +/* + * SAMSUNG SSDK-GH7 board device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +/dts-v1/; +#include "samsung-gh7.dtsi" + +/ { + model = "SAMSUNG SSDK-GH7 board based on GH7 SoC"; + compatible = "samsung,ssdk-gh7", "samsung,gh7"; + + chosen { + }; + + memory at 80000000 { + device_type = "memory"; + reg = <0x00000000 0x80000000 0 0x80000000>; + }; +}; --1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 56 lines · Olof Johansson
Hi,
Besides what Mark Rutland already commented on:
arch/arm64/boot/dts/samsung-gh7.dtsi line 18
Quoted 3 lines · Kukjin Kim
arch/arm64/boot/dts/samsung-gh7.dtsi new file +3
-0+/ { + model = "SAMSUNG GH7"; + compatible = "samsung,gh7";Model and compatible in the dtsi should probably always be overridden by a dts that includes it, so there's little use in having it here.
arch/arm64/boot/dts/samsung-gh7.dtsi line 30
Quoted 12 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +12
-0+ interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + cpus { + #address-cells = <2>; + #size-cells = <0>; + + cpu at 000 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x000>;No need to zero-pad cpu numbers in unit address or reg.
Quoted 18 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +18
-0+ enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu at 001 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x001>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu at 002 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x002>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + cpu at 003 {arch/arm64/boot/dts/samsung-gh7.dtsi line 58
Quoted 10 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +10
-0+ device_type = "cpu"; + compatible = "arm,armv8"; + reg = <0x0 0x003>; + enable-method = "spin-table"; + cpu-release-addr = <0x0 0x8000fff8>; + }; + }; + + gic: interrupt-controller at 1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
Quoted 2 lines
This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
"arm,cortex-a9-gic" is definitely wrong (the A9 GIC doesn't have the virt extensions). This binding matches what the A15 GIC has, so "arm,cortex-a15-gic" is probably fine. Main issue here is that the GICv2 driver has no compatible string for anything else.
Should we define something more generic (like "arm,gic-v2")? Or carry on adding more compatible strings?
M.
Quoted 9 lines
Quoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +9
-0+ #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x0 0x1C001000 0 0x1000>, /* GIC Dist */ + <0x0 0x1C002000 0 0x1000>, /* GIC CPU */ + <0x0 0x1C004000 0 0x2000>, /* GIC VCPU Control */ + <0x0 0x1C006000 0 0x2000>; /* GIC VCPU */ + interrupts = <1 9 0xf04>; /* GIC Maintenence IRQ */ + };
Signature · 1 line
Jazz is not dead. It just smells funny...
Mark Rutland
reviewerPATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 6 lines
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ gic: interrupt-controller at 1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
Quoted 7 lines
"arm,cortex-a9-gic" is definitely wrong (the A9 GIC doesn't have the virt extensions). This binding matches what the A15 GIC has, so "arm,cortex-a15-gic" is probably fine. Main issue here is that the GICv2 driver has no compatible string for anything else.
Should we define something more generic (like "arm,gic-v2")? Or carry on adding more compatible strings?
It's been proposed repeatedly, and it probably makes sense to add the generic versions to the driver, and allow for more specific ones in the binding which DTs can use. That way we don't get an explosion of strings in the driver, but if we need to handle any particular GIC specially in future we can do so.
I guess for Linux we'd want to add "arm,gic-v1" and "arm,gic-v2" to the driver. We could just add "arm,gic-v1" and expect it later in the compatible list if v2 is a strict superset of v1; I think it is but I'm not a GIC expert.
Thanks,
Mark.
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 20 lines · Mark Rutland
Quoted 6 lines
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ gic: interrupt-controller at 1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
Quoted 7 lines
"arm,cortex-a9-gic" is definitely wrong (the A9 GIC doesn't have the virt extensions). This binding matches what the A15 GIC has, so "arm,cortex-a15-gic" is probably fine. Main issue here is that the GICv2 driver has no compatible string for anything else.
Should we define something more generic (like "arm,gic-v2")? Or carry on adding more compatible strings?
It's been proposed repeatedly, and it probably makes sense to add the generic versions to the driver, and allow for more specific ones in the binding which DTs can use. That way we don't get an explosion of strings in the driver, but if we need to handle any particular GIC specially in future we can do so.
Quoted 4 lines
I guess for Linux we'd want to add "arm,gic-v1" and "arm,gic-v2" to the driver. We could just add "arm,gic-v1" and expect it later in the compatible list if v2 is a strict superset of v1; I think it is but I'm not a GIC expert.
Sounds good to me.
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 21 lines · Marc Zyngier
Quoted 20 lines · Mark Rutland
Quoted 6 lines
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ gic: interrupt-controller at 1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
Quoted 7 lines
"arm,cortex-a9-gic" is definitely wrong (the A9 GIC doesn't have the virt extensions). This binding matches what the A15 GIC has, so "arm,cortex-a15-gic" is probably fine. Main issue here is that the GICv2 driver has no compatible string for anything else.
Should we define something more generic (like "arm,gic-v2")? Or carry on adding more compatible strings?
It's been proposed repeatedly, and it probably makes sense to add the generic versions to the driver, and allow for more specific ones in the binding which DTs can use. That way we don't get an explosion of strings in the driver, but if we need to handle any particular GIC specially in future we can do so.
Quoted 7 lines
Quoted 4 lines
I guess for Linux we'd want to add "arm,gic-v1" and "arm,gic-v2" to the driver. We could just add "arm,gic-v1" and expect it later in the compatible list if v2 is a strict superset of v1; I think it is but I'm not a GIC expert.
Sounds good to me.
OK, so did you guys agree to use version for gic? I'm fine to use gic-v2.
And so who will take changing for others in mainline? ;-)
- Kukjin
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
In reply to Olof JohanssonQuoted 2 lines · Olof Johansson
Hi,
Hi Olof,
Quoted 2 lines
Besides what Mark Rutland already commented on:
OK, thanks :-)
Quoted 8 lines · Kukjin Kim
arch/arm64/boot/dts/samsung-gh7.dtsi line 18
Quoted 3 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +3
-0+/ { + model = "SAMSUNG GH7"; + compatible = "samsung,gh7";Model and compatible in the dtsi should probably always be overridden by a dts that includes it, so there's little use in having it here.
OK, makes sense.
Quoted 6 lines
Quoted 6 lines
(quoted diff) +6
-0+ interrupt-parent =<&gic>; + #address-cells =<2>; + #size-cells =<2>; + + cpus { + #address-cells =<2>;
Quoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ #size-cells =<0>; + + cpu at 000 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x000>;No need to zero-pad cpu numbers in unit address or reg.
Yes it's correct without any consideration, but I'm going to add more cpus next time and they should be separated from this. So I used.
Quoted 29 lines
Quoted 18 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +18
-0+ enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + cpu at 001 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x001>; + enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + cpu at 002 { + device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x002>; + enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + cpu at 003 {arch/arm64/boot/dts/samsung-gh7.dtsi line 58
Quoted 10 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +10
-0+ device_type = "cpu"; + compatible = "arm,armv8"; + reg =<0x0 0x003>; + enable-method = "spin-table"; + cpu-release-addr =<0x0 0x8000fff8>; + }; + }; + + gic: interrupt-controller at 1C000000 { + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
Quoted 3 lines
This looks incorrect -- you should at the very least have a more specific one than a15-gic? Marc?
OK, you're right. And I replied on other e-mail.
Thanks,
Kukjin
Mark Rutland
reviewerPATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
In reply to Kukjin KimQuoted 20 lines · Kukjin Kim
Signed-off-by Kukjin Kim <[email protected]>Reviewed-by Thomas Abraham <[email protected]>Cc Catalin Marinas <[email protected]>--- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ 2 files changed, 134 insertions(+) create mode 100644 arch/arm64/boot/dts/samsung-gh7.dtsi create mode 100644 arch/arm64/boot/dts/samsung-ssdk-gh7.dtsarch/arm64/boot/dts/samsung-gh7.dtsi new file +4
-0@@ -0,0 +1,108 @@ +/* + * SAMSUNG GH7 SoC device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
arch/arm64/boot/dts/samsung-gh7.dtsi line 14
Quoted 10 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +10
-0+ * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +/dts-v1/; + +/memreserve/ 0x80000000 0x0C400000;
That looks _very_ large. What is this for?
[...]
arch/arm64/boot/dts/samsung-gh7.dtsi line 75
Quoted 7 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +7
-0+ timer { + compatible = "arm,armv8-timer"; + interrupts = <1 13 0xff01>, /* Secure Phys IRQ */ + <1 14 0xff01>, /* Non-secure Phys IRQ */ + <1 11 0xff01>, /* Virt IRQ */ + <1 10 0xff01>; /* Hyp IRQ */ + clock-frequency = <100000000>;
Please, get your bootloader to set CNTFREQ. The clock frequency property for the timer node is a horrible hack for buggy firmware.
[...]
Quoted 7 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +7
-0+ amba { + compatible = "arm,amba-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + serial at 12c00000 {
arch/arm64/boot/dts/samsung-gh7.dtsi line 106
Quoted 10 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +10
-0+ compatible = "arm,pl011", "arm,primecell"; + reg = <0x12c00000 0x10000>; + interrupts = <418>; + }; + + serial at 12c20000 { + compatible = "arm,pl011", "arm,primecell"; + reg = <0x12c20000 0x10000>; + interrupts = <420>; + };
Don't these need clocks?
[...]
arch/arm64/boot/dts/samsung-gh7.dtsi line 41
Quoted 3 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +3
-0+ memory at 80000000 { + device_type = "memory"; + reg = <0x00000000 0x80000000 0 0x80000000>;
Minor nit, but it would be nice for the 0 values to be consistently padded.
Thanks,
Mark.
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 25 lines · Mark Rutland
Quoted 24 lines · Kukjin Kim
Signed-off-by Kukjin Kim<[email protected]>Reviewed-by Thomas Abraham<[email protected]>Cc Catalin Marinas<[email protected]>--- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ 2 files changed, 134 insertions(+)create mode 100644
arch/arm64/boot/dts/samsung-gh7.dtsicreate mode 100644arch/arm64/boot/dts/samsung-ssdk-gh7.dtsarch/arm64/boot/dts/samsung-gh7.dtsi new file +8
-0@@ -0,0 +1,108 @@ +/* + * SAMSUNG GH7 SoC device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as
Quoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi line 14
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ * published by the Free Software Foundation. +*/ + +/dts-v1/; + +/memreserve/ 0x80000000 0x0C400000;That looks _very_ large. What is this for?
Yes, I know but we need to reserve that for EL3 monitor, UEFI services, secure, hypervisor and scan chanin...
Quoted 13 lines
[...]
arch/arm64/boot/dts/samsung-gh7.dtsi
Quoted 7 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +7
-0+ timer { + compatible = "arm,armv8-timer"; + interrupts =<1 13 0xff01>, /* Secure Phys IRQ */ + <1 14 0xff01>, /* Non-secure Phys IRQ */ + <1 11 0xff01>, /* Virt IRQ */ + <1 10 0xff01>; /* Hyp IRQ */ + clock-frequency =<100000000>;Please, get your bootloader to set CNTFREQ. The clock frequency property for the timer node is a horrible hack for buggy firmware.
You're right. OK.
Quoted 13 lines
[...]
Quoted 11 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +11
-0+ amba { + compatible = "arm,amba-bus"; + #address-cells =<1>; + #size-cells =<1>; + ranges; + + serial at 12c00000 { + compatible = "arm,pl011", "arm,primecell"; + reg =<0x12c00000 0x10000>; + interrupts =<418>; + };
Quoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi line 100
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ + serial at 12c20000 { + compatible = "arm,pl011", "arm,primecell"; + reg =<0x12c20000 0x10000>; + interrupts =<420>; + };Don't these need clocks?
We don't need and the clocks will be handled by bootloader...
Quoted 8 lines
[...]
arch/arm64/boot/dts/samsung-gh7.dtsi
Quoted 3 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +3
-0+ memory at 80000000 { + device_type = "memory"; + reg =<0x00000000 0x80000000 0 0x80000000>;Minor nit, but it would be nice for the 0 values to be consistently padded.
OK.
Thanks,
Kukjin
Mark Rutland
reviewerPATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 35 lines · Kukjin Kim
Quoted 25 lines · Mark Rutland
Quoted 24 lines · Kukjin Kim
Signed-off-by Kukjin Kim<[email protected]>Reviewed-by Thomas Abraham<[email protected]>Cc Catalin Marinas<[email protected]>--- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ 2 files changed, 134 insertions(+)create mode 100644
arch/arm64/boot/dts/samsung-gh7.dtsicreate mode 100644arch/arm64/boot/dts/samsung-ssdk-gh7.dtsarch/arm64/boot/dts/samsung-gh7.dtsi new file +8
-0@@ -0,0 +1,108 @@ +/* + * SAMSUNG GH7 SoC device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 asQuoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi line 14
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ * published by the Free Software Foundation. +*/ + +/dts-v1/; + +/memreserve/ 0x80000000 0x0C400000;That looks _very_ large. What is this for?
Quoted 2 lines
Yes, I know but we need to reserve that for EL3 monitor, UEFI services, secure, hypervisor and scan chanin...
OK. How much of that memory does the kernel need to know about then?
Surely the kernel shouldn't be able to map the EL3 monitor or hypervisor at all?
What address is the kernel getting loaded at if everything up to 0x8C400000 isn't usable?
[...]
Quoted 23 lines
Quoted 14 lines
[...]
Quoted 11 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +11
-0+ amba { + compatible = "arm,amba-bus"; + #address-cells =<1>; + #size-cells =<1>; + ranges; + + serial at 12c00000 { + compatible = "arm,pl011", "arm,primecell"; + reg =<0x12c00000 0x10000>; + interrupts =<418>; + };Quoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi line 100
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ + serial at 12c20000 { + compatible = "arm,pl011", "arm,primecell"; + reg =<0x12c20000 0x10000>; + interrupts =<420>; + };Don't these need clocks?
Quoted 1 line
We don't need and the clocks will be handled by bootloader...
While that might be sufficient for the device to function, Linux doesn't know that from this DT, and as far as I can see the device can't possibly probe, as no clocks are provided through platform data:
of_platform_bus_create will call of_amba_device_create for anyting compatible with "arm,primecell". This in turn will call amba_device_add, which will call amba_get_enable_pclk. Then clk_get(&pcdev->dev, "apb_pclk") should fail, amba_device_add should fail, and of_platform_bus_create will stop trying to probe the node. of_platform_populate will carry on probing other nodes.
Surely the pl011 nodes at least need "apb_pclk"?
Cheers,
Mark.
PATCH 1/3 arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board
Quoted 78 lines · Mark Rutland
Quoted 35 lines · Kukjin Kim
Quoted 25 lines · Mark Rutland
Quoted 24 lines · Kukjin Kim
Signed-off-by Kukjin Kim<[email protected]>Reviewed-by Thomas Abraham<[email protected]>Cc Catalin Marinas<[email protected]>--- arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ 2 files changed, 134 insertions(+)create mode 100644
arch/arm64/boot/dts/samsung-gh7.dtsicreate mode 100644arch/arm64/boot/dts/samsung-ssdk-gh7.dtsarch/arm64/boot/dts/samsung-gh7.dtsi new file +8
-0@@ -0,0 +1,108 @@ +/* + * SAMSUNG GH7 SoC device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 asQuoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi line 14
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ * published by the Free Software Foundation. +*/ + +/dts-v1/; + +/memreserve/ 0x80000000 0x0C400000;That looks _very_ large. What is this for?
Quoted 2 lines
Yes, I know but we need to reserve that for EL3 monitor, UEFI services, secure, hypervisor and scan chanin...
OK. How much of that memory does the kernel need to know about then?
Surely the kernel shouldn't be able to map the EL3 monitor or hypervisor at all?
What address is the kernel getting loaded at if everything up to
0x8C400000isn't usable?[...]
Quoted 23 lines
Quoted 14 lines
[...]
Quoted 11 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +11
-0+ amba { + compatible = "arm,amba-bus"; + #address-cells =<1>; + #size-cells =<1>; + ranges; + + serial at 12c00000 { + compatible = "arm,pl011", "arm,primecell"; + reg =<0x12c00000 0x10000>; + interrupts =<418>; + };Quoted 9 lines
arch/arm64/boot/dts/samsung-gh7.dtsi line 100
Quoted 6 lines
arch/arm64/boot/dts/samsung-gh7.dtsi new file +6
-0+ + serial at 12c20000 { + compatible = "arm,pl011", "arm,primecell"; + reg =<0x12c20000 0x10000>; + interrupts =<420>; + };Don't these need clocks?
Quoted 1 line
We don't need and the clocks will be handled by bootloader...
While that might be sufficient for the device to function, Linux doesn't know that from this DT, and as far as I can see the device can't possibly probe, as no clocks are provided through platform data:
Quoted 9 lines
of_platform_bus_createwill callof_amba_device_createfor anyting compatible with "arm,primecell". This in turn will callamba_device_add, which will callamba_get_enable_pclk. Thenclk_get(&pcdev->dev, "apb_pclk")should fail,amba_device_addshould fail, andof_platform_bus_createwill stop trying to probe the node.of_platform_populatewill carry on probing other nodes.Surely the pl011 nodes at least need "
apb_pclk"?
You're right. We should make a dummy clock for pl011, proper clocks will be added in next version.
Thanks,
Kukjin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Kukjin KimThis patch adds support for Samsung GH7 SoC in arm64/Kconfig.
--- arch/arm64/Kconfig | 5 +++++ arch/arm64/boot/dts/Makefile | 1 + 2 files changed, 6 insertions(+)
arch/arm64/Kconfig +5 -0
@@ -111,6 +111,11 @@ source "kernel/Kconfig.freezer" menu "Platform selection" +config ARCH_GH7 + bool "Samsung ARMv8 GH7 SoC" + help + This enables support for Samsung GH7 SoC + config ARCH_VEXPRESS bool "ARMv8 software model (Versatile Express)" select ARCH_REQUIRE_GPIOLIB
arch/arm64/boot/dts/Makefile +1 -0
@@ -1,3 +1,4 @@ +dtb-$(CONFIG_ARCH_GH7) += samsung-ssdk-gh7.dtb dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb
Signature · 1 line
1.7.10.4
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>
The overhead of building one more device tree isn't very large, and I don't see any other need to have a Kconfig entry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.
-Olof
Catalin Marinas
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 10 lines · Olof Johansson
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>The overhead of building one more device tree isn't very large, and I don't see any other need to have a
Kconfigentry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.
For arm64, I thought of getting rid of ARCH_* Kconfig entries entirely, only that I haven't heard any strong opinion either way (in which case I'll do it, with a risk of single Image getting bigger and bigger and people needing smaller Image can trim their .config).
Signature · 1 line
Catalin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 12 lines · Catalin Marinas
Quoted 10 lines · Olof Johansson
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>The overhead of building one more device tree isn't very large, and I don't see any other need to have a
Kconfigentry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.
Quoted 4 lines
For arm64, I thought of getting rid of ARCH_*
Kconfigentries entirely, only that I haven't heard any strong opinion either way (in which case I'll do it, with a risk of single Image getting bigger and bigger and people needing smaller Image can trim their .config).
One reason to keep around ARCH_* is for drivers shared between arm and arm64 that depend on it.
- k
Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Catalin Marinas
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 14 lines · Kumar Gala
Quoted 12 lines · Catalin Marinas
Quoted 10 lines · Olof Johansson
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>The overhead of building one more device tree isn't very large, and I don't see any other need to have a
Kconfigentry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.
Quoted 6 lines
Quoted 4 lines
For arm64, I thought of getting rid of ARCH_*
Kconfigentries entirely, only that I haven't heard any strong opinion either way (in which case I'll do it, with a risk of single Image getting bigger and bigger and people needing smaller Image can trim their .config).One reason to keep around ARCH_* is for drivers shared between arm and arm64 that depend on it.
We already converted some of them (those depending on ARCH_VEXPRESS) to just depend on ARM64. Ideally, at some point I’d like to see them as defaulting to modules but I don’t think we are there yet (we had some discussions at the last KS, I’m not sure anyone started looking into this).--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 20 lines · Catalin Marinas
Quoted 19 lines · Kumar Gala
Quoted 16 lines · Catalin Marinas
Quoted 10 lines · Olof Johansson
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>The overhead of building one more device tree isn't very large, and I don't see any other need to have a
Kconfigentry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.For arm64, I thought of getting rid of ARCH_*
Kconfigentries entirely, only that I haven't heard any strong opinion either way (in which case I'll do it, with a risk of single Image getting bigger and bigger and people needing smaller Image can trim their .config).
Quoted 7 lines
Quoted 1 line
One reason to keep around ARCH_* is for drivers shared between arm and arm64 that depend on it.
We already converted some of them (those depending on
ARCH_VEXPRESS) to just depend on ARM64. Ideally, at some point I?d like to see them as defaulting to modules but I don?t think we are there yet (we had some discussions at the last KS, I?m not sure anyone started looking into this).
I?m torn about this, I think for something like VEXPRESS it makes sense, however I think its reasonable to still have an config symbol for a full SoC family or something of that nature.
- k
Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Arnd Bergmann
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 10 lines · On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Quoted 8 lines · Catalin Marinas
Quoted 1 line · Kumar Gala
One reason to keep around ARCH_* is for drivers shared between arm and arm64 that depend on it.
We already converted some of them (those depending on
ARCH_VEXPRESS) to just depend on ARM64. Ideally, at some point I?d like to see them as defaulting to modules but I don?t think we are there yet (we had some discussions at the last KS, I?m not sure anyone started looking into this).
Quoted 3 lines
I?m torn about this, I think for something like VEXPRESS it makes sense, however I think its reasonable to still have an config symbol for a full SoC family or something of that nature.
I think for SBSA compliant systems, we should be able to live with a generic ARCH_SBSA Kconfig symbol. For more irregular embedded platforms, we may need something more specific.
Arnd
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 11 lines · Arnd Bergmann
Quoted 10 lines · On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Quoted 8 lines · Catalin Marinas
Quoted 1 line · Kumar Gala
One reason to keep around ARCH_* is for drivers shared between arm and arm64 that depend on it.
We already converted some of them (those depending on
ARCH_VEXPRESS) to just depend on ARM64. Ideally, at some point I?d like to see them as defaulting to modules but I don?t think we are there yet (we had some discussions at the last KS, I?m not sure anyone started looking into this).
Quoted 8 lines
Quoted 3 lines
I?m torn about this, I think for something like VEXPRESS it makes sense, however I think its reasonable to still have an config symbol for a full SoC family or something of that nature.
I think for SBSA compliant systems, we should be able to live with a generic
ARCH_SBSAKconfigsymbol. For more irregular embedded platforms, we may need something more specific.
Basically, I agreed with Arnd's suggestion to use ARCH_SBSA. Or we need to define level in Kconfig like ARCH_SBSA_L1 for level1. BTW, how about compliant with SBSA Level1 and having some specific features?
- Kukjin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 25 lines · Kukjin Kim
Quoted 24 lines · Arnd Bergmann
Quoted 20 lines · On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Quoted 7 lines · Catalin Marinas
Quoted 3 lines · Kumar Gala
One reason to keep around ARCH_* is for drivers shared between arm and arm64 that depend on it.
Quoted 5 lines
We already converted some of them (those depending on
ARCH_VEXPRESS) to just depend on ARM64. Ideally, at some point I'd like to see them as defaulting to modules but I don't think we are there yet (we had some discussions at the last KS, I'm not sure anyone started looking into this).I'm torn about this, I think for something like VEXPRESS it makes sense, however I think its reasonable to still have an config symbol for a full SoC family or something of that nature.
Quoted 7 lines
Quoted 4 lines
I think for SBSA compliant systems, we should be able to live with a generic
ARCH_SBSAKconfigsymbol. For more irregular embedded platforms, we may need something more specific.Basically, I agreed with Arnd's suggestion to use
ARCH_SBSA. Or we need to define level inKconfiglikeARCH_SBSA_L1for level1. BTW, how about compliant with SBSA Level1 and having some specific features?
(It's a little hard to answer since nobody can download the doc and then talk about it.)
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
x86 doesn't need config options for each generation of their platform, and neither should ARM64. Sure, there might be drivers that don't make sense to enable on some platforms, but that's what defconfigs (or distro configs), and modules are for -- the modules won't load unless the hardware is there.
As long as we're not talking about massive amounts of code that is part of the base platform, separating out per version again doesn't make sense -- just enable for SBSA and it'll support Level 1 through whatever. If the kernel size becomes a concern we can revisit, but let's not start out that way.
-Olof
Arnd Bergmann
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 6 lines · Olof Johansson
Quoted 5 lines · Kukjin Kim
Quoted 1 line · Arnd Bergmann
On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Basically, I agreed with Arnd's suggestion to use
ARCH_SBSA. Or we need to define level inKconfiglikeARCH_SBSA_L1for level1. BTW, how about compliant with SBSA Level1 and having some specific features?
My feeling is that we don't need to use the levels for Kconfig, although we might want to use them DT compatible strings, even if it ends up looking a little funny when you do
compatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";
Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Right, I think we can just put them into defconfig. No need to "select" them from Kconfig since the extra options wouldn't be required for booting or using the system.
Arnd
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 8 lines · Arnd Bergmann
Quoted 6 lines · Olof Johansson
Quoted 5 lines · Kukjin Kim
Quoted 1 line · Arnd Bergmann
On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Basically, I agreed with Arnd's suggestion to use
ARCH_SBSA. Or we need to define level inKconfiglikeARCH_SBSA_L1for level1. BTW, how about compliant with SBSA Level1 and having some specific features?
Well, how about ARMv8 mobile SoC? I think, it is not compatible with SBSA. For example, you know MCT can be used for ARMv8 cores instead of ARCH Timer. So I'm not sure ARCH_SBSA is really good choice...
Quoted 6 lines
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";
Quoted 8 lines
Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.
As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
- Kukjin
Arnd Bergmann
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 4 lines · On Tuesday 18 February 2014 10:10:30 Kukjin Kim wrote:
Quoted 3 lines · Arnd Bergmann
Quoted 2 lines · Olof Johansson
Quoted 1 line · Kukjin Kim
On 02/13/14 04:14, Arnd Bergmann wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line · On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Basically, I agreed with Arnd's suggestion to use
ARCH_SBSA. Or we need to define level inKconfiglikeARCH_SBSA_L1for level1. BTW, how about compliant with SBSA Level1 and having some specific features?Well, how about ARMv8 mobile SoC? I think, it is not compatible with SBSA. For example, you know MCT can be used for ARMv8 cores instead of ARCH Timer. So I'm not sure
ARCH_SBSAis really good choice...
Sure, if you are talking about an embedded SoC that is not SBSA compliant, we shouldn't try to make it work with ARCH_SBSA and instead give it its own Kconfig symbol.
Quoted 10 lines
Quoted 10 lines
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
If it's just one driver that is needed in addition to the usual stuff, we can also just make it a standalone option and turn it on in the generic defconfig. We won't need a per-platform option in that case.
Arnd
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Kukjin KimQuoted 34 lines · Kukjin Kim
Quoted 6 lines · Arnd Bergmann
Quoted 4 lines · Olof Johansson
Quoted 1 line · Kukjin Kim
Quoted 10 lines
Quoted 8 lines
Quoted 8 lines · Arnd Bergmann
Quoted 2 lines · On Wednesday 12 February 2014 13:04:40 Kumar Gala wrote:
Basically, I agreed with Arnd's suggestion to use
ARCH_SBSA. Or we need to
define level inKconfiglikeARCH_SBSA_L1for level1. BTW, how about compliant with SBSA Level1 and having some specific features?Well, how about ARMv8 mobile SoC? I think, it is not compatible with SBSA. For example, you know MCT can be used for ARMv8 cores instead of ARCH Timer. So I'm not sure
ARCH_SBSAis really good choice...Quoted 12 lines
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource Kconfig instead. Then it's just a matter of making sure your defconfig has the needed driver enabled.
(Adding Daniel and Thomas in case they have objections to that approach)
-Olof
Arnd Bergmann
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 21 lines · On Tuesday 18 February 2014 08:16:13 Olof Johansson wrote:
Quoted 13 lines · Kukjin Kim
Quoted 12 lines · Arnd Bergmann
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
Quoted 7 lines
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource
Kconfiginstead. Then it's just a matter of making sure your defconfig has the needed driver enabled.(Adding Daniel and Thomas in case they have objections to that approach)
+John Stultz
IIRC it was John who insisted on doing it the current way, although I can't remember his reasoning.
Arnd
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 28 lines · Arnd Bergmann
Quoted 27 lines · On Tuesday 18 February 2014 08:16:13 Olof Johansson wrote:
Quoted 13 lines · Kukjin Kim
Quoted 12 lines · Arnd Bergmann
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource
Kconfiginstead. Then it's just a matter of making sure your defconfig has the needed driver enabled.
Quoted 6 lines
Quoted 1 line
(Adding Daniel and Thomas in case they have objections to that approach)
+John Stultz
IIRC it was John who insisted on doing it the current way, although I can't remember his reasoning.
Are we really expecting there to be SoC specific clocksources here? I thought we were getting away from that sort of stuff with the architecture timer?
I'm fine with clocksources being selected by other functionality options (ie: on x86 ACPI PM timer clocksource doesn't have a prompt, but depends on the ACPI option). I just don't want to force users to have to navigate through tons of deep menus to select clocksource options that logically duplicate other selections already made.
But again, I handed this maintainership over to Daniel, so I can be considered just a crank yelling from the sidelines :)
thanks
-john
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 31 lines · John Stultz
Quoted 30 lines · Arnd Bergmann
Quoted 28 lines · On Tuesday 18 February 2014 08:16:13 Olof Johansson wrote:
Quoted 13 lines · Kukjin Kim
Quoted 12 lines · Arnd Bergmann
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource
Kconfiginstead. Then it's just a matter of making sure your defconfig has the needed driver enabled.(Adding Daniel and Thomas in case they have objections to that approach)
Quoted 8 lines
Quoted 4 lines
+John Stultz
IIRC it was John who insisted on doing it the current way, although I can't remember his reasoning.
Are we really expecting there to be SoC specific clocksources here? I thought we were getting away from that sort of stuff with the architecture timer?
Unfortunately vendors can do crazy stuff if they want to. But we also have an option to choose to enable it. Maybe the answer here is to say no to MCT on 64-bit, they get to use the arch timers like everybody else. Or at least motivate why they're not good enough.
Quoted 8 lines
I'm fine with clocksources being selected by other functionality options (ie: on x86 ACPI PM timer clocksource doesn't have a prompt, but depends on the ACPI option). I just don't want to force users to have to navigate through tons of deep menus to select clocksource options that logically duplicate other selections already made.
But again, I handed this maintainership over to Daniel, so I can be considered just a crank yelling from the sidelines :)
I think you have a good point. Until we hear why MCT is needed this is mostly speculation, so let's see what Kukjin says about that.
-Olof
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 52 lines · Olof Johansson
Quoted 31 lines · John Stultz
Quoted 30 lines · Arnd Bergmann
Quoted 28 lines · On Tuesday 18 February 2014 08:16:13 Olof Johansson wrote:
Quoted 13 lines · Kukjin Kim
Quoted 12 lines · Arnd Bergmann
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource
Kconfiginstead. Then it's just a matter of making sure your defconfig has the needed driver enabled.(Adding Daniel and Thomas in case they have objections to that approach)
Quoted 8 lines
Quoted 4 lines
+John Stultz
IIRC it was John who insisted on doing it the current way, although I can't remember his reasoning.
Are we really expecting there to be SoC specific clocksources here? I thought we were getting away from that sort of stuff with the architecture timer?
Unfortunately vendors can do crazy stuff if they want to. But we also have an option to choose to enable it. Maybe the answer here is to say no to MCT on 64-bit, they get to use the arch timers like everybody else. Or at least motivate why they're not good enough.
Quoted 6 lines
I'm fine with clocksources being selected by other functionality options (ie: on x86 ACPI PM timer clocksource doesn't have a prompt, but depends on the ACPI option). I just don't want to force users to have to navigate through tons of deep menus to select clocksource options that logically duplicate other selections already made.
Quoted 5 lines
Quoted 2 lines
But again, I handed this maintainership over to Daniel, so I can be considered just a crank yelling from the sidelines :)
I think you have a good point. Until we hear why MCT is needed this is mostly speculation, so let's see what Kukjin says about that.
Yea. And on x86 (well, i386 actually) there are system specific clocksources as well, such as the cyclone timer used by "summit" based x440 and similar NUMA systems, but those systems had more general config options that had to be enabled which the cyclone clocksource depended on.
thanks
-john
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 56 lines · John Stultz
Quoted 55 lines · Olof Johansson
Quoted 31 lines · John Stultz
Quoted 30 lines · Arnd Bergmann
Quoted 28 lines · On Tuesday 18 February 2014 08:16:13 Olof Johansson wrote:
Quoted 13 lines · Kukjin Kim
Quoted 12 lines · Arnd Bergmann
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource
Kconfiginstead. Then it's just a matter of making sure your defconfig has the needed driver enabled.(Adding Daniel and Thomas in case they have objections to that approach)
Quoted 8 lines
Quoted 4 lines
+John Stultz
IIRC it was John who insisted on doing it the current way, although I can't remember his reasoning.
Are we really expecting there to be SoC specific clocksources here? I thought we were getting away from that sort of stuff with the architecture timer?
Unfortunately vendors can do crazy stuff if they want to. But we also have an option to choose to enable it. Maybe the answer here is to say no to MCT on 64-bit, they get to use the arch timers like everybody else. Or at least motivate why they're not good enough.
Quoted 8 lines
I'm fine with clocksources being selected by other functionality options (ie: on x86 ACPI PM timer clocksource doesn't have a prompt, but depends on the ACPI option). I just don't want to force users to have to navigate through tons of deep menus to select clocksource options that logically duplicate other selections already made.
But again, I handed this maintainership over to Daniel, so I can be considered just a crank yelling from the sidelines :)
Quoted 8 lines
Quoted 2 lines
I think you have a good point. Until we hear why MCT is needed this is mostly speculation, so let's see what Kukjin says about that.
Yea. And on x86 (well, i386 actually) there are system specific clocksources as well, such as the cyclone timer used by "summit" based x440 and similar NUMA systems, but those systems had more general config options that had to be enabled which the cyclone clocksource depended on.
So, after giving this some more thought (and getting my hands dirty in some of this code), I think I'm going to change my mind on this. For mobile platforms I think it might make sense to bring over the toplevel platform Kconfig from arch/arm, to simplify dependencies without tearing up the driver subtree with churn like this.
This, of course, only holds true for v8 mobile platforms. Samsung isn't saying if GH7 is a server platform and not, and they don't have to tell us. But I think we should consider only enabling and bringing over the mobile ones (and ideally try to avoid even that, but it might make sense to do some of them at least initially -- it does provide some convenient ways to enable larger subsets of default drivers per platform/vendor family).
I.e. I'd be OK with an ARCH_EXYNOS/ARCH_TEGRA/ARCH_IMX/ARCH_<whatever>, but I don't think we should add more finegrained options than that globally on ARM64, at least not until truly proven to be needed. We're trying to push back against new per-SoC Kconfig entries on 32-bit as well right now.
-Olof
Catalin Marinas
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 14 lines · Olof Johansson
So, after giving this some more thought (and getting my hands dirty in some of this code), I think I'm going to change my mind on this. For mobile platforms I think it might make sense to bring over the toplevel platform
Kconfigfromarch/arm, to simplify dependencies without tearing up the driver subtree with churn like this.This, of course, only holds true for v8 mobile platforms. Samsung isn't saying if GH7 is a server platform and not, and they don't have to tell us. But I think we should consider only enabling and bringing over the mobile ones (and ideally try to avoid even that, but it might make sense to do some of them at least initially -- it does provide some convenient ways to enable larger subsets of default drivers per platform/vendor family).
Quoted 5 lines
I.e. I'd be OK with an ARCH_EXYNOS/ARCH_TEGRA/ARCH_IMX/ARCH_<whatever>, but I don't think we should add more finegrained options than that globally on ARM64, at least not until truly proven to be needed. We're trying to push back against new per-SoC
Kconfigentries on 32-bit as well right now.
I'm fine with this. Do we still need something for ARMv8 server platforms like ARCH_ARM_SBSA? The only advantage would be to make it easier for mobile targeted kernel builds to disable server features but I'm not sure there are so many such features, people can trim the .config manually.
Two additional points:
1. Single arm64 defconfig file covering everything
2. Modules rather than built-in by default where possible (especially for server platforms)
Signature · 1 line
Catalin
Arnd Bergmann
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 6 lines · On Thursday 20 February 2014 11:22:48 Catalin Marinas wrote:
I'm fine with this. Do we still need something for ARMv8 server platforms like
ARCH_ARM_SBSA? The only advantage would be to make it easier for mobile targeted kernel builds to disable server features but I'm not sure there are so many such features, people can trim the .config manually.
I think in particular for SBSA compliant platforms we should not have per-platform options at all the way we do for embedded, as they will be much more homogenous.
Quoted 5 lines
Two additional points:
1. Single arm64 defconfig file covering everything
2. Modules rather than built-in by default where possible (especially for server platforms)
+1
Arnd
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Catalin MarinasQuoted 21 lines · Catalin Marinas
Quoted 14 lines · Olof Johansson
So, after giving this some more thought (and getting my hands dirty in some of this code), I think I'm going to change my mind on this. For mobile platforms I think it might make sense to bring over the toplevel platform
Kconfigfromarch/arm, to simplify dependencies without tearing up the driver subtree with churn like this.This, of course, only holds true for v8 mobile platforms. Samsung isn't saying if GH7 is a server platform and not, and they don't have to tell us. But I think we should consider only enabling and bringing over the mobile ones (and ideally try to avoid even that, but it might make sense to do some of them at least initially -- it does provide some convenient ways to enable larger subsets of default drivers per platform/vendor family).
Quoted 5 lines
I.e. I'd be OK with an ARCH_EXYNOS/ARCH_TEGRA/ARCH_IMX/ARCH_<whatever>, but I don't think we should add more finegrained options than that globally on ARM64, at least not until truly proven to be needed. We're trying to push back against new per-SoC
Kconfigentries on 32-bit as well right now.
Quoted 5 lines
I'm fine with this. Do we still need something for ARMv8 server platforms like
ARCH_ARM_SBSA? The only advantage would be to make it easier for mobile targeted kernel builds to disable server features but I'm not sure there are so many such features, people can trim the .config manually.
I don't think there's all that much that's unique to SBSA for a Kconfig entry. If anything it could be useful to describe dependencies (i.e. you very likely don't want to turn off the standardized UART driver, etc). But doing that through Kconfig is a bit clumsy, we might be better off doing it through example defconfigs. I'm not sure we want to do it through selects.
Quoted 5 lines
Two additional points:
1. Single arm64 defconfig file covering everything
2. Modules rather than built-in by default where possible (especially for server platforms)
Sounds good to me. Are you also willing to pick up one defconfig per vendor (but not more)? I think it's been useful to have those on arm, even on multiplatform kernels. We used them on powerpc as well, where we had a two-layer approach (ppc64_defconfig and per-platform configs, pseries/iseries/pasemi/g5/cell).
-Olof
Catalin Marinas
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 7 lines · Olof Johansson
On Thu, Feb 20, 2014 at 3:22 AM, Catalin Marinas
Quoted 5 lines
Two additional points:
1. Single arm64 defconfig file covering everything
2. Modules rather than built-in by default where possible (especially for server platforms)
Quoted 5 lines
Sounds good to me. Are you also willing to pick up one defconfig per vendor (but not more)? I think it's been useful to have those on arm, even on multiplatform kernels. We used them on powerpc as well, where we had a two-layer approach (
ppc64_defconfigand per-platform configs, pseries/iseries/pasemi/g5/cell).
Initially I would keep a single defconfig with everything just to get wider coverage of single Image. Later on, if just deselecting config entries doesn't work, we can revisit per-vendor defconfigs.
Signature · 1 line
Catalin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 14 lines · Catalin Marinas
Quoted 7 lines · Olof Johansson
On Thu, Feb 20, 2014 at 3:22 AM, Catalin Marinas
Quoted 5 lines
Two additional points:
1. Single arm64 defconfig file covering everything
2. Modules rather than built-in by default where possible (especially for server platforms)Quoted 5 lines
Sounds good to me. Are you also willing to pick up one defconfig per vendor (but not more)? I think it's been useful to have those on arm, even on multiplatform kernels. We used them on powerpc as well, where we had a two-layer approach (
ppc64_defconfigand per-platform configs, pseries/iseries/pasemi/g5/cell).
Quoted 4 lines
Initially I would keep a single defconfig with everything just to get wider coverage of single Image. Later on, if just deselecting config entries doesn't work, we can revisit per-vendor defconfigs.
OK, agreed with single defconfig on ARMv8 for now. And as Olof said, it's expected that each vendor maybe needs to use per-vendor defconfig soon and agreed too :-)
Thanks,
Kukjin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Olof JohanssonOn 02/20/14 18:03, Olof Johansson wrote:
[...]
Quoted 7 lines
I.e. I'd be OK with an ARCH_EXYNOS/ARCH_TEGRA/ARCH_IMX/ARCH_<whatever>, but I don't think we should add more finegrained options than that globally on ARM64, at least not until truly proven to be needed. We're trying to push back against new per-SoC
Kconfigentries on 32-bit as well right now.
OK, agreed.
- Kukjin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Olof JohanssonQuoted 52 lines · Olof Johansson
Quoted 31 lines · John Stultz
Quoted 30 lines · Arnd Bergmann
Quoted 28 lines · On Tuesday 18 February 2014 08:16:13 Olof Johansson wrote:
Quoted 13 lines · Kukjin Kim
Quoted 12 lines · Arnd Bergmann
My feeling is that we don't need to use the levels for
Kconfig, although we might want to use them DT compatible strings, even if it ends up looking
a little funny when you docompatible = "arm,sbsa-l3", "arm,sbsa-l2", "arm,sbsa-l1";Quoted 3 lines
What kind of features are you expecting though? More IP blocks/devices? Those are just kernel config options to enable, ideally as modules.
Quoted 6 lines
Quoted 4 lines
Right, I think we can just put them into defconfig. No need to "select" them from
Kconfigsince the extra options wouldn't be required for booting or using the system.As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
It looks like the clocksource drivers are all based around being enabled based on platforms instead of individually selectable. That causes a problem here. I think we should change the clocksource
Kconfiginstead. Then it's just a matter of making sure your defconfig has the needed driver enabled.(Adding Daniel and Thomas in case they have objections to that approach)
Quoted 8 lines
Quoted 4 lines
+John Stultz
IIRC it was John who insisted on doing it the current way, although I can't remember his reasoning.
Are we really expecting there to be SoC specific clocksources here? I thought we were getting away from that sort of stuff with the architecture timer?
Unfortunately vendors can do crazy stuff if they want to. But we also have an option to choose to enable it. Maybe the answer here is to say no to MCT on 64-bit, they get to use the arch timers like everybody else. Or at least motivate why they're not good enough.
Quoted 6 lines
I'm fine with clocksources being selected by other functionality options (ie: on x86 ACPI PM timer clocksource doesn't have a prompt, but depends on the ACPI option). I just don't want to force users to have to navigate through tons of deep menus to select clocksource options that logically duplicate other selections already made.
Quoted 6 lines
Quoted 2 lines
But again, I handed this maintainership over to Daniel, so I can be considered just a crank yelling from the sidelines :)
I think you have a good point. Until we hear why MCT is needed this is mostly speculation, so let's see what Kukjin says about that.
Using MCT on ARMv8 is an example, it's true on some Samsung ARMv8 SoC though. I don't want to argue what's the benefit of MCT in this thread, but just possibility. As you know, generally ARM SoC vendor is open to use any IPs...So I'd like to say we need to consider the situation.
Anyway, basically I agree with you guys suggestion to use common CONFIG on ARMv8 like multiplatform supporting on arm32.
Thanks,
Kukji
Catalin Marinas
maintainerPATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Kukjin KimQuoted 2 lines · Kukjin Kim
As I commented above, how about MCT? Samsung has a plan to use MCT on ARMv8, it is not for used for GH7 though...
Any reason for not using the generic timer?
Signature · 1 line
Catalin
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
In reply to Olof JohanssonQuoted 10 lines · Olof Johansson
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>The overhead of building one more device tree isn't very large, and I don't see any other need to have a
Kconfigentry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.
I think having "make dtbs" build all regardless of the config would be better. Perhaps a "all_dtbs" target could be added and everyone can get what they want. If/when we add checking into dtc, this we certainly become more desirable.
Rob
PATCH 2/3 arm64: Add Kconfig option for Samsung GH7 SoC family
Quoted 7 lines · Rob Herring
Quoted 6 lines · Olof Johansson
Quoted 4 lines · Kukjin Kim
This patch adds support for Samsung GH7 SoC in arm64/Kconfig.
Signed-off-by Kukjin Kim <[email protected]>Cc Catalin Marinas <[email protected]>
Quoted 7 lines
Quoted 4 lines
The overhead of building one more device tree isn't very large, and I don't see any other need to have a
Kconfigentry per SoC at this time. It's of course up to Catalin, but you might just want to always compile all dts files instead.I think having "make dtbs" build all regardless of the config would be better.
We can do that too, but that doesn't mean it's useful to have this kconfig entry.
Quoted 3 lines
Perhaps a "
all_dtbs" target could be added and everyone can get what they want. If/when we add checking into dtc, this we certainly become more desirable.
-Olof
PATCH 3/3 Documentation: DT: add new entry for Samsung GH7 SoC and SSDK board
In reply to Kukjin Kim--- Documentation/devicetree/bindings/arm/samsung-boards.txt | 10 ++++++++++ 1 file changed, 10 insertions(+)
Documentation/devicetree/bindings/arm/samsung-boards.txt +10 -0
@@ -16,3 +16,13 @@ Optional: compatible = "samsung,secure-firmware"; reg = <0x0203F000 0x1000>; }; + +* Samsung's GH7 based SSDK-GH7 evaluation board + +SSDK-GH7 evaluation board is based on Samsung's GH7 SoC which has ARMv8 cores. + +Required root node properties: + - compatible = should be one or more of the following. + (a) "samsung,ssdk-gh7" - for Samsung's SSDK-GH7 eval board. + (b) "samsung,gh7" - for boards based on GH7 SoC. +
Signature · 1 line
1.7.10.4