Skip to contentSkip to conversation

hostap: fix "hostap: proc: Use remove_proc_subtree()"

PATCH New Russell King - ARM Linux 1 participant 1 message Feb 12, 2014 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hostap: fix "hostap: proc: Use remove_proc_subtree()"

remove_proc_subtree() doesn't work here as local->ddev has already been removed, and NULLed out. Use proc_remove() instead.

---
I would include an oops, however the machine I discovered this on has a page 0 populated - so the symptoms are multiple 'wlan0' entries in /proc/net/hostap. This is probably a candidate for stable too.

 drivers/net/wireless/hostap/hostap_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/hostap/hostap_proc.c +1 -1
index aa7ad3a7a69b..4e5c0f8c9496 100644
@@ -496,7 +496,7 @@ void hostap_init_proc(local_info_t *local)
 
 void hostap_remove_proc(local_info_t *local)
 {
-	remove_proc_subtree(local->ddev->name, hostap_proc);
+	proc_remove(local->proc);
 }
 
 
Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".