crypto: remove a duplicate checks in __cbc_decrypt()
Subsystems (3)
PATCH 1/1 crypto: remove a duplicate checks in __cbc_decrypt()
We checked "nbytes < bsize" before so it can't happen here.
---
This doesn't change how the code works, but maybe their is a bug in the original code. Please review?
arch/x86/crypto/cast5_avx_glue.c +0 -3
@@ -203,9 +203,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -=1 ; dst -=1 ; }while (nbytes >= bsize *CAST5_PARALLEL_BLOCKS ); - -if (nbytes < bsize) - goto done; }/* Handle leftovers */
arch/x86/crypto/blowfish_glue.c +0 -3
@@ -223,9 +223,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -=1 ; dst -=1 ; }while (nbytes >= bsize *4 ); - -if (nbytes < bsize) - goto done; }/* Handle leftovers */
Quoted 3 lines · Dan Carpenter
We checked "nbytes < bsize" before so it can't happen here.
Signed-off-by Dan Carpenter <[email protected]>
Quoted 37 lines
---
This doesn't change how the code works, but maybe their is a bug in the original code. Please review?arch/x86/crypto/cast5_avx_glue.c +0
-3@@ -203,9 +203,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -=1 ; dst -=1 ; }while (nbytes >= bsize *CAST5_PARALLEL_BLOCKS ); - -if (nbytes < bsize) - goto done; }/* Handle leftovers */ arch/x86/crypto/blowfish_glue.c +0
-4@@ -223,9 +223,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -=1 ; dst -=1 ; }while (nbytes >= bsize *4 ); - -if (nbytes < bsize) - goto done; }/* Handle leftovers */ --To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line · Dan Carpenter
Signed-off-by Dan Carpenter <[email protected]>
Quoted 23 lines
---
This doesn't change how the code works, but maybe their is a bug in the original code. Please review?arch/x86/crypto/cast5_avx_glue.c +0
-3@@ -203,9 +203,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -=1 ; dst -=1 ; }while (nbytes >= bsize *CAST5_PARALLEL_BLOCKS ); - -if (nbytes < bsize) - goto done; }/* Handle leftovers */ arch/x86/crypto/blowfish_glue.c +0
-0
arch/x86/crypto/blowfish_glue.c static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, · line 228
Quoted 9 lines
arch/x86/crypto/blowfish_glue.c +0
-3@@ -223,9 +223,6 @@ static unsigned int __cbc_decrypt(struct blkcipher_desc *desc, src -=1 ; dst -=1 ; }while (nbytes >= bsize *4 ); - -if (nbytes < bsize) - goto done; }/* Handle leftovers */
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Herbert Xu
maintainerQuoted 4 lines · Johannes Götzfried
Quoted 1 line · Dan Carpenter
Signed-off-by Dan Carpenter <[email protected]>
Patch applied. Thanks!
Signature · 7 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html