Skip to contentSkip to conversation

relocate-rela: replace a magic number with sizeof(Elf64_Rela)

PATCH New Masahiro Yamada 3 participants 3 messages Feb 4, 2014 – Feb 13, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 relocate-rela: replace a magic number with sizeof(Elf64_Rela)

---
 tools/relocate-rela.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/relocate-rela.c +1 -1
index 93b4c39..670b9fd 100644
@@ -120,7 +120,7 @@ int main(int argc, char **argv)
 	}
 
 	if (rela_start > rela_end || rela_start < text_base ||
-	    (rela_end - rela_start) % 24) {
+	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
 		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
 		return 3;
 	}
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 relocate-rela: replace a magic number with sizeof(Elf64_Rela)

Quoted 12 lines · Masahiro Yamada
---
 tools/relocate-rela.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/relocate-rela.c +0 -0
index 93b4c39..670b9fd 100644

tools/relocate-rela.c int main(int argc, char **argv) · line 126

Quoted 8 lines
tools/relocate-rela.c +1 -1
@@ -120,7 +120,7 @@ int main(int argc, char **argv)
 	}
 
 	if (rela_start > rela_end || rela_start < text_base ||
-	    (rela_end - rela_start) % 24) {
+	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
 		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
 		return 3;
 	}

-Scott

#2 lore raw

PATCH 1/1 relocate-rela: replace a magic number with sizeof(Elf64_Rela)

In reply to Masahiro Yamada

Hi Masahiro,

Quoted 12 lines · Masahiro Yamada
---
 tools/relocate-rela.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/relocate-rela.c +0 -0
index 93b4c39..670b9fd 100644

tools/relocate-rela.c int main(int argc, char **argv) · line 126

Quoted 8 lines
tools/relocate-rela.c +1 -1
@@ -120,7 +120,7 @@ int main(int argc, char **argv)
 	}
 
 	if (rela_start > rela_end || rela_start < text_base ||
-	    (rela_end - rela_start) % 24) {
+	    (rela_end - rela_start) % sizeof(Elf64_Rela)) {
 		fprintf(stderr, "%s: bad rela bounds\n", argv[0]);
 		return 3;
 	}

Applied to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line
Albert.