sparc: fix implicit include of slab.h in leon_pci_grpci2.c
Subsystems (2)
PATCH 1/1 sparc: fix implicit include of slab.h in leon_pci_grpci2.c
To fix:
arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror] arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
According to Stephen, these types of failures are caused by commit 2bd59d48ebfb ("cgroup: convert to kernfs") which was being included implicitly via cgroup.h's inclusion of xattr.h (which has now been removed).
--- arch/sparc/kernel/leon_pci_grpci2.c | 1 + 1 file changed, 1 insertion(+)
arch/sparc/kernel/leon_pci_grpci2.c +1 -0
@@ -8,6 +8,7 @@#include <linux/of_device.h> #include <linux/kernel.h> #include <linux/pci.h> +#include <linux/slab.h> #include <linux/delay.h> #include <linux/export.h> #include <asm/io.h>
Signature · 1 line
1.8.5.2
Quoted 9 lines · Paul Gortmaker
To fix:
arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
Quoted 8 lines
According to Stephen, these types of failures are caused by commit
2bd59d48ebfb("cgroup: convert to kernfs") which was being included implicitly via cgroup.h's inclusion ofxattr.h(which has now been removed).Cc Stephen Rothwell <[email protected]>Cc Tejun Heo <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Darn, another one. David, can you please ack this one? I'll push it through cgroup/for-3.15 so that -next doesn't break.
Thanks.
Signature · 1 line
tejun
From: Tejun Heo <[email protected]>
Date: Thu, 13 Feb 2014 15:42:17 -0500
Quoted 15 lines · Paul Gortmaker
Quoted 14 lines
To fix:
arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1According to Stephen, these types of failures are caused by commit
2bd59d48ebfb("cgroup: convert to kernfs") which was being included implicitly via cgroup.h's inclusion ofxattr.h(which has now been removed).
Quoted 6 lines
Quoted 3 lines
Cc Stephen Rothwell <[email protected]>Cc Tejun Heo <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>Darn, another one. David, can you please ack this one? I'll push it through cgroup/for-3.15 so that -next doesn't break.
Tejun Heo
AppliedQuoted 9 lines · Paul Gortmaker
To fix:
arch/sparc/kernel/leon_pci_grpci2.c: In function 'grpci2_of_probe':arch/sparc/kernel/leon_pci_grpci2.c:720:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]arch/sparc/kernel/leon_pci_grpci2.c:720:20: error: assignment makes pointer from integer without a cast [-Werror]arch/sparc/kernel/leon_pci_grpci2.c:882:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [arch/sparc/kernel/leon_pci_grpci2.o] Error 1
Quoted 8 lines
According to Stephen, these types of failures are caused by commit
2bd59d48ebfb("cgroup: convert to kernfs") which was being included implicitly via cgroup.h's inclusion ofxattr.h(which has now been removed).Cc Stephen Rothwell <[email protected]>Cc Tejun Heo <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Applied to cgroup/for-3.15.
Thanks.
Signature · 1 line
tejun