Skip to contentSkip to conversation

arm: dtsi: am335x-bone-common, usb0 is peripheral only

PATCH New Markus Pargmann 2 participants 6 messages Jan 11, 2014 – Feb 14, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dtsi: am335x-bone-common, usb0 is peripheral only

The PMIC is using usb0 vbus line as power source. It is also connected to the am335x processor as vbus sense. But there is no possibility to pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0.

---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/am335x-bone-common.dtsi +1 -0
index e3f27ec..da2db9b 100644
@@ -197,6 +197,7 @@
 
 	usb at 47401000 {
 		status = "okay";
+		dr_mode = "peripheral";
 	};
 
 	usb at 47401800 {
Signature · 1 line
1.8.5.2
#1 lore raw

PATCH 1/1 arm: dtsi: am335x-bone-common, usb0 is peripheral only

Quoted 3 lines · Markus Pargmann

The PMIC is using usb0 vbus line as power source. It is also connected to the am335x processor as vbus sense. But there is no possibility to pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0.

That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral only mode because the hardware does what it wants based on the ID pin state.

Regards,

Tony

#2 lore raw

PATCH 1/1 arm: dtsi: am335x-bone-common, usb0 is peripheral only

Hi,

Quoted 8 lines · Tony Lindgren
Quoted 3 lines · Markus Pargmann

The PMIC is using usb0 vbus line as power source. It is also connected to the am335x processor as vbus sense. But there is no possibility to pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0.

That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral only mode because the hardware does what it wants based on the ID pin state.

Yes that's MUSB. The am335x reference manual describes that it is possible to force peripheral/host mode by setting bit 7 (IDDIG_MUX) in register USBnMODE to 1. Then it uses the bit written in bit 8 (IDDIG) of register USBnMODE to set host/peripheral mode.

I am not sure if the driver supports it yet but I think the DTS should contain the correct mode nevertheless, especially to avoid starting the otg loops in the musb driver.

Regards,

Markus

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/1 arm: dtsi: am335x-bone-common, usb0 is peripheral only

Quoted 8 lines · Markus Pargmann

Hi,

Quoted 5 lines · Tony Lindgren
Quoted 3 lines · Markus Pargmann

The PMIC is using usb0 vbus line as power source. It is also connected to the am335x processor as vbus sense. But there is no possibility to pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0.

Quoted 8 lines
Quoted 3 lines

That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral only mode because the hardware does what it wants based on the ID pin state.

Yes that's MUSB. The am335x reference manual describes that it is possible to force peripheral/host mode by setting bit 7 (IDDIG_MUX) in register USBnMODE to 1. Then it uses the bit written in bit 8 (IDDIG) of register USBnMODE to set host/peripheral mode.

OK

Quoted 3 lines

I am not sure if the driver supports it yet but I think the DTS should contain the correct mode nevertheless, especially to avoid starting the otg loops in the musb driver.

Well there's one more thing to consider.. I think in the OTG role change case the VBUS is still driven externally from the original host, so the lack of VBUS does not always mean that host mode should be disabled.

Regards,

Tony

#4 lore raw

PATCH 1/1 arm: dtsi: am335x-bone-common, usb0 is peripheral only

Hi,

Quoted 20 lines · Tony Lindgren
Quoted 8 lines · Markus Pargmann

Hi,

Quoted 5 lines · Tony Lindgren
Quoted 3 lines · Markus Pargmann

The PMIC is using usb0 vbus line as power source. It is also connected to the am335x processor as vbus sense. But there is no possibility to pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0.

Quoted 8 lines
Quoted 3 lines

That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral only mode because the hardware does what it wants based on the ID pin state.

Yes that's MUSB. The am335x reference manual describes that it is possible to force peripheral/host mode by setting bit 7 (IDDIG_MUX) in register USBnMODE to 1. Then it uses the bit written in bit 8 (IDDIG) of register USBnMODE to set host/peripheral mode.

OK

Quoted 7 lines
Quoted 3 lines

I am not sure if the driver supports it yet but I think the DTS should contain the correct mode nevertheless, especially to avoid starting the otg loops in the musb driver.

Well there's one more thing to consider.. I think in the OTG role change case the VBUS is still driven externally from the original host, so the lack of VBUS does not always mean that host mode should be disabled.

I thought more about the hardware description than the possible role changes through software protocols. In a hardware perspective, this USB port is only in peripheral mode, as it can't drive VBUS. However is there any support for role change protocols in the kernel yet?

Perhaps we have to add a seperate DT binding for usb role changes when they are supported. This would help to describe the hardware capabilities (host, peripheral or OTG) and the role change protocols supported.

Regards,

Markus

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#5 lore raw

PATCH 1/1 arm: dtsi: am335x-bone-common, usb0 is peripheral only

Quoted 27 lines · Markus Pargmann

Hi,

Quoted 24 lines · Tony Lindgren
Quoted 8 lines · Markus Pargmann

Hi,

Quoted 5 lines · Tony Lindgren
Quoted 3 lines · Markus Pargmann

The PMIC is using usb0 vbus line as power source. It is also connected to the am335x processor as vbus sense. But there is no possibility to pullup usb0 vbus to operate as host. This patch fixes the dr_mode of usb0.

Quoted 8 lines
Quoted 3 lines

That's the MUSB? AFAIK it's not possible to operate MUSB in peripheral only mode because the hardware does what it wants based on the ID pin state.

Yes that's MUSB. The am335x reference manual describes that it is possible to force peripheral/host mode by setting bit 7 (IDDIG_MUX) in register USBnMODE to 1. Then it uses the bit written in bit 8 (IDDIG) of register USBnMODE to set host/peripheral mode.

OK

Quoted 3 lines

I am not sure if the driver supports it yet but I think the DTS should contain the correct mode nevertheless, especially to avoid starting the otg loops in the musb driver.

Quoted 8 lines
Quoted 3 lines

Well there's one more thing to consider.. I think in the OTG role change case the VBUS is still driven externally from the original host, so the lack of VBUS does not always mean that host mode should be disabled.

I thought more about the hardware description than the possible role changes through software protocols. In a hardware perspective, this USB port is only in peripheral mode, as it can't drive VBUS. However is there any support for role change protocols in the kernel yet?

There's some to trigger it, if you grep -ri hnp drivers/usb/ you'll see some references to it.

Quoted 4 lines

Perhaps we have to add a seperate DT binding for usb role changes when they are supported. This would help to describe the hardware capabilities (host, peripheral or OTG) and the role change protocols supported.

Yeah it might be worth discussing on the USB list what's the best way to deal with all that.

Regards,

Tony