Introducing XBMC
v5 cover Introducing XBMC
Hi all,
This is a new version of the series of patch introducing XBMC.
A new one appeared, which add the dependencies of Java on the host machine for XBMC.
Also, the $(MAKE1) for XBMC has been removed. After doing a loop of 50 builds and no trouble so far to report, I assumed it was safe, at least for now.
As always, I wait for your reviews and comments !
Maxime Hadjinlian (5):
sdl: fix autoreconf timing issue
sdl: add host version
sdl_image: add host version
dependencies.sh: XBMC needs java on the host
xbmc: new package
package/Config.in | 1 + .../sdl/sdl-0001-use-correct-directfb-config.patch | 19 +- package/sdl/sdl.mk | 2 + package/sdl_image/sdl_image.mk | 11 ++ package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ support/dependencies/dependencies.sh | 10 + 11 files changed, 702 insertions(+), 17 deletions(-) create mode 100644 package/xbmc/Config.in create mode 100755 package/xbmc/S50xbmc create mode 100644 package/xbmc/xbmc-0001-Fixup-include-path.patch create mode 100644 package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patch create mode 100644 package/xbmc/xbmc.mk create mode 100644 package/xbmc/xbmc.service
--
1.8.5.3
PATCH v5 1/5 sdl: fix autoreconf timing issue
Context:
The autobuilders were failing on the symbol _XData32 being in conflicts. A patch had been added to SDL to add a check to the configure.in
Problem:
Sometimes, the build would fail, because of an _XData32 symbol being in conflicts eventhrough the patch was here.
What was happening:
Following the classic buildroot workflow:
- Extract
- [...]
- Apply 001 patch, which touches configure.in AND configure
- Apply 002 patch, which touches configure.in
- Invoke autogen.sh
- [...]
Right before running autogen.sh, we have configure.in which is more recent than configure, which is fine.
We then, execute autogen.sh which, basically, runs autoconf.
If your machine was lighty loaded, the time difference between configure.in and configure was really tiny (ms order), which seems to be neglected by autoconf.
The results was that the configure was *NOT* generated. And our second patch was taken into account.
If your machine was under heavy load, the time difference between the two files would have been greater and then *maybe* picked up by autoconf. And then the configure file was re-generated.
When the 0001 patch was introduced, SDL package did *NOT* run it's autogen.sh, which is why it touches also the configure. This came later, causing this behavior.
Fixes:
http://autobuild.buildroot.net/results/d1c/d1c36f634dbf6b6e5d18444c2a23dfd129202b80/
--- .../sdl/sdl-0001-use-correct-directfb-config.patch | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-)
package/sdl/sdl-0001-use-correct-directfb-config.patch +2 -17
@@ -4,13 +4,10 @@ The configure script has just checked for the correct directfb-config script, so also use it for the version check instead of whatever might be in the path. -Also patch the generated configure, as it doesn't cleanly autoreconf. - Signed-off-by: Peter Korsgaard <[email protected]> --- - configure | 2 +- configure.in | 2 +- - 2 files changed, 2 insertions(+), 2 deletions(-) + 1 files changed, 1 insertions(+), 1 deletions(-) Index: SDL-1.2.15/configure.in ===================================================================
@@ -25,16 +22,4 @@ Index: SDL-1.2.15/configure.in HAVE_VERSION=`expr $1 \* 10000 + $2 \* 100 + $3` if test $HAVE_VERSION -ge $NEED_VERSION; then DIRECTFB_CFLAGS=`$DIRECTFBCONFIG --cflags` -Index: SDL-1.2.15/configure -=================================================================== ---- SDL-1.2.15.orig/configure -+++ SDL-1.2.15/configure -@@ -24958,7 +24958,7 @@ - else - set -- `echo $DIRECTFB_REQUIRED_VERSION | sed 's/\./ /g'` - NEED_VERSION=`expr $1 \* 10000 + $2 \* 100 + $3` -- set -- `directfb-config --version | sed 's/\./ /g'` -+ set -- `$DIRECTFBCONFIG --version | sed 's/\./ /g'` - HAVE_VERSION=`expr $1 \* 10000 + $2 \* 100 + $3` - if test $HAVE_VERSION -ge $NEED_VERSION; then - DIRECTFB_CFLAGS=`$DIRECTFBCONFIG --cflags` +
Signature · 1 line
1.8.5.3
PATCH v5 1/5 sdl: fix autoreconf timing issue
Obviously, you may discard this.
I counted one patch too many.. Sorry about the noise. I have removed the patch from the patchwork.
Quoted 83 lines · Maxime Hadjinlian
Context:
The autobuilders were failing on the symbol_XData32being in conflicts. A patch had been added to SDL to add a check to the configure.inProblem:
Sometimes, the build would fail, because of an_XData32symbol being in conflicts eventhrough the patch was here.What was happening:
Following the classic buildroot workflow:
- Extract
- [...]
- Apply 001 patch, which touches configure.in AND configure
- Apply 002 patch, which touches configure.in
- Invokeautogen.sh
- [...]Right before running
autogen.sh, we have configure.in which is more recent than configure, which is fine.
We then, executeautogen.shwhich, basically, runs autoconf.If your machine was lighty loaded, the time difference between configure.in and configure was really tiny (ms order), which seems to be neglected by autoconf.
The results was that the configure was *NOT* generated. And our second patch was taken into account.If your machine was under heavy load, the time difference between the two files would have been greater and then *maybe* picked up by autoconf. And then the configure file was re-generated.
When the 0001 patch was introduced, SDL package did *NOT* run it's
autogen.sh, which is why it touches also the configure. This came later, causing this behavior.Fixes:
http://autobuild.buildroot.net/results/d1c/d1c36f634dbf6b6e5d18444c2a23dfd129202b80/Signed-off-by Maxime Hadjinlian <[email protected]>--- .../sdl/sdl-0001-use-correct-directfb-config.patch | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-)package/sdl/sdl-0001-use-correct-directfb-config.patch +2
-18@@ -4,13 +4,10 @@ The configure script has just checked for the correct directfb-config script, so also use it for the version check instead of whatever might be in the path. -Also patch the generated configure, as it doesn't cleanly autoreconf. - Signed-off-by: Peter Korsgaard <[email protected]> --- - configure | 2 +- configure.in | 2 +- - 2 files changed, 2 insertions(+), 2 deletions(-) + 1 files changed, 1 insertions(+), 1 deletions(-) Index: SDL-1.2.15/configure.in ===================================================================@@ -25,16 +22,4 @@ Index: SDL-1.2.15/configure.in HAVE_VERSION=`expr $1 \* 10000 + $2 \* 100 + $3` if test $HAVE_VERSION -ge $NEED_VERSION; then DIRECTFB_CFLAGS=`$DIRECTFBCONFIG --cflags` -Index: SDL-1.2.15/configure -=================================================================== ---- SDL-1.2.15.orig/configure -+++ SDL-1.2.15/configure -@@ -24958,7 +24958,7 @@ - else - set -- `echo $DIRECTFB_REQUIRED_VERSION | sed 's/\./ /g'` - NEED_VERSION=`expr $1 \* 10000 + $2 \* 100 + $3` -- set -- `directfb-config --version | sed 's/\./ /g'` -+ set -- `$DIRECTFBCONFIG --version | sed 's/\./ /g'` - HAVE_VERSION=`expr $1 \* 10000 + $2 \* 100 + $3` - if test $HAVE_VERSION -ge $NEED_VERSION; then - DIRECTFB_CFLAGS=`$DIRECTFBCONFIG --cflags` + --1.8.5.3
PATCH v5 2/5 sdl: add host version
In reply to Maxime HadjinlianHost version is needed to build xbmc
---
Changes v3 -> v4:
- None
Changes v2 -> v3:
- None
Changes v1 -> v2:
- None
--- package/sdl/sdl.mk | 2 ++ 1 file changed, 2 insertions(+)
package/sdl/sdl.mk +2 -0
@@ -18,6 +18,7 @@ define SDL_RUN_AUTOGEN endef SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN +HOST_SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN SDL_DEPENDENCIES += host-automake host-autoconf host-libtool
@@ -80,3 +81,4 @@ endef SDL_POST_INSTALL_STAGING_HOOKS += SDL_FIXUP_SDL_CONFIG $(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
1.8.5.3
PATCH v5 3/5 sdl_image: add host version
In reply to Maxime HadjinlianHost version is needed to build xbmc
---
Changes v3 -> v4:
- None
Changes v2 -> v3:
- None
Changes v1 -> v2:
- None
--- package/sdl_image/sdl_image.mk | 11 +++++++++++ 1 file changed, 11 insertions(+)
package/sdl_image/sdl_image.mk +11 -0
@@ -38,4 +38,15 @@ SDL_IMAGE_DEPENDENCIES = sdl \ $(if $(BR2_PACKAGE_SDL_IMAGE_TIFF),tiff) \ $(if $(BR2_PACKAGE_SDL_IMAGE_WEBP),webp) +HOST_SDL_IMAGE_CONF_OPT = --with-sdl-prefix=$(HOST_DIR)/usr \ + --with-sdl-exec-prefix=$(HOST_DIR)/usr \ + --disable-sdltest \ + --disable-static \ + --disable-jpg-shared \ + --disable-png-shared \ + --disable-tif-shared \ + +HOST_SDL_IMAGE_DEPENDENCIES = host-libjpeg host-libpng host-sdl + $(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
1.8.5.3
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
In reply to Maxime HadjinlianXBMC uses a code-generator which is build in two phases:
In the first phase SWIG is used to parse C++ header files that define the API. SWIG outputs an XML file that contains a complete description of the structure of the API.
In the second phase, the XML file is ingested by a Groovy (Java) program that then creates C++ code that forms the bridge to the scripting language (Python).
The second phase is why we need java on the host.
You can learn more at the XBMC's wiki:
http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_works
--- support/dependencies/dependencies.sh | 10 ++++++++++ 1 file changed, 10 insertions(+)
support/dependencies/dependencies.sh +10 -0
@@ -191,6 +191,16 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then done fi +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then + for prog in java; do + if ! which $prog > /dev/null ; then + echo >&2 + echo "You must install '$prog' on your build machine" >&2 + exit 1 + fi + done +fi + if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then if test ! -f /lib/ld-linux.so.2 ; then echo
Signature · 1 line
1.8.5.3
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
Dear Maxime Hadjinlian,
support/dependencies/dependencies.sh if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then · line 195
Quoted 2 lines · Maxime Hadjinlian
support/dependencies/dependencies.sh +2
-0+if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then + for prog in java; do
Since you're checking for only one program, there's no point in having a loop here. Just do:
if ! which java > /dev/null ; then
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
Hi Thomas, all
Quoted 4 lines · Thomas Petazzoni
Dear Maxime Hadjinlian,
On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote:
Quoted 8 lines
support/dependencies/dependencies.sh if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then · line 195
Quoted 2 lines
support/dependencies/dependencies.sh +2
-0+if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then + for prog in java; doSince you're checking for only one program, there's no point in having a loop here. Just do:
if ! which java >
/dev/null; then
Argh, how could I have missed that :(
Anyway, thank you. I'll resend when there is some review on the XBMC patch.
Quoted 7 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
In reply to Thomas PetazzoniQuoted 4 lines · On Fri, 14 Feb 2014 09:39:30 +0100 Thomas Petazzoni…
Dear Maxime Hadjinlian,
On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote:
Quoted 8 lines
support/dependencies/dependencies.sh if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then · line 195
Quoted 2 lines
support/dependencies/dependencies.sh +2
-0+if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then + for prog in java; doSince you're checking for only one program, there's no point in having a loop here. Just do:
if ! which java >
/dev/null; then
Wasn't there a patch this development session that replaced the use of "which" with a standards compliant command?
Mike
Quoted 4 lines
Thanks,
Thomas
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
Quoted 10 lines · Mike Zick
Quoted 7 lines · On Fri, 14 Feb 2014 09:39:30 +0100 Thomas Petazzoni…
Dear Maxime Hadjinlian,
Quoted 2 lines · Maxime Hadjinlian
support/dependencies/dependencies.sh +2
-0+if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then + for prog in java; do
Quoted 8 lines
Quoted 5 lines
Since you're checking for only one program, there's no point in having a loop here. Just do:
if ! which java >
/dev/null; thenWasn't there a patch this development session that replaced the use of "which" with a standards compliant command?
You are right, you are talking about:
http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/75049/
But as you can see it was never merged.
Maybe this patch should be bumped again ? It seems there was a problem with the aliases the user can set but Arnout had an idea about that.
Quoted 11 lines
Mike
Quoted 4 lines
Thanks,
Thomas
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
In reply to Maxime HadjinlianMaxime,
Quoted 22 lines · Maxime Hadjinlian
XBMC uses a code-generator which is build in two phases:
In the first phase SWIG is used to parse C++ header files that define the API. SWIG outputs an XML file that contains a complete description of the structure of the API.
In the second phase, the XML file is ingested by a Groovy (Java) program that then creates C++ code that forms the bridge to the scripting language (Python).The second phase is why we need java on the host.
You can learn more at the XBMC's wiki:
http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_worksSigned-off-by Maxime Hadjinlian <[email protected]>--- support/dependencies/dependencies.sh | 10 ++++++++++ 1 file changed, 10 insertions(+)support/dependencies/dependencies.sh +0
-0
support/dependencies/dependencies.sh if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then · line 194
Quoted 4 lines
support/dependencies/dependencies.sh +1
-0@@ -191,6 +191,16 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then done fi +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then
would it be better to have something like
if grep -q ^BR2_HOST_NEEDS_JAVA=y $BUILDROOT_CONFIG ; then
so that future packages that require java on the host can use this same tes? I'm thinking something like how the BR2_HOSTARCH_NEEDS_IA32_COMPILER test is used by grub.
support/dependencies/dependencies.sh if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then · line 206
Quoted 13 lines
support/dependencies/dependencies.sh +9
-0+ for prog in java; do + if ! which $prog > /dev/null ; then + echo >&2 + echo "You must install '$prog' on your build machine" >&2 + exit 1 + fi + done +fi + if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then if test ! -f /lib/ld-linux.so.2 ; then echo
Thanks
PATCH v5 4/5 dependencies.sh: XBMC needs java on the host
Hi Martin, all
Quoted 41 lines · Martin Bark
Maxime,
Quoted 32 lines · Maxime Hadjinlian
XBMC uses a code-generator which is build in two phases:
In the first phase SWIG is used to parse C++ header files that define the API.
SWIG outputs an XML file that contains a complete description of the structure
of the API.
In the second phase, the XML file is ingested by a Groovy (Java) program that
then creates C++ code that forms the bridge to the scripting language (Python).The second phase is why we need java on the host.
You can learn more at the XBMC's wiki:
http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_worksSigned-off-by Maxime Hadjinlian <[email protected]>--- support/dependencies/dependencies.sh | 10 ++++++++++ 1 file changed, 10 insertions(+)support/dependencies/dependencies.sh +0
-0@@ -191,6 +191,16 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ;then
done
fiQuoted 1 line
+if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then
would it be better to have something like
Quoted 5 lines
if grep -q ^BR2_HOST_NEEDS_JAVA=y $BUILDROOT_CONFIG ; then
so that future packages that require java on the host can use this same tes? I'm thinking something like how the
BR2_HOSTARCH_NEEDS_IA32_COMPILERtest is used by grub.
I agree with the idea, at the moment we don't have any package that needs Java to be built, but it may be a nice idea to have a mechanisms for such packages in the future.
Quoted 20 lines
Quoted 9 lines
support/dependencies/dependencies.sh +4
-0+ for prog in java; do + if ! which $prog > /dev/null ; then + echo >&2 + echo "You must install '$prog' on your buildmachine" >&2
support/dependencies/dependencies.sh if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then · line 206
Quoted 8 lines
support/dependencies/dependencies.sh +5
-0+ exit 1 + fi + done +fi + if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then if test ! -f /lib/ld-linux.so.2 ; then echoThanks
PATCH v5 5/5 xbmc: new package
In reply to Maxime HadjinlianXBMC is an award-winning free and open source (GPL) software media player and entertainment hub for digital media.
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <[email protected]>
---
Changes v4 -> v5:
- Remove MAKE1, seems to work fine with parallel build.
Changes v3 -> v4:
- Rework init script
- Add systemd startup service
Changes v2 -> v3:
- Fix indent
- Change librtmp to rtmpdump
Changes v1 -> v2:
- Fix header (Yann E. Morin)
- Fix comment on toolchain option (Peter Korsgaard)
--- package/Config.in | 1 + package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ 7 files changed, 677 insertions(+) create mode 100644 package/xbmc/Config.in create mode 100755 package/xbmc/S50xbmc create mode 100644 package/xbmc/xbmc-0001-Fixup-include-path.patch create mode 100644 package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patch create mode 100644 package/xbmc/xbmc.mk create mode 100644 package/xbmc/xbmc.service
package/Config.in +1 -0
@@ -26,6 +26,7 @@ source "package/tstools/Config.in" source "package/vlc/Config.in" source "package/vorbis-tools/Config.in" source "package/wavpack/Config.in" +source "package/xbmc/Config.in" source "package/yavta/Config.in" endmenu
package/xbmc/Config.in new file +202 -0
202 lines not on this page · raw message
package/xbmc/S50xbmc new file +41 -0
41 lines not on this page · raw message
package/xbmc/xbmc-0001-Fixup-include-path.patch new file +79 -0
79 lines not on this page · raw message
package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patch new file +167 -0
167 lines not on this page · raw message
package/xbmc/xbmc.mk new file +175 -0
175 lines not on this page · raw message
package/xbmc/xbmc.service new file +12 -0
@@ -0,0 +1,12 @@ +[Unit] +Description = XBMC media center +After = network.target + +[Service] +Type = simple +ExecStart = /usr/lib/xbmc/xbmc.bin --standalone -fs -n +Restart = on-failure + +[Install] +WantedBy = multi-user.target +
Signature · 1 line
1.8.5.3
PATCH v5 5/5 xbmc: new package
Maxime,
Below are some comments, hope they help.
Quoted 86 lines · Maxime Hadjinlian
XBMC is an award-winning free and open source (GPL) software media player and entertainment hub for digital media.
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <[email protected]>Signed-off-by Maxime Hadjinlian <[email protected]>Cc gimli <[email protected]>---
Changes v4 -> v5:
- Remove MAKE1, seems to work fine with parallel build.
Changes v3 -> v4:
- Rework init script
- Add systemd startup service
Changes v2 -> v3:
- Fix indent
- Change librtmp to rtmpdump
Changes v1 -> v2:
- Fix header (Yann E. Morin)
- Fix comment on toolchain option (Peter Korsgaard)--- package/Config.in | 1 + package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ 7 files changed, 677 insertions(+)create mode 100644 package/xbmc/Config.in
create mode 100755 package/xbmc/S50xbmc
create mode 100644package/xbmc/xbmc-0001-Fixup-include-path.patchcreate mode 100644package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patchcreate mode 100644package/xbmc/xbmc.mk
create mode 100644 package/xbmc/xbmc.servicepackage/Config.in +1
-0@@ -26,6 +26,7 @@ source "package/tstools/Config.in" source "package/vlc/Config.in" source "package/vorbis-tools/Config.in" source "package/wavpack/Config.in" +source "package/xbmc/Config.in" source "package/yavta/Config.in" endmenupackage/xbmc/Config.in new file +33
-0@@ -0,0 +1,202 @@ +comment "xbmc requires an OpenGL-capable backend" + depends on !(BR2_PACKAGE_HAS_OPENGL_EGL && BR2_PACKAGE_HAS_OPENGL_ES) + +# External toolchain are required because of a missing bitdefs.h +comment "xbmc needs an (e)glibc external toolchain w/ C++ and WCHAR" + depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR) || BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_BUILDROOT + +menuconfig BR2_PACKAGE_XBMC + bool "xbmc" + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_THREAD + select BR2_PACKAGE_BZIP2 + select BR2_PACKAGE_EXPAT + select BR2_PACKAGE_JASPER + select BR2_PACKAGE_LIBCDIO + select BR2_PACKAGE_LIBCURL + select BR2_PACKAGE_LIBFRIBIDI + select BR2_PACKAGE_LIBGCRYPT + select BR2_PACKAGE_LIBMODPLUG + select BR2_PACKAGE_LIBMPEG2 + select BR2_PACKAGE_LIBUNGIF + select BR2_PACKAGE_LZO + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON_BSDDB + select BR2_PACKAGE_PYTHON_BZIP2 + select BR2_PACKAGE_PYTHON_CURSES + select BR2_PACKAGE_PYTHON_PYEXPAT + select BR2_PACKAGE_PYTHON_READLINE + select BR2_PACKAGE_PYTHON_SQLITE + select BR2_PACKAGE_PYTHON_SSL + select BR2_PACKAGE_PYTHON_UNICODEDATA
package/xbmc/Config.in line 43
Quoted 10 lines
package/xbmc/Config.in new file +10
-0+ select BR2_PACKAGE_PYTHON_ZLIB + select BR2_PACKAGE_READLINE + select BR2_PACKAGE_SQLITE + select BR2_PACKAGE_TAGLIB + select BR2_PACKAGE_TIFF + select BR2_PACKAGE_TINYXML + select BR2_PACKAGE_YAJL + select BR2_PACKAGE_ZLIB + depends on BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && !BR2_TOOLCHAIN_USES_UCLIBC + depends on !BR2_TOOLCHAIN_BUILDROOT
I think you have missed the following
depends on BR2_PACKAGE_HAS_OPENGL_EGL && BR2_PACKAGE_HAS_OPENGL_ES
Currently you can compile xbmc without any opengl support and it just fails at the configure step.
-- snip --
Quoted 7 lines
package/xbmc/xbmc.mk new file +1
-0@@ -0,0 +1,175 @@ +################################################################################
package/xbmc/xbmc.mk line 11
Quoted 10 lines
package/xbmc/xbmc.mk new file +10
-0+# +# xbmc +# +################################################################################ + +XBMC_VERSION = 12.3-Frodo +XBMC_SITE = $(call github,xbmc,xbmc,$(XBMC_VERSION)) +XBMC_LICENSE = GPLv2 +XBMC_LICENSE_FILES = LICENSE.GPL +XBMC_DEPENDENCIES = host-lzo host-sdl_image host-swig
I think you need to add host-gperf, i had to add this for xmbc to compile.
package/xbmc/xbmc.mk line 15
Quoted 4 lines
package/xbmc/xbmc.mk new file +4
-0+XBMC_DEPENDENCIES += libmpeg2 bzip2 libcdio python lzo zlib libgcrypt openssl \ + sqlite fontconfig freetype jasper jpeg libmodplug libpng libungif tiff \ + libcurl boost libfribidi ncurses pcre libplist readline expat libxml2 yajl \ + tinyxml taglib
The config.in does not select fontconfig, freetype, jpeg, libpng, tiff, ncurses, libplist and libxml2 but you specify them as dependencies. Are these really dependencies? Should config.in select them?
Quoted 7 lines
package/xbmc/xbmc.mk new file +7
-0+ +XBMC_CONF_ENV += PYTHON_VERSION="$(PYTHON_VERSION_MAJOR)" +XBMC_CONF_ENV += PYTHON_LDFLAGS="-L$(STAGING_DIR)/usr/lib/ -lpython$(PYTHON_VERSION_MAJOR) -lpthread -ldl -lutil -lm" +XBMC_CONF_ENV += PYTHON_CPPFLAGS="-I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)" +XBMC_CONF_ENV += PYTHON_SITE_PKG="$(STAGING_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages" +XBMC_CONF_ENV += PYTHON_NOVERSIONCHECK="no-check" +XBMC_CONF_ENV += TEXTUREPACKER_NATIVE_ROOT="$(HOST_DIR)/usr"
package/xbmc/xbmc.mk line 32
Quoted 10 lines
package/xbmc/xbmc.mk new file +10
-0+ +XBMC_CONF_OPT += --disable-sdl --disable-x11 --disable-xrandr --disable-openmax \ + --disable-optical-drive --disable-dvdcss --disable-joystick \ + --disable-debug --disable-crystalhd --disable-vtbdecoder --disable-vaapi \ + --disable-vdpau --disable-pulse --disable-projectm --enable-optimizations \ + --disable-alsa --disable-ssh --disable-hal --disable-mysql + +ifeq ($(BR2_arm),y) +XBMC_CONF_OPT += --enable-gles --disable-gl +endif
Should this be ifeq ($(BR2_PACKAGE_HAS_OPENGL_EGL),y) ? If xbmc requires on opengl is this test even needed ?
Thanks
Martin
PATCH v5 5/5 xbmc: new package
Hi Martin, all
Quoted 116 lines · Martin Bark
Maxime,
Below are some comments, hope they help.
Quoted 104 lines · Maxime Hadjinlian
XBMC is an award-winning free and open source (GPL) software media player and
entertainment hub for digital media.
This package was originally found at :
https://github.com/huceke/buildroot-rbp
By gimli <[email protected]>Signed-off-by Maxime Hadjinlian <[email protected]>Cc gimli <[email protected]>---
Changes v4 -> v5:
- Remove MAKE1, seems to work fine with parallel build.
Changes v3 -> v4:
- Rework init script
- Add systemd startup service
Changes v2 -> v3:
- Fix indent
- Change librtmp to rtmpdump
Changes v1 -> v2:
- Fix header (Yann E. Morin)
- Fix comment on toolchain option (Peter Korsgaard)--- package/Config.in | 1 + package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ 7 files changed, 677 insertions(+)create mode 100644 package/xbmc/Config.in
create mode 100755 package/xbmc/S50xbmc
create mode 100644package/xbmc/xbmc-0001-Fixup-include-path.patchcreate mode 100644package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patch
create mode 100644package/xbmc/xbmc.mk
create mode 100644 package/xbmc/xbmc.servicepackage/Config.in +1
-0@@ -26,6 +26,7 @@ source "package/tstools/Config.in" source "package/vlc/Config.in" source "package/vorbis-tools/Config.in" source "package/wavpack/Config.in" +source "package/xbmc/Config.in" source "package/yavta/Config.in" endmenupackage/xbmc/Config.in new file +2
-0@@ -0,0 +1,202 @@ +comment "xbmc requires an OpenGL-capable backend" + depends on !(BR2_PACKAGE_HAS_OPENGL_EGL &&
BR2_PACKAGE_HAS_OPENGL_ES)package/xbmc/Config.in new file +4
-0+ +# External toolchain are required because of a missing bitdefs.h +comment "xbmc needs an (e)glibc external toolchain w/ C++ and WCHAR" + depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR) ||
BR2_TOOLCHAIN_USES_UCLIBC||BR2_TOOLCHAIN_BUILDROOTpackage/xbmc/Config.in new file +36
-0+ +menuconfig BR2_PACKAGE_XBMC + bool "xbmc" + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_THREAD + select BR2_PACKAGE_BZIP2 + select BR2_PACKAGE_EXPAT + select BR2_PACKAGE_JASPER + select BR2_PACKAGE_LIBCDIO + select BR2_PACKAGE_LIBCURL + select BR2_PACKAGE_LIBFRIBIDI + select BR2_PACKAGE_LIBGCRYPT + select BR2_PACKAGE_LIBMODPLUG + select BR2_PACKAGE_LIBMPEG2 + select BR2_PACKAGE_LIBUNGIF + select BR2_PACKAGE_LZO + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON_BSDDB + select BR2_PACKAGE_PYTHON_BZIP2 + select BR2_PACKAGE_PYTHON_CURSES + select BR2_PACKAGE_PYTHON_PYEXPAT + select BR2_PACKAGE_PYTHON_READLINE + select BR2_PACKAGE_PYTHON_SQLITE + select BR2_PACKAGE_PYTHON_SSL + select BR2_PACKAGE_PYTHON_UNICODEDATA + select BR2_PACKAGE_PYTHON_ZLIB + select BR2_PACKAGE_READLINE + select BR2_PACKAGE_SQLITE + select BR2_PACKAGE_TAGLIB + select BR2_PACKAGE_TIFF + select BR2_PACKAGE_TINYXML + select BR2_PACKAGE_YAJL + select BR2_PACKAGE_ZLIB + depends on BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR &&Quoted 2 lines
!BR2_TOOLCHAIN_USES_UCLIBC
+ depends on !BR2_TOOLCHAIN_BUILDROOTI think you have missed the following
Quoted 2 lines
depends on BR2_PACKAGE_HAS_OPENGL_EGL && BR2_PACKAGE_HAS_OPENGL_ES
Well, I have omitted it because it causes a recursive dependency with the rpi packages and I did not know how to fix this, so I kinda hoped for someone to come up with a better solution :).
Quoted 2 lines
Currently you can compile xbmc without any opengl support and it just fails at the configure step.
True, I did not really expand my test here. I shall do that.
Quoted 16 lines
-- snip --
Quoted 12 lines
package/xbmc/xbmc.mk new file +4
-0@@ -0,0 +1,175 @@ +################################################################################ +# +# xbmc +#
Quoted 10 lines
package/xbmc/xbmc.mk line 11
Quoted 7 lines
package/xbmc/xbmc.mk new file +7
-0+################################################################################ + +XBMC_VERSION = 12.3-Frodo +XBMC_SITE = $(call github,xbmc,xbmc,$(XBMC_VERSION)) +XBMC_LICENSE = GPLv2 +XBMC_LICENSE_FILES = LICENSE.GPL +XBMC_DEPENDENCIES = host-lzo host-sdl_image host-swigI think you need to add host-gperf, i had to add this for xmbc to compile.
host-gperf ? I never needed that, why should it be needed ?
Quoted 11 lines
Quoted 9 lines
+XBMC_DEPENDENCIES += libmpeg2 bzip2 libcdio python lzo zlib libgcrypt openssl \
+ sqlite fontconfig freetype jasper jpeg libmodplug libpng libungif
tiff \
+ libcurl boost libfribidi ncurses pcre libplist readline expat
libxml2 yajl \
+ tinyxml taglib
Quoted 3 lines
The config.in does not select fontconfig, freetype, jpeg, libpng, tiff, ncurses, libplist and libxml2 but you specify them as dependencies. Are these really dependencies? Should config.in select them?
Yes they are dependencies, and you are right, they should be selected in Config.in, I'll fix this.
Quoted 21 lines
Quoted 21 lines
package/xbmc/xbmc.mk new file +4
-1+ +XBMC_CONF_ENV += PYTHON_VERSION="$(PYTHON_VERSION_MAJOR)" +XBMC_CONF_ENV += PYTHON_LDFLAGS="-L$(STAGING_DIR)/usr/lib/ -lpython$(PYTHON_VERSION_MAJOR) -lpthread -ldl -lutil -lm" +XBMC_CONF_ENV +=PYTHON_CPPFLAGS="-I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)" +XBMC_CONF_ENV += PYTHON_SITE_PKG="$(STAGING_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages"
package/xbmc/xbmc.mk new file +8
-3+XBMC_CONF_ENV += PYTHON_NOVERSIONCHECK="no-check" +XBMC_CONF_ENV += TEXTUREPACKER_NATIVE_ROOT="$(HOST_DIR)/usr" + +XBMC_CONF_OPT += --disable-sdl --disable-x11 --disable-xrandr --disable-openmax \ + --disable-optical-drive --disable-dvdcss --disable-joystick \ + --disable-debug --disable-crystalhd --disable-vtbdecoder --disable-vaapi \ + --disable-vdpau --disable-pulse --disable-projectm --enable-optimizations \ + --disable-alsa --disable-ssh --disable-hal --disable-mysql
Quoted 8 lines
package/xbmc/xbmc.mk line 32
Quoted 4 lines
package/xbmc/xbmc.mk new file +4
-0+ +ifeq ($(BR2_arm),y) +XBMC_CONF_OPT += --enable-gles --disable-gl +endifShould this be ifeq ($(BR2_PACKAGE_HAS_OPENGL_EGL),y) ? If xbmc requires on opengl is this test even needed ?
True, when I wrote this patch, this variable did not exists and I forgot to change it. I'll look into it.
Quoted 4 lines
Thanks
Martin
Thanks for your review and comments.
PATCH v5 5/5 xbmc: new package
Hi Martin, all
Quoted 118 lines · Maxime Hadjinlian
Hi Martin, all
Quoted 116 lines · Martin Bark
Maxime,
Below are some comments, hope they help.
Quoted 104 lines · Maxime Hadjinlian
XBMC is an award-winning free and open source (GPL) software media player and
entertainment hub for digital media.
This package was originally found at :
https://github.com/huceke/buildroot-rbp
By gimli <[email protected]>Signed-off-by Maxime Hadjinlian <[email protected]>Cc gimli <[email protected]>---
Changes v4 -> v5:
- Remove MAKE1, seems to work fine with parallel build.
Changes v3 -> v4:
- Rework init script
- Add systemd startup service
Changes v2 -> v3:
- Fix indent
- Change librtmp to rtmpdump
Changes v1 -> v2:
- Fix header (Yann E. Morin)
- Fix comment on toolchain option (Peter Korsgaard)--- package/Config.in | 1 + package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ 7 files changed, 677 insertions(+)create mode 100644 package/xbmc/Config.in
create mode 100755 package/xbmc/S50xbmc
create mode 100644package/xbmc/xbmc-0001-Fixup-include-path.patchcreate mode 100644package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patch
create mode 100644package/xbmc/xbmc.mk
create mode 100644 package/xbmc/xbmc.servicepackage/Config.in +1
-0@@ -26,6 +26,7 @@ source "package/tstools/Config.in" source "package/vlc/Config.in" source "package/vorbis-tools/Config.in" source "package/wavpack/Config.in" +source "package/xbmc/Config.in" source "package/yavta/Config.in" endmenupackage/xbmc/Config.in new file +2
-0@@ -0,0 +1,202 @@ +comment "xbmc requires an OpenGL-capable backend" + depends on !(BR2_PACKAGE_HAS_OPENGL_EGL &&
BR2_PACKAGE_HAS_OPENGL_ES)package/xbmc/Config.in new file +4
-0+ +# External toolchain are required because of a missing bitdefs.h +comment "xbmc needs an (e)glibc external toolchain w/ C++ and WCHAR" + depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR) ||
BR2_TOOLCHAIN_USES_UCLIBC||BR2_TOOLCHAIN_BUILDROOTpackage/xbmc/Config.in new file +36
-0+ +menuconfig BR2_PACKAGE_XBMC + bool "xbmc" + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_THREAD + select BR2_PACKAGE_BZIP2 + select BR2_PACKAGE_EXPAT + select BR2_PACKAGE_JASPER + select BR2_PACKAGE_LIBCDIO + select BR2_PACKAGE_LIBCURL + select BR2_PACKAGE_LIBFRIBIDI + select BR2_PACKAGE_LIBGCRYPT + select BR2_PACKAGE_LIBMODPLUG + select BR2_PACKAGE_LIBMPEG2 + select BR2_PACKAGE_LIBUNGIF + select BR2_PACKAGE_LZO + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_PCRE + select BR2_PACKAGE_PYTHON + select BR2_PACKAGE_PYTHON_BSDDB + select BR2_PACKAGE_PYTHON_BZIP2 + select BR2_PACKAGE_PYTHON_CURSES + select BR2_PACKAGE_PYTHON_PYEXPAT + select BR2_PACKAGE_PYTHON_READLINE + select BR2_PACKAGE_PYTHON_SQLITE + select BR2_PACKAGE_PYTHON_SSL + select BR2_PACKAGE_PYTHON_UNICODEDATA + select BR2_PACKAGE_PYTHON_ZLIB + select BR2_PACKAGE_READLINE + select BR2_PACKAGE_SQLITE + select BR2_PACKAGE_TAGLIB + select BR2_PACKAGE_TIFF + select BR2_PACKAGE_TINYXML + select BR2_PACKAGE_YAJL + select BR2_PACKAGE_ZLIB + depends on BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR &&Quoted 2 lines
!BR2_TOOLCHAIN_USES_UCLIBC
+ depends on !BR2_TOOLCHAIN_BUILDROOTI think you have missed the following
Quoted 8 lines
Quoted 2 lines
depends on BR2_PACKAGE_HAS_OPENGL_EGL && BR2_PACKAGE_HAS_OPENGL_ESWell, I have omitted it because it causes a recursive dependency with the rpi packages and I did not know how to fix this, so I kinda hoped for someone to come up with a better solution :).
Quoted 2 lines
Currently you can compile xbmc without any opengl support and it just fails at the configure step.
True, I did not really expand my test here. I shall do that.
My answers were a bit hastly, so after a bit of research. XBMC can compile without OpenGL support, it'll be really really slow, but you can.
So it could even not depend on this at all, only take advantage of it if you enabled an OPENGL backend.
I should modify to take this into account.
Quoted 79 lines
Quoted 16 lines
-- snip --
Quoted 12 lines
package/xbmc/xbmc.mk new file +4
-0@@ -0,0 +1,175 @@ +################################################################################ +# +# xbmc +#Quoted 10 lines
package/xbmc/xbmc.mk line 11
Quoted 7 lines
package/xbmc/xbmc.mk new file +7
-0+################################################################################ + +XBMC_VERSION = 12.3-Frodo +XBMC_SITE = $(call github,xbmc,xbmc,$(XBMC_VERSION)) +XBMC_LICENSE = GPLv2 +XBMC_LICENSE_FILES = LICENSE.GPL +XBMC_DEPENDENCIES = host-lzo host-sdl_image host-swigI think you need to add host-gperf, i had to add this for xmbc to compile.
host-gperf ? I never needed that, why should it be needed ?
Quoted 11 lines
Quoted 9 lines
+XBMC_DEPENDENCIES += libmpeg2 bzip2 libcdio python lzo zlib libgcrypt openssl \
+ sqlite fontconfig freetype jasper jpeg libmodplug libpng libungif
tiff \
+ libcurl boost libfribidi ncurses pcre libplist readline expat
libxml2 yajl \
+ tinyxml taglibQuoted 3 lines
The config.in does not select fontconfig, freetype, jpeg, libpng, tiff, ncurses, libplist and libxml2 but you specify them as dependencies. Are these really dependencies? Should config.in select them?
Yes they are dependencies, and you are right, they should be selected in Config.in, I'll fix this.
Quoted 21 lines
Quoted 21 lines
package/xbmc/xbmc.mk new file +4
-1+ +XBMC_CONF_ENV += PYTHON_VERSION="$(PYTHON_VERSION_MAJOR)" +XBMC_CONF_ENV += PYTHON_LDFLAGS="-L$(STAGING_DIR)/usr/lib/ -lpython$(PYTHON_VERSION_MAJOR) -lpthread -ldl -lutil -lm" +XBMC_CONF_ENV +=PYTHON_CPPFLAGS="-I$(STAGING_DIR)/usr/include/python$(PYTHON_VERSION_MAJOR)" +XBMC_CONF_ENV += PYTHON_SITE_PKG="$(STAGING_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages"
package/xbmc/xbmc.mk new file +8
-3+XBMC_CONF_ENV += PYTHON_NOVERSIONCHECK="no-check" +XBMC_CONF_ENV += TEXTUREPACKER_NATIVE_ROOT="$(HOST_DIR)/usr" + +XBMC_CONF_OPT += --disable-sdl --disable-x11 --disable-xrandr --disable-openmax \ + --disable-optical-drive --disable-dvdcss --disable-joystick \ + --disable-debug --disable-crystalhd --disable-vtbdecoder --disable-vaapi \ + --disable-vdpau --disable-pulse --disable-projectm --enable-optimizations \ + --disable-alsa --disable-ssh --disable-hal --disable-mysqlQuoted 8 lines
package/xbmc/xbmc.mk line 32
Quoted 4 lines
package/xbmc/xbmc.mk new file +4
-0+ +ifeq ($(BR2_arm),y) +XBMC_CONF_OPT += --enable-gles --disable-gl +endifShould this be ifeq ($(BR2_PACKAGE_HAS_OPENGL_EGL),y) ? If xbmc requires on opengl is this test even needed ?
True, when I wrote this patch, this variable did not exists and I forgot to change it. I'll look into it.
Quoted 4 lines
Thanks
Martin
Thanks for your review and comments.
PATCH v5 5/5 xbmc: new package
In reply to Maxime HadjinlianMaxime,
Sorry for the late replay
On 14/02/14 23:51, Maxime Hadjinlian wrote:
-- snip --
Quoted 24 lines
Quoted 14 lines
Quoted 14 lines
package/xbmc/xbmc.mk new file +4
-0@@ -0,0 +1,175 @@ +################################################################################ +# +# xbmc +#Quoted 10 lines
package/xbmc/xbmc.mk line 11
Quoted 7 lines
package/xbmc/xbmc.mk new file +7
-0+################################################################################ + +XBMC_VERSION = 12.3-Frodo +XBMC_SITE = $(call github,xbmc,xbmc,$(XBMC_VERSION)) +XBMC_LICENSE = GPLv2 +XBMC_LICENSE_FILES = LICENSE.GPL +XBMC_DEPENDENCIES = host-lzo host-sdl_image host-swigI think you need to add host-gperf, i had to add this for xmbc to compile.
Quoted 1 line
host-gperf ? I never needed that, why should it be needed ?
I just verified and xmbc does fails to build for me because i'm missing gpref. I checked and the configure script tests for gpref and errors if it's missing. The machine i'm building on does not have gperf installed. Either adding host-gpref or patching configure.in to remove the tests for gpref fixed this issue. I think probably patching configure.in is a better solution.
Thanks
PATCH v5 5/5 xbmc: new package
Quoted 41 lines · Martin Bark
Maxime,
Sorry for the late replay
On 14/02/14 23:51, Maxime Hadjinlian wrote:
-- snip --
Quoted 29 lines
Quoted 16 lines
Quoted 16 lines
package/xbmc/xbmc.mk new file +4
-0@@ -0,0 +1,175 @@ +################################################################################ +# +# xbmc +#Quoted 12 lines
package/xbmc/xbmc.mk line 11
Quoted 7 lines
package/xbmc/xbmc.mk new file +7
-0+################################################################################ + +XBMC_VERSION = 12.3-Frodo +XBMC_SITE = $(call github,xbmc,xbmc,$(XBMC_VERSION)) +XBMC_LICENSE = GPLv2 +XBMC_LICENSE_FILES = LICENSE.GPL +XBMC_DEPENDENCIES = host-lzo host-sdl_image host-swigI think you need to add host-gperf, i had to add this for xmbc to compile.
Quoted 1 line
host-gperf ? I never needed that, why should it be needed ?
Quoted 6 lines
I just verified and xmbc does fails to build for me because i'm missing gpref. I checked and the configure script tests for gpref and errors if it's missing. The machine i'm building on does not have gperf installed. Either adding host-gpref or patching configure.in to remove the tests for gpref fixed this issue. I think probably patching configure.in is a better solution.
Okay, I must have it on my system, that's why I never noticed. I'll add it to the dependency then.
Why do you think patching the configure.in would be better ? It seems to me that it would add another patch to maintain, which would never go mainline, if they search for it in their configure, they must need it somehow.
Quoted 2 lines
Thanks
Thank you
PATCH v5 5/5 xbmc: new package
Maxime,
Quoted 48 lines · Maxime Hadjinlian
Quoted 41 lines · Martin Bark
Maxime,
Sorry for the late replay
On 14/02/14 23:51, Maxime Hadjinlian wrote:
-- snip --
Quoted 29 lines
Quoted 16 lines
Quoted 16 lines
package/xbmc/xbmc.mk new file +4
-0@@ -0,0 +1,175 @@ +################################################################################ +# +# xbmc +#Quoted 12 lines
package/xbmc/xbmc.mk line 11
Quoted 7 lines
package/xbmc/xbmc.mk new file +7
-0+################################################################################ + +XBMC_VERSION = 12.3-Frodo +XBMC_SITE = $(call github,xbmc,xbmc,$(XBMC_VERSION)) +XBMC_LICENSE = GPLv2 +XBMC_LICENSE_FILES = LICENSE.GPL +XBMC_DEPENDENCIES = host-lzo host-sdl_image host-swigI think you need to add host-gperf, i had to add this for xmbc to compile.
Quoted 1 line
host-gperf ? I never needed that, why should it be needed ?
Quoted 6 lines
I just verified and xmbc does fails to build for me because i'm missing gpref. I checked and the configure script tests for gpref and errors if it's missing. The machine i'm building on does not have gperf installed. Either adding host-gpref or patching configure.in to remove the tests for gpref fixed this issue. I think probably patching configure.in is a better solution.
Quoted 6 lines
Okay, I must have it on my system, that's why I never noticed. I'll add it to the dependency then.
Why do you think patching the configure.in would be better ? It seems to me that it would add another patch to maintain, which would never go mainline, if they search for it in their configure, they must need it somehow.
Well the readme's mention gpref as as build dependency and configure tests for it but i can't see that it's used. However, you're right it's another patch to maintain so adding host-gperf would be simpler.
Quoted 4 lines
Quoted 2 lines
Thanks
Thank you
PATCH v5 5/5 xbmc: new package
In reply to Maxime HadjinlianMaxime, All,
On 2014-02-13 23:59 +0100, Maxime Hadjinlian spake thusly:
Quoted 2 lines
XBMC is an award-winning free and open source (GPL) software media player and entertainment hub for digital media.
Just a quick comment before I forget...
Hopefully I'll have some more time for a proper review later today...
[--SNIP--]
package/xbmc/Config.in line 102
Quoted 6 lines
package/xbmc/Config.in new file +6
-0+config BR2_PACKAGE_XBMC_LIBCEC_RBP + bool "rpi support" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_LARGEFILE + select BR2_PACKAGE_RPI_USERLAND + select BR2_PACKAGE_LIBCEC_RBP
git grep BR2_PACKAGE_LIBCEC_RBP
--> nothing... ?
package/xbmc/Config.in line 109
Quoted 7 lines
package/xbmc/Config.in new file +7
-0+ help + Enable RasberryPi support + +comment "rpi support requires a toolchain with C++ and LARGEFILE support" + depends on !(BR2_INSTALL_LIBSTDCPP && BR2_LARGEFILE) + +endif
If rpi-userland is selected, then just assume RPi support is wanted. This should get rid of the circular dependency on EGL/GLES you mentioned later.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v5 5/5 xbmc: new package
Hi Yann, all
Quoted 17 lines · Yann E. MORIN
Maxime, All,
On 2014-02-13 23:59 +0100, Maxime Hadjinlian spake thusly:
Quoted 2 lines
XBMC is an award-winning free and open source (GPL) software media player and entertainment hub for digital media.
Just a quick comment before I forget...
Hopefully I'll have some more time for a proper review later today...[--SNIP--]
package/xbmc/Config.in line 102
Quoted 6 lines
package/xbmc/Config.in new file +6
-0+config BR2_PACKAGE_XBMC_LIBCEC_RBP + bool "rpi support" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_LARGEFILE + select BR2_PACKAGE_RPI_USERLAND + select BR2_PACKAGE_LIBCEC_RBP
Quoted 2 lines
git grep
BR2_PACKAGE_LIBCEC_RBP
--> nothing... ?
Ouch ! Forgot to modify this... When I added libcec initially, there was a specific choice for the RBP which was removed and then if rpi-userland was selected, take advantage of it.
Quoted 12 lines
package/xbmc/Config.in line 109
Quoted 8 lines
package/xbmc/Config.in new file +7
-0+ help + Enable RasberryPi support + +comment "rpi support requires a toolchain with C++ and LARGEFILE support" + depends on !(BR2_INSTALL_LIBSTDCPP && BR2_LARGEFILE) + +endifIf rpi-userland is selected, then just assume RPi support is wanted. This should get rid of the circular dependency on EGL/GLES you mentioned later.
Make sense, I will look into it.
Quoted 3 lines
Regards,
Yann E. MORIN.
Thanks
Quoted 8 lines
--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
v5 cover Introducing XBMC
In reply to Maxime HadjinlianMaxime Hadjinlian
<[email protected]> wrote in news:1392332394-27935-1-git-send-email-maxime.hadjinlian at gmail.com:
Quoted 3 lines
Also, the $(MAKE1) for XBMC has been removed. After doing a loop of 50 builds and no trouble so far to report, I assumed it was safe, at least for now.
Hi,
I had never any problems compiling XBMC with nine parallel jobs, so ACK.
Regards, Bernd
v5 cover Introducing XBMC
In reply to Maxime HadjinlianMaxime,
I just tried out you patch set. Initially i tried a simple defconfig as follows and this failed when configuring xbmc
BR2_arm=y
BR2_arm1176jzf_s=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XBMC=y
BR2_PACKAGE_RPI_USERLAND=y
The xmbc configure script was moaning about missing dependencies. To get the code to build I?m the end i had to enable the following:
BR2_PACKAGE_XBMC_FLAC=y
BR2_PACKAGE_XBMC_LIBASS=y
BR2_PACKAGE_XBMC_LIBSAMPLERATE=y
BR2_PACKAGE_XBMC_MAD=y
BR2_PACKAGE_XBMC_VORBIS=y
Perhaps you could check these option, maybe they need to be selected by default.
Thanks
Quoted 44 lines · Maxime Hadjinlian
Hi all,
This is a new version of the series of patch introducing XBMC.
A new one appeared, which add the dependencies of Java on the host machine for XBMC.
Also, the $(MAKE1) for XBMC has been removed. After doing a loop of 50 builds and no trouble so far to report, I assumed it was safe, at least for now.As always, I wait for your reviews and comments !
Maxime Hadjinlian (5):
sdl: fix autoreconf timing issue
sdl: add host version
sdl_image: add host version
dependencies.sh: XBMC needs java on the host
xbmc: new packagepackage/Config.in | 1 + .../sdl/sdl-0001-use-correct-directfb-config.patch | 19 +- package/sdl/sdl.mk | 2 + package/sdl_image/sdl_image.mk | 11 ++ package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ support/dependencies/dependencies.sh | 10 + 11 files changed, 702 insertions(+), 17 deletions(-)create mode 100644 package/xbmc/Config.in
create mode 100755 package/xbmc/S50xbmc
create mode 100644package/xbmc/xbmc-0001-Fixup-include-path.patchcreate mode 100644package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patchcreate mode 100644package/xbmc/xbmc.mk
create mode 100644 package/xbmc/xbmc.service--
1.8.5.3_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
v5 cover Introducing XBMC
Hi Martin, all
Quoted 15 lines · Martin Bark
Maxime,
I just tried out you patch set. Initially i tried a simple defconfig as follows and this failed when configuring xbmc
BR2_arm=y
BR2_arm1176jzf_s=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_XBMC=y
BR2_PACKAGE_RPI_USERLAND=yThe xmbc configure script was moaning about missing dependencies. To get the code to build I?m the end i had to enable the following:
Quoted 8 lines
BR2_PACKAGE_XBMC_FLAC=y
BR2_PACKAGE_XBMC_LIBASS=y
BR2_PACKAGE_XBMC_LIBSAMPLERATE=y
BR2_PACKAGE_XBMC_MAD=y
BR2_PACKAGE_XBMC_VORBIS=yPerhaps you could check these option, maybe they need to be selected by default.
I will look into it. They don't need to be selected by default, they should be disabled if not selected in menuconfig.
Quoted 2 lines
Thanks
Thanks for spotting this.
Quoted 56 lines · Maxime Hadjinlian
Quoted 51 lines
Hi all,
This is a new version of the series of patch introducing XBMC. A new one appeared, which add the dependencies of Java on the host machine for
XBMC.
Also, the $(MAKE1) for XBMC has been removed. After doing a loop of 50 builds
and no trouble so far to report, I assumed it was safe, at least for now.As always, I wait for your reviews and comments !
Maxime Hadjinlian (5):
sdl: fix autoreconf timing issue
sdl: add host version
sdl_image: add host version
dependencies.sh: XBMC needs java on the host
xbmc: new packagepackage/Config.in | 1 + .../sdl/sdl-0001-use-correct-directfb-config.patch | 19 +- package/sdl/sdl.mk | 2 + package/sdl_image/sdl_image.mk | 11 ++ package/xbmc/Config.in | 202 +++++++++++++++++++++ package/xbmc/S50xbmc | 41 +++++ package/xbmc/xbmc-0001-Fixup-include-path.patch | 79 ++++++++ .../xbmc-0002-RaspberryPi-Default-Settings.patch | 167 +++++++++++++++++ package/xbmc/xbmc.mk | 175 ++++++++++++++++++ package/xbmc/xbmc.service | 12 ++ support/dependencies/dependencies.sh | 10 + 11 files changed, 702 insertions(+), 17 deletions(-)create mode 100644 package/xbmc/Config.in
create mode 100755 package/xbmc/S50xbmc
create mode 100644package/xbmc/xbmc-0001-Fixup-include-path.patchcreate mode 100644package/xbmc/xbmc-0002-RaspberryPi-Default-Settings.patch
create mode 100644package/xbmc/xbmc.mk
create mode 100644 package/xbmc/xbmc.service--
1.8.5.3_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot