Skip to contentSkip to conversation

allow preemption in check_task_state

PATCH In review Nicholas Mc Guire 2 participants 2 messages Feb 10, 2014 – Feb 14, 2014 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 3/5 allow preemption in check_task_state

A lockfree approach to check_task_state

This treates the state as an indicator variable and use it to probe saved_state lock free. There is actually no consistency demand on state/saved_state but rather a consistency demand on the transitions of the two variables but those transition, based on path inspection, are not independent.

Its probably not faster than the lock/unlock case if uncontended - atleast it does not show up in benchmark results, but it would never be hit by a full pi-boost cycle as there is no contention.

This also was tested against the test-case from Sebastian as well as rnning a few scripted gdb breakpoint debugging/single-stepping loops to trigger this.

---
 kernel/sched/core.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
kernel/sched/core.c +8 -2
index bf93f63..5690ba3 100644
@@ -1074,11 +1074,17 @@ static int migration_cpu_stop(void *data);
 static bool check_task_state(struct task_struct *p, long match_state)
 {
 	bool match = false;
+	long state, saved_state;
+
+	/* catch restored state */
+	do {
+		state = p->state;
+		saved_state = p->saved_state;
+		rmb();  /* make sure we actually catch updates */
+	} while (state != p->state);
 
-	raw_spin_lock_irq(&p->pi_lock);
 	if (p->state == match_state || p->saved_state == match_state)
 		match = true;
-	raw_spin_unlock_irq(&p->pi_lock);
 
 	return match;
 }
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 1 line · * Nicholas Mc Guire | 2014-02-10 17:28:16 [+0100]:

A lockfree approach to check_task_state

I ignore this due to was has been written in the thread "allow preemption in check_task_state" for now.

Also I just want to state that this function is hardly used on regular basis except for ptrace attach case which ends up beeing a power user in the test case mentioned.

Sebastian