Skip to contentSkip to conversation

ARM: mcpm: Make all mcpm functions notrace

PATCH RESEND Superseded Jon Medhurst (Tixy) 4 participants 5 messages Feb 13, 2014 – Feb 14, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ARM: mcpm: Make all mcpm functions notrace

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

---
 arch/arm/common/Makefile        |    1 +
 arch/arm/mach-vexpress/Makefile |    3 +++
 2 files changed, 4 insertions(+)
arch/arm/common/Makefile +1 -0
index 4bdc416..70b1eff 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_SHARP_SCOOP)	+= scoop.o
 obj-$(CONFIG_PCI_HOST_ITE8152)  += it8152.o
 obj-$(CONFIG_ARM_TIMER_SP804)	+= timer-sp.o
 obj-$(CONFIG_MCPM)		+= mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o
+CFLAGS_REMOVE_mcpm_entry.o	= -pg
 AFLAGS_mcpm_head.o		:= -march=armv7-a
 AFLAGS_vlock.o			:= -march=armv7-a
 obj-$(CONFIG_TI_PRIV_EDMA)	+= edma.o
arch/arm/mach-vexpress/Makefile +3 -0
index 0997e0b..fc649bc 100644
@@ -8,8 +8,11 @@ obj-y					:= v2m.o
 obj-$(CONFIG_ARCH_VEXPRESS_CA9X4)	+= ct-ca9x4.o
 obj-$(CONFIG_ARCH_VEXPRESS_DCSCB)	+= dcscb.o	dcscb_setup.o
 CFLAGS_dcscb.o				+= -march=armv7-a
+CFLAGS_REMOVE_dcscb.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_SPC)		+= spc.o
+CFLAGS_REMOVE_spc.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_TC2_PM)	+= tc2_pm.o
 CFLAGS_tc2_pm.o				+= -march=armv7-a
+CFLAGS_REMOVE_tc2_pm.o			= -pg
 obj-$(CONFIG_SMP)			+= platsmp.o
 obj-$(CONFIG_HOTPLUG_CPU)		+= hotplug.o
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH RESEND 1/1 ARM: mcpm: Make all mcpm functions notrace

Quoted 12 lines · Jon Medhurst (Tixy)

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Quoted 7 lines

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

Please send to RMK's patch system.

Quoted 38 lines
---
 arch/arm/common/Makefile        |    1 +
 arch/arm/mach-vexpress/Makefile |    3 +++
 2 files changed, 4 insertions(+)
arch/arm/common/Makefile +1 -0
index 4bdc416..70b1eff 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_SHARP_SCOOP)	+= scoop.o
 obj-$(CONFIG_PCI_HOST_ITE8152)  += it8152.o
 obj-$(CONFIG_ARM_TIMER_SP804)	+= timer-sp.o
 obj-$(CONFIG_MCPM)		+= mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o
+CFLAGS_REMOVE_mcpm_entry.o	= -pg
 AFLAGS_mcpm_head.o		:= -march=armv7-a
 AFLAGS_vlock.o			:= -march=armv7-a
 obj-$(CONFIG_TI_PRIV_EDMA)	+= edma.o
arch/arm/mach-vexpress/Makefile +3 -0
index 0997e0b..fc649bc 100644
@@ -8,8 +8,11 @@ obj-y					:= v2m.o
 obj-$(CONFIG_ARCH_VEXPRESS_CA9X4)	+= ct-ca9x4.o
 obj-$(CONFIG_ARCH_VEXPRESS_DCSCB)	+= dcscb.o	dcscb_setup.o
 CFLAGS_dcscb.o				+= -march=armv7-a
+CFLAGS_REMOVE_dcscb.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_SPC)		+= spc.o
+CFLAGS_REMOVE_spc.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_TC2_PM)	+= tc2_pm.o
 CFLAGS_tc2_pm.o				+= -march=armv7-a
+CFLAGS_REMOVE_tc2_pm.o			= -pg
 obj-$(CONFIG_SMP)			+= platsmp.o
 obj-$(CONFIG_HOTPLUG_CPU)		+= hotplug.o
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH RESEND 1/1 ARM: mcpm: Make all mcpm functions notrace

Quoted 20 lines · Nicolas Pitre
Quoted 18 lines · Jon Medhurst (Tixy)

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

Quoted 5 lines
Quoted 1 line

Please send to RMK's patch system.

Thanks, added as patch 7962/2 [1]. (My first attempt accidentally omitted the "From: Dave Martin" line - I hope the patch system understands such lines).

[1] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7962/2

Signature · 1 line
Tixy
#3 lore raw

PATCH RESEND 1/1 ARM: mcpm: Make all mcpm functions notrace

Quoted 23 lines · Jon Medhurst (Tixy)
Quoted 22 lines · Nicolas Pitre
Quoted 19 lines · Jon Medhurst (Tixy)

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

Quoted 7 lines
Quoted 3 lines

Please send to RMK's patch system.

Thanks, added as patch 7962/2 [1]. (My first attempt accidentally omitted the "From: Dave Martin" line - I hope the patch system understands such lines).

I won't lost sleep over it if not...

I'd forgotten about this patch, to be honest.

Cheers
---Dave

#4 lore raw

PATCH RESEND 1/1 ARM: mcpm: Make all mcpm functions notrace

In reply to Jon Medhurst (Tixy)

Hi Tixy,

Quoted 12 lines · Jon Medhurst (Tixy)

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Quoted 6 lines

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

Just realised that spc.c now has OPP functionality too. As the comment above says this can be fine grained later, but just wanted to mention here. IMO we can restrict notrace to just below functions in spc.c

ve_spc_cpu_in_wfi
ve_spc_cpu_wakeup_irq
ve_spc_global_wakeup_irq
ve_spc_powerdown
ve_spc_set_resume_addr

Regards,
Sudeep