Skip to contentSkip to conversation

qemu-options.hx: improve -numa doc

PATCH Applied Luiz Capitulino 2 participants 2 messages Feb 14, 2014 – Feb 17, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu-options.hx: improve -numa doc

The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text.

---
 qemu-options.hx | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
qemu-options.hx +6 -3
index 56e5fdf..ed1d409 100644
@@ -97,10 +97,13 @@ ETEXI
 DEF("numa", HAS_ARG, QEMU_OPTION_numa,
     "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
 STEXI
-@item -numa @var{opts}
+@item -numa node[,mem=@var{size}][,cpus=@var{cpu[-cpu]}][,nodeid=@var{node}]
 @findex -numa
-Simulate a multi node NUMA system. If mem and cpus are omitted, resources
-are split equally.
+Simulate a multi node NUMA system. If @var{mem} and @var{cpus} are omitted,
+resources are split equally. Also, note that the -@option{numa} option doesn't
+allocate any of the specified resources. That is, it just assigns existing
+resources to NUMA nodes. This means that one still has to use the -@option{m}
+and -@option{smp} options to respectively allocate RAM and vCPUs.
 ETEXI
 
 DEF("add-fd", HAS_ARG, QEMU_OPTION_add_fd,
Signature · 1 line
1.8.1.4
#1 lore raw

Il 14/02/2014 20:34, Luiz Capitulino ha scritto:

Quoted 21 lines

The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text.

---
 qemu-options.hx | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
qemu-options.hx +1 -1
index 56e5fdf..ed1d409 100644
@@ -97,10 +97,13 @@ ETEXI
 DEF("numa", HAS_ARG, QEMU_OPTION_numa,
     "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
 STEXI
-@item -numa @var{opts}
+@item -numa node[,mem=@var{size}][,cpus=@var{cpu[-cpu]}][,nodeid=@var{node}]
 @findex -numa

qemu-options.hx ETEXI · line 109

Quoted 10 lines
qemu-options.hx +5 -2
-Simulate a multi node NUMA system. If mem and cpus are omitted, resources
-are split equally.
+Simulate a multi node NUMA system. If @var{mem} and @var{cpus} are omitted,
+resources are split equally. Also, note that the -@option{numa} option doesn't
+allocate any of the specified resources. That is, it just assigns existing
+resources to NUMA nodes. This means that one still has to use the -@option{m}
+and -@option{smp} options to respectively allocate RAM and vCPUs.
 ETEXI
 
 DEF("add-fd", HAS_ARG, QEMU_OPTION_add_fd,

Applied to (rebased) NUMA branch.

Paolo