Skip to contentSkip to conversation

pinctrl: single: add low powr mode support

PATCH New Chao Xie 3 participants 3 messages Jan 28, 2014 – Feb 14, 2014

Subsystems (3)
lore
Share & tools
lore

Chao Xie

author
#0 lore raw

PATCH 1/1 pinctrl: single: add low powr mode support

From: Chao Xie <[email protected]>

For some silicons, the pin configuration register can control the output of the pin when the pad including the pin enter low power mode.
For example, the pin can be "Drive 1", "Drive 0", "Float" when the pad including the pin enter low power mode.
It is very useful when you want to control the power leakeage when the SOC enter low power mode, and can save more power for the low power mode.

---
 Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 7 +++++++
 drivers/pinctrl/pinctrl-single.c                             | 3 +++
 2 files changed, 10 insertions(+)
Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt +7 -0
index bc0dfdf..66dcaa9 100644
@@ -63,6 +63,13 @@ Optional properties:
 		/* input, enable bits, disable bits, mask */
 		pinctrl-single,input-schmitt-enable = <0x30 0x40 0 0x70>;
 
+- pinctrl-single,low-power-mode : array of value that are used to configure
+  low power mode of this pin. For some silicons, the low power mode will
+  control the output of the pin when the pad including the pin enter low
+  power mode.
+		/* low power mode value, mask */
+		pinctrl-single,low-power-mode = <0x288 0x388>;
+
 - pinctrl-single,gpio-range : list of value that are used to configure a GPIO
   range. They're value of subnode phandle, pin base in pinctrl device, pin
   number in this range, GPIO function value of this GPIO range.
drivers/pinctrl/pinctrl-single.c +3 -0
index 41f1cfe..18ed6b6 100644
@@ -661,6 +661,7 @@ static int pcs_pinconf_get(struct pinctrl_dev *pctldev,
 			break;
 		case PIN_CONFIG_DRIVE_STRENGTH:
 		case PIN_CONFIG_SLEW_RATE:
+		case PIN_CONFIG_LOW_POWER_MODE:
 		default:
 			*config = data;
 			break;
@@ -698,6 +699,7 @@ static int pcs_pinconf_set(struct pinctrl_dev *pctldev,
 			case PIN_CONFIG_INPUT_SCHMITT:
 			case PIN_CONFIG_DRIVE_STRENGTH:
 			case PIN_CONFIG_SLEW_RATE:
+			case PIN_CONFIG_LOW_POWER_MODE:
 				shift = ffs(func->conf[i].mask) - 1;
 				data &= ~func->conf[i].mask;
 				data |= (arg << shift) & func->conf[i].mask;
@@ -1100,6 +1102,7 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,
 		{ "pinctrl-single,drive-strength", PIN_CONFIG_DRIVE_STRENGTH, },
 		{ "pinctrl-single,slew-rate", PIN_CONFIG_SLEW_RATE, },
 		{ "pinctrl-single,input-schmitt", PIN_CONFIG_INPUT_SCHMITT, },
+		{ "pinctrl-single,low-power-mode", PIN_CONFIG_LOW_POWER_MODE, },
 	};
 	struct pcs_conf_type prop4[] = {
 		{ "pinctrl-single,bias-pullup", PIN_CONFIG_BIAS_PULL_UP, },
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 pinctrl: single: add low powr mode support

Quoted 11 lines · Chao Xie

From: Chao Xie <[email protected]>

For some silicons, the pin configuration register can control the output of the pin when the pad including the pin enter low power mode.
For example, the pin can be "Drive 1", "Drive 0", "Float" when the pad including the pin enter low power mode.
It is very useful when you want to control the power leakeage when the SOC enter low power mode, and can save more power for the low power mode.

Quoted 1 line

Looks similar to the other pin config stuff, patch applied unless Tony protests.

Yours,
Linus Walleij

maintainer
#2 lore raw

PATCH 1/1 pinctrl: single: add low powr mode support

Quoted 13 lines · Linus Walleij
Quoted 11 lines · Chao Xie

From: Chao Xie <[email protected]>

For some silicons, the pin configuration register can control the output of the pin when the pad including the pin enter low power mode.
For example, the pin can be "Drive 1", "Drive 0", "Float" when the pad including the pin enter low power mode.
It is very useful when you want to control the power leakeage when the SOC enter low power mode, and can save more power for the low power mode.

Quoted 4 lines
Quoted 1 line

Looks similar to the other pin config stuff, patch applied unless Tony protests.

Seems fine to me: