staging: rts5208: fix always true condition
PATCH 1/1 staging: rts5208: fix always true condition
ANDing anything with 0x1E and expecting it to be not 0x03 will always be true. AND instead with 0x03, so that we check the last two bits, which should be what was intended there.
Reported-by David Binderman <[email protected]>
Signed-off-by Levente Kurusa <[email protected]>
--- drivers/staging/rts5208/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rts5208/sd.c +1 -1
@@ -3512,7 +3512,7 @@ RTY_SEND_CMD:TRACE_RET (chip,STATUS_FAIL ); }else if (rsp_type ==SD_RSP_TYPE_R0 ) { -if ((ptr[3 ] &0x1E ) !=0x03 ) +if ((ptr[3 ] &0x03 ) !=0x03 )TRACE_RET (chip,STATUS_FAIL ); } }
Signature · 1 line
1.8.3.1
Quoted 4 lines · Levente Kurusa
ANDing anything with
0x1Eand expecting it to be not0x03will always be true. AND instead with0x03, so that we check the last two bits, which should be what was intended there.
This one is less clear what the intent was. Could easily be that the 0x3 is wrong.
Sometimes it's better to leave the warning rather than guess at the fix.
regards,
dan carpenter