Skip to contentSkip to conversation

clk: at91: Fix memory leak

PATCH New Alexander Shiyan 3 participants 4 messages Feb 15, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: at91: Fix memory leak

---
 drivers/clk/at91/clk-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-master.c +1 -1
index bd313f7..c1af80b 100644
@@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
 
 	irq = irq_of_parse_and_map(np, 0);
 	if (!irq)
-		return;
+		goto out_free_characteristics;
 
 	clk = at91_clk_register_master(pmc, irq, name, num_parents,
 				       parent_names, layout,
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 clk: at91: Fix memory leak

Hi Alexander,

Thanks for reporting and fixing this memory leak.

Unfortunately you're a bit late: this was already fixed, and I acked it ;-) (see http://www.gossamer-threads.com/lists/linux/kernel/1865947).

Best Regards,

Boris

Quoted 18 lines · Alexander Shiyan
---
  drivers/clk/at91/clk-master.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-master.c +1 -1
index bd313f7..c1af80b 100644
@@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
 
  	irq = irq_of_parse_and_map(np, 0);
  	if (!irq)
-		return;
+		goto out_free_characteristics;
 
  	clk = at91_clk_register_master(pmc, irq, name, num_parents,
  				       parent_names, layout,
#2 lore raw

PATCH 1/1 clk: at91: Fix memory leak

Quoted 8 lines · Boris BREZILLON

Hi Alexander,

Thanks for reporting and fixing this memory leak.

Unfortunately you're a bit late: this was already fixed, and I acked it ;-) (see
http://www.gossamer-threads.com/lists/linux/kernel/1865947).

Crap, I knew this looked familiar but I couldn't find it fixed in the tree I'm working on :)

Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 clk: at91: Fix memory leak

In reply to Alexander Shiyan
Quoted 1 line · Alexander Shiyan
Quoted 25 lines
---
 drivers/clk/at91/clk-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/at91/clk-master.c +1 -1
index bd313f7..c1af80b 100644
@@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc,
 
 	irq = irq_of_parse_and_map(np, 0);
 	if (!irq)
-		return;
+		goto out_free_characteristics;
 
 	clk = at91_clk_register_master(pmc, irq, name, num_parents,
 				       parent_names, layout,
Signature · 7 lines
1.8.3.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com