Skip to contentSkip to conversation

regulator: tps65910: backup battery regulator

PATCH New Markus Pargmann 3 participants 7 messages Dec 20, 2013 – Feb 28, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover regulator: tps65910: backup battery regulator

Hi,

backup battery charger regulator for tps65910.

Regards,

Markus

Changes in v2:
- Seperate ops for vbb to reduce performance impact for other regulators on voltage mapping
- Usage of switch statements

Markus Pargmann (2):
regulator: tps65910: Add backup battery regulator
ARM: dts: tps65910 backup battery regulator

 Documentation/devicetree/bindings/mfd/tps65910.txt |  4 +-
 arch/arm/boot/dts/tps65910.dtsi                    |  5 ++
 drivers/regulator/tps65910-regulator.c             | 56 +++++++++++++++++++++-
 include/linux/mfd/tps65910.h                       |  3 +-
 4 files changed, 64 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.5.1
#1 lore raw

PATCH v2 1/2 regulator: tps65910: Add backup battery regulator

tps65910 has a backup battery charger with a configurable voltage. This patch adds a regulator for the backup battery.

---
 Documentation/devicetree/bindings/mfd/tps65910.txt |  4 +-
 drivers/regulator/tps65910-regulator.c             | 56 +++++++++++++++++++++-
 include/linux/mfd/tps65910.h                       |  3 +-
 3 files changed, 59 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/mfd/tps65910.txt +2 -2
index 2e33048..b4bd98a 100644
@@ -21,7 +21,7 @@ Required properties:
 
   The valid regulator-compatible values are:
   tps65910: vrtc, vio, vdd1, vdd2, vdd3, vdig1, vdig2, vpll, vdac, vaux1,
-            vaux2, vaux33, vmmc
+            vaux2, vaux33, vmmc, vbb
   tps65911: vrtc, vio, vdd1, vdd3, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
             ldo6, ldo7, ldo8
 
@@ -38,7 +38,7 @@ Required properties:
 	vcc4-supply: VAUX1 and VAUX2 input.
 	vcc5-supply: VPLL and VDAC input.
 	vcc6-supply: VDIG1 and VDIG2 input.
-	vcc7-supply: VRTC input.
+	vcc7-supply: VRTC and VBB input.
 	vccio-supply: VIO input.
   tps65911:
 	vcc1-supply: VDD1 input.
drivers/regulator/tps65910-regulator.c +55 -1

116 lines not on this page · raw message

include/linux/mfd/tps65910.h +2 -1
index 20e433e..1adeee1 100644
@@ -833,6 +833,7 @@
 #define TPS65910_REG_VAUX2				10
 #define TPS65910_REG_VAUX33				11
 #define TPS65910_REG_VMMC				12
+#define TPS65910_REG_VBB				13
 
 #define TPS65911_REG_VDDCTRL				4
 #define TPS65911_REG_LDO1				5
@@ -845,7 +846,7 @@
 #define TPS65911_REG_LDO8				12
 
 /* Max number of TPS65910/11 regulators */
-#define TPS65910_NUM_REGS				13
+#define TPS65910_NUM_REGS				14
 
 /* External sleep controls through EN1/EN2/EN3/SLEEP inputs */
 #define TPS65910_SLEEP_CONTROL_EXT_INPUT_EN1		0x1
Signature · 1 line
1.8.5.1
maintainer Applied
#2 lore raw

PATCH v2 1/2 regulator: tps65910: Add backup battery regulator

Quoted 2 lines · Markus Pargmann

tps65910 has a backup battery charger with a configurable voltage. This patch adds a regulator for the backup battery.

Applied, thanks.

#3 lore raw

PATCH v2 2/2 ARM: dts: tps65910 backup battery regulator

In reply to Markus Pargmann

This patch adds a devicetree node for the backup battery regulator.

---
 arch/arm/boot/dts/tps65910.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tps65910.dtsi +5 -0
index 92693a8..b0ac665 100644
@@ -82,5 +82,10 @@
 			reg = <12>;
 			regulator-compatible = "vmmc";
 		};
+
+		vbb_reg: regulator at 13 {
+			reg = <13>;
+			regulator-compatible = "vbb";
+		};
 	};
 };
Signature · 1 line
1.8.5.1
#4 lore raw

PATCH v2 1/1 ARM: dts: tps65910 backup battery regulator

This patch adds a devicetree node for the backup battery regulator.

---
Hi,

Mark Brown applied [1] the other part of the series which adds 'vbb' as regulator-compatible. I forgot to add you in Cc.

Regards,

Markus

[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/289815/focus=290089

 arch/arm/boot/dts/tps65910.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tps65910.dtsi +5 -0
index 92693a8..b0ac665 100644
@@ -82,5 +82,10 @@
 			reg = <12>;
 			regulator-compatible = "vmmc";
 		};
+
+		vbb_reg: regulator at 13 {
+			reg = <13>;
+			regulator-compatible = "vbb";
+		};
 	};
 };
Signature · 1 line
1.8.5.2
#5 lore raw

PATCH v2 1/1 ARM: dts: tps65910 backup battery regulator

Hi,

Quoted 8 lines · Markus Pargmann

This patch adds a devicetree node for the backup battery regulator.

---
Hi,

Mark Brown applied [1] the other part of the series which adds 'vbb' as regulator-compatible. I forgot to add you in Cc.

Any comments on this?

Regards,

Markus

Quoted 29 lines

Regards,

Markus

[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/289815/focus=290089

 arch/arm/boot/dts/tps65910.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tps65910.dtsi +5 -0
index 92693a8..b0ac665 100644
@@ -82,5 +82,10 @@
 			reg = <12>;
 			regulator-compatible = "vmmc";
 		};
+
+		vbb_reg: regulator at 13 {
+			reg = <13>;
+			regulator-compatible = "vbb";
+		};
 	};
 };
Signature · 1 line
1.8.5.2
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
maintainer
#6 lore raw

PATCH v2 1/1 ARM: dts: tps65910 backup battery regulator

Quoted 5 lines · Markus Pargmann

Hi,

Quoted 2 lines · Markus Pargmann

This patch adds a devicetree node for the backup battery regulator.

Quoted 8 lines
Quoted 6 lines

---
Hi,

Mark Brown applied [1] the other part of the series which adds 'vbb' as regulator-compatible. I forgot to add you in Cc.

Any comments on this?

Thanks applying into omap-for-v3.15/dt.

Regards,

Tony

Quoted 30 lines
Quoted 24 lines

[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/289815/focus=290089

 arch/arm/boot/dts/tps65910.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tps65910.dtsi +5 -0
index 92693a8..b0ac665 100644
@@ -82,5 +82,10 @@
 			reg = <12>;
 			regulator-compatible = "vmmc";
 		};
+
+		vbb_reg: regulator at 13 {
+			reg = <13>;
+			regulator-compatible = "vbb";
+		};
 	};
 };
Signature · 1 line
1.8.5.2
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |