arm: zynq: correct the argument to lldiv
Subsystems (2)
PATCH 1/1 arm: zynq: correct the argument to lldiv
Typecast the argument with unsigned long
long for proper calculation of lldiv
---
-Fixes the issue of rounding of the multiplication result to
32-bit value
--- arch/arm/cpu/armv7/zynq/timer.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/cpu/armv7/zynq/timer.c +2 -1
@@ -107,7 +107,8 @@ void __udelay(unsigned long usec)if (usec ==0 )return ; - countticks =lldiv (TIMER_TICK_HZ * usec,1000000 ); + countticks =lldiv (((unsigned long long )TIMER_TICK_HZ * usec), +1000000 );/* decrementing timer */ timeend =readl (&timer_base->counter) - countticks;
Signature · 1 line
1.7.4
PATCH 1/1 arm: zynq: correct the argument to lldiv
Quoted 7 lines · Siva Durga Prasad Paladugu
Typecast the argument with unsigned long
long for proper calculation of lldivSigned-off-by Siva Durga Prasad Paladugu <[email protected]>---
-Fixes the issue of rounding of the multiplication result to
32-bit value
We found this in connection to eeprom write test.
Albert: This is the bug fixed I was talking you about on IRC. Will add it to my zynq pull request if this is fine for others.
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140217/79955143/attachment.pgp>
PATCH 1/1 arm: zynq: correct the argument to lldiv
Hi Michal,
Quoted 9 lines · Michal Simek
Quoted 7 lines · Siva Durga Prasad Paladugu
Typecast the argument with unsigned long
long for proper calculation of lldivSigned-off-by Siva Durga Prasad Paladugu <[email protected]>---
-Fixes the issue of rounding of the multiplication result to
32-bit value
Quoted 6 lines
We found this in connection to eeprom write test.
Signed-off-by Michal Simek <[email protected]>Albert: This is the bug fixed I was talking you about on IRC. Will add it to my zynq pull request if this is fine for others.
Fine for me at least. As soon as my current PR to u-boot/master is applied (cc: Tom), I'll resume applying patches, starting with your Zynq PR, so if it was updated meanwhile, I'll apply the updated one.
Quoted 2 lines
Thanks,
Michal
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 arm: zynq: correct the argument to lldiv
Quoted 16 lines · Albert ARIBAUD
Hi Michal,
Quoted 11 lines · Michal Simek
Quoted 7 lines · Siva Durga Prasad Paladugu
Typecast the argument with unsigned long
long for proper calculation of lldivSigned-off-by Siva Durga Prasad Paladugu <[email protected]>---
-Fixes the issue of rounding of the multiplication result to
32-bit valueWe found this in connection to eeprom write test.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Michal Simek <[email protected]>Albert: This is the bug fixed I was talking you about on IRC. Will add it to my zynq pull request if this is fine for others.
Fine for me at least. As soon as my current PR to u-boot/master is applied (cc: Tom), I'll resume applying patches, starting with your Zynq PR, so if it was updated meanwhile, I'll apply the updated one.
I am keeping my eyes on it too.
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 263 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140217/ff4881f6/attachment.pgp>