Skip to contentSkip to conversation

mtd: nuc900_nand: NULL dereference in nuc900_nand_enable()

PATCH Applied Dan Carpenter 2 participants 2 messages Feb 17, 2014 – Feb 23, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: nuc900_nand: NULL dereference in nuc900_nand_enable()

Instead of writing to "nand->reg + REG_FMICSR" we write to "REG_FMICSR" which is NULL and not a valid register.

Fixes 8bff82cbc308 ('mtd: add nand support for w90p910 (v2)')

---
Static checker stuff.

drivers/mtd/nand/nuc900_nand.c +1 -1
index 331fccbdde61..e8a5fffd6ab2 100644
@@ -225,7 +225,7 @@ static void nuc900_nand_enable(struct nuc900_nand *nand)
 	val = __raw_readl(nand->reg + REG_FMICSR);
 
 	if (!(val & NAND_EN))
-		__raw_writel(val | NAND_EN, REG_FMICSR);
+		__raw_writel(val | NAND_EN, nand->reg + REG_FMICSR);
 
 	val = __raw_readl(nand->reg + REG_SMCSR);
 
Applied
#1 lore raw
Quoted 7 lines · Dan Carpenter

Instead of writing to "nand->reg + REG_FMICSR" we write to "REG_FMICSR" which is NULL and not a valid register.

Fixes 8bff82cbc308 ('mtd: add nand support for w90p910 (v2)')

---
Static checker stuff.

Pushed to l2-mtd.git. Thanks!

Brian