Skip to contentSkip to conversation

ncpfs: cleanup indenting in ncp_lookup()

PATCH In review Dan Carpenter 1 participant 2 messages Feb 17, 2014 – Apr 8, 2014 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ncpfs: cleanup indenting in ncp_lookup()

My static checker suggests adding curly braces here. Probably that was the intent, but actually the code works the same either way. I've just changed the indenting and left the code as-is.

fs/ncpfs/dir.c +2 -2
index 91441de2529c..08b8ea8c353e 100644
@@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig
 				 dentry->d_name.len, 1);
 		if (!res)
 			res = ncp_lookup_volume(server, __name, &(finfo.i));
-			if (!res)
-				ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
+		if (!res)
+			ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
 	} else {
 		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,
 				 dentry->d_name.len, !ncp_preserve_case(dir));
#1 lore raw

Ping?

regards,
dan carpenter

Quoted 21 lines · Dan Carpenter

My static checker suggests adding curly braces here. Probably that was the intent, but actually the code works the same either way. I've just changed the indenting and left the code as-is.

fs/ncpfs/dir.c +2 -2
index 91441de2529c..08b8ea8c353e 100644
@@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig
 				 dentry->d_name.len, 1);
 		if (!res)
 			res = ncp_lookup_volume(server, __name, &(finfo.i));
-			if (!res)
-				ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
+		if (!res)
+			ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
 	} else {
 		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,
 				 dentry->d_name.len, !ncp_preserve_case(dir));