Skip to contentSkip to conversation

why does Qt5 build with ARM_INSTRUCTION_SET = "arm"

meta-qt5 New Nicolas Dechesne 5 participants 7 messages Feb 17, 2014 – Feb 18, 2014

lore
Share & tools
lore
#0 lore raw

hi,

does anybody know why in Qt5/qtbase.inc, we have:

ARM_INSTRUCTION_SET = "arm"

Could it be an a low hanging fruit from the past? e.g. before
https://bugreports.qt-project.org/browse/QTBUG-16402 or
https://qt.gitorious.org/qt/qtbase/commit/a3bd9d4c0f3d9e80dbe35bd88649b245dca5f410?

as a matter of fact, for our project Qt5 (and QtWebkit) are building (and working fine) when built with Thumb2, outside of OE. Also using ARM instruction set instead of Thumb2 enforces Webkit to use the ARM version of the javascript JIT, while the Thumb2 JIT engine seems to work a lot better in our testing...

cheers

nico

#1 lore raw
Quoted 9 lines · Nicolas Dechesne

hi,

does anybody know why in Qt5/qtbase.inc, we have:

ARM_INSTRUCTION_SET = "arm"

Could it be an a low hanging fruit from the past? e.g. before
https://bugreports.qt-project.org/browse/QTBUG-16402 or
https://qt.gitorious.org/qt/qtbase/commit/a3bd9d4c0f3d9e80dbe35bd88649b245dca5f410?

Hmm, I would assume that's here from 4.8 days, although I haven't tried dropping that line for latest Qt5... Would make sense to do some more testing.

Quoted 5 lines

as a matter of fact, for our project Qt5 (and QtWebkit) are building (and working fine) when built with Thumb2, outside of OE. Also using ARM instruction set instead of Thumb2 enforces Webkit to use the ARM version of the javascript JIT, while the Thumb2 JIT engine seems to work a lot better in our testing...

Seems like worth the effort to re-test the need for that setting. Unless someone else has tried it already and found out the issue is still there

Signature · 1 line
Denys
#2 lore raw
Quoted 15 lines · Denys Dmytriyenko
Quoted 9 lines · Nicolas Dechesne

hi,

does anybody know why in Qt5/qtbase.inc, we have:

ARM_INSTRUCTION_SET = "arm"

Could it be an a low hanging fruit from the past? e.g. before
https://bugreports.qt-project.org/browse/QTBUG-16402 or
https://qt.gitorious.org/qt/qtbase/commit/a3bd9d4c0f3d9e80dbe35bd88649b245dca5f410?

Hmm, I would assume that's here from 4.8 days, although I haven't tried dropping that line for latest Qt5... Would make sense to do some more testing.

Quoted 8 lines
Quoted 5 lines

as a matter of fact, for our project Qt5 (and QtWebkit) are building (and working fine) when built with Thumb2, outside of OE. Also using ARM instruction set instead of Thumb2 enforces Webkit to use the ARM version of the javascript JIT, while the Thumb2 JIT engine seems to work a lot better in our testing...

Seems like worth the effort to re-test the need for that setting. Unless someone else has tried it already and found out the issue is still there

IIRC it was failing to build for armv4t (at least with 5.0.0) if someone tests that armv4t builds with 5.2.*, I'll accept the patch.

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 21 lines · Martin Jansa
Quoted 20 lines · Denys Dmytriyenko
Quoted 9 lines · Nicolas Dechesne

hi,

does anybody know why in Qt5/qtbase.inc, we have:

ARM_INSTRUCTION_SET = "arm"

Could it be an a low hanging fruit from the past? e.g. before
https://bugreports.qt-project.org/browse/QTBUG-16402 or
https://qt.gitorious.org/qt/qtbase/commit/a3bd9d4c0f3d9e80dbe35bd88649b245dca5f410?

Hmm, I would assume that's here from 4.8 days, although I haven't tried dropping that line for latest Qt5... Would make sense to do some more testing.

Quoted 5 lines

as a matter of fact, for our project Qt5 (and QtWebkit) are building (and working fine) when built with Thumb2, outside of OE. Also using ARM instruction set instead of Thumb2 enforces Webkit to use the ARM version of the javascript JIT, while the Thumb2 JIT engine seems to work a lot better in our testing...

Quoted 5 lines
Quoted 2 lines

Seems like worth the effort to re-test the need for that setting. Unless someone else has tried it already and found out the issue is still there

IIRC it was failing to build for armv4t (at least with 5.0.0) if someone tests that armv4t builds with 5.2.*, I'll accept the patch.

With ARM_INSTRUCTION_SET forced to thumb I'm able to build qtbase 5.1.1 and 5.2.1 tuned for both armv4t and cortexa9thf-neon.

Andre
--

#4 lore raw
Quoted 22 lines · Andre McCurdy
Quoted 21 lines · Martin Jansa
Quoted 20 lines · Denys Dmytriyenko
Quoted 9 lines · Nicolas Dechesne

hi,

does anybody know why in Qt5/qtbase.inc, we have:

ARM_INSTRUCTION_SET = "arm"

Could it be an a low hanging fruit from the past? e.g. before
https://bugreports.qt-project.org/browse/QTBUG-16402 or
https://qt.gitorious.org/qt/qtbase/commit/a3bd9d4c0f3d9e80dbe35bd88649b245dca5f410?

Hmm, I would assume that's here from 4.8 days, although I haven't tried dropping that line for latest Qt5... Would make sense to do some more testing.

Quoted 5 lines

as a matter of fact, for our project Qt5 (and QtWebkit) are building (and working fine) when built with Thumb2, outside of OE. Also using ARM instruction set instead of Thumb2 enforces Webkit to use the ARM version of the javascript JIT, while the Thumb2 JIT engine seems to work a lot better in our testing...

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Seems like worth the effort to re-test the need for that setting. Unless someone else has tried it already and found out the issue is still there

IIRC it was failing to build for armv4t (at least with 5.0.0) if someone tests that armv4t builds with 5.2.*, I'll accept the patch.

With ARM_INSTRUCTION_SET forced to thumb I'm able to build qtbase 5.1.1 and 5.2.1 tuned for both armv4t and cortexa9thf-neon.

Cool, can you please send the patch removing ARM_INSTRUCTION_SET?

Thanks

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw

PATCH 1/1 qtbase.inc: don't force ARM_INSTRUCTION_SET to arm

Forcing ARM_INSTRUCTION_SET to arm when building qtbase no longer seems to be required.

Confirmed by forcing ARM_INSTRUCTION_SET to thumb and building qtbase 5.1.1 and 5.2.1 tuned for both armv4t and cortexa9thf-neon.

---
 recipes-qt/qt5/qtbase.inc | 3 ---
 1 file changed, 3 deletions(-)
recipes-qt/qt5/qtbase.inc +0 -3
index f056393..ff62297 100644
@@ -126,9 +126,6 @@ QT_CONFIG_FLAGS += " \
     ${EXTRA_OECONF} \
 "
 
-# Qt uses atomic instructions not supported in thumb mode
-ARM_INSTRUCTION_SET = "arm"
-
 do_generate_qt_config_file_append() {
     cat >> ${QT_CONF_PATH} <<EOF
 
Signature · 1 line
1.8.1.2
#6 lore raw
In reply to Nicolas Dechesne

-Khem

Quoted 6 lines · Nicolas Dechesne

hi,

does anybody know why in Qt5/qtbase.inc, we have:

ARM_INSTRUCTION_SET = "arm"

there were issues with thumb1 and i guess legacy continued may be its not needed any longer test it out and send a patch
make sure that when its using thumb1 then current logic still kicks in

Quoted 4 lines

Could it be an a low hanging fruit from the past? e.g. before
https://bugreports.qt-project.org/browse/QTBUG-16402 or

https://qt.gitorious.org/qt/qtbase/commit/a3bd9d4c0f3d9e80dbe35bd88649b245dca5f410
?

Quoted 14 lines

as a matter of fact, for our project Qt5 (and QtWebkit) are building (and working fine) when built with Thumb2, outside of OE. Also using ARM instruction set instead of Thumb2 enforces Webkit to use the ARM version of the javascript JIT, while the Thumb2 JIT engine seems to work a lot better in our testing...

cheers

nico
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel