Skip to contentSkip to conversation

af_packet: remove a stray tab in packet_set_ring()

PATCH Applied Dan Carpenter 3 participants 3 messages Feb 18, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 af_packet: remove a stray tab in packet_set_ring()

At first glance it looks like there is a missing curly brace but actually the code works the same either way. I have adjusted the indenting but left the code the same.

net/packet/af_packet.c +1 -1
index 6a2bb37506c5..7fd37de503d1 100644
@@ -3786,7 +3786,7 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
 		 */
 			if (!tx_ring)
 				init_prb_bdqc(po, rb, pg_vec, req_u, tx_ring);
-				break;
+			break;
 		default:
 			break;
 		}
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

At first glance it looks like there is a missing curly brace but actually the code works the same either way. I have adjusted the indenting but left the code the same.

Agreed.

Actually, this whole construct could have been simplified ...

     switch (po->tp_version) {
     case TPACKET_V3:
     /* Transmit path is not supported. We checked
      * it above but just being paranoid
      */
         if (!tx_ring)
             init_prb_bdqc(po, rb, pg_vec, req_u, tx_ring);
             break;
     default:
         break;
     }

... into just one if condition. Looks a bit unnecessary as there's just one case. Feel free to change that as well.

Otherwise ...

Quoted 14 lines
net/packet/af_packet.c +1 -1
index 6a2bb37506c5..7fd37de503d1 100644
@@ -3786,7 +3786,7 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u,
  		 */
  			if (!tx_ring)
  				init_prb_bdqc(po, rb, pg_vec, req_u, tx_ring);
-				break;
+			break;
  		default:
  			break;
  		}