regmap: Separate regmap dev initialization

Hello Michal Simek,

The patch 6cfec04bcc05: "regmap: Separate regmap dev initialization" from Feb 10, 2014, leads to the following static checker warning:

drivers/base/regmap/regmap.c:765 regmap_init()
warn: add curly braces?

drivers/base/regmap/regmap.c

   759          ret = regcache_init(map, config);
   760          if (ret != 0)
   761                  goto err_range;
   762  
   763          if (dev)
   764                  ret = regmap_attach_dev(dev, map, config);
   765                  if (ret != 0)
   766                          goto err_regcache;

Please add curly braces or adjust the indenting to not confuse the static checkers.

Hi Dan,

Quoted 18 lines · Dan Carpenter

Hello Michal Simek,

The patch 6cfec04bcc05: "regmap: Separate regmap dev initialization" from Feb 10, 2014, leads to the following static checker warning:

drivers/base/regmap/regmap.c:765 regmap_init()
warn: add curly braces?

drivers/base/regmap/regmap.c

   759          ret = regcache_init(map, config);
   760          if (ret != 0)
   761                  goto err_range;
   762  
   763          if (dev)
   764                  ret = regmap_attach_dev(dev, map, config);
   765                  if (ret != 0)
   766                          goto err_regcache;

Quoted 2 lines

Please add curly braces or adjust the indenting to not confuse the static checkers.

I am aware about this. Mark has already applied RFC to any his branch :-(. I can send v2 but it is up to Mark if he wants to fix it or not.

Quoted 24 lines · Michal Simek

Hi Dan,

Quoted 20 lines · Dan Carpenter

Hello Michal Simek,

The patch 6cfec04bcc05: "regmap: Separate regmap dev initialization" from Feb 10, 2014, leads to the following static checker warning:

drivers/base/regmap/regmap.c:765 regmap_init()
warn: add curly braces?

drivers/base/regmap/regmap.c

   759          ret = regcache_init(map, config);
   760          if (ret != 0)
   761                  goto err_range;
   762  
   763          if (dev)
   764                  ret = regmap_attach_dev(dev, map, config);
   765                  if (ret != 0)
   766                          goto err_regcache;

Please add curly braces or adjust the indenting to not confuse the static checkers.

Quoted 3 lines

I am aware about this. Mark has already applied RFC to any his branch :-(. I can send v2 but it is up to Mark if he wants to fix it or not.

Oh, crap. Sorry, I reported this twice. I didn't mean to do that.

I normally grep my outbox to avoid this but I had a typo in my grep this time.