Skip to contentSkip to conversation

endian dependency fix

PATCH New Yoshinori Sato 3 participants 4 messages Feb 16, 2014 – Feb 20, 2014 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 endian dependency fix

mmc_spi have dependency of little-endian environment. So doesn't work big-endian environment.

---
 drivers/mmc/mmc_spi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mmc/mmc_spi.c +5 -5
index fe6a5a1..17fdac7 100644
@@ -11,7 +11,7 @@
 #include <spi.h>
 #include <crc.h>
 #include <linux/crc7.h>
-#include <linux/byteorder/swab.h>
+#include <asm/byteorder.h>
 
 /* MMC/SD in SPI mode reports R1 status always */
 #define R1_SPI_IDLE		(1 << 0)
@@ -91,7 +91,7 @@ static uint mmc_spi_readdata(struct mmc *mmc, void *xbuf,
 			spi_xfer(spi, bsize * 8, NULL, buf, 0);
 			spi_xfer(spi, 2 * 8, NULL, &crc, 0);
 #ifdef CONFIG_MMC_SPI_CRC_ON
-			if (swab16(cyg_crc16(buf, bsize)) != crc) {
+			if (cpu_to_be16(cyg_crc16(buf, bsize)) != crc) {
 				debug("%s: CRC error\n", mmc->name);
 				r1 = R1_SPI_COM_CRC;
 				break;
@@ -120,7 +120,7 @@ static uint mmc_spi_writedata(struct mmc *mmc, const void *xbuf,
 	tok[1] = multi ? SPI_TOKEN_MULTI_WRITE : SPI_TOKEN_SINGLE;
 	while (bcnt--) {
 #ifdef CONFIG_MMC_SPI_CRC_ON
-		crc = swab16(cyg_crc16((u8 *)buf, bsize));
+		crc = cpu_to_be16(cyg_crc16((u8 *)buf, bsize));
 #endif
 		spi_xfer(spi, 2 * 8, tok, NULL, 0);
 		spi_xfer(spi, bsize * 8, buf, NULL, 0);
@@ -193,7 +193,7 @@ static int mmc_spi_request(struct mmc *mmc, struct mmc_cmd *cmd,
 	} else if (cmd->resp_type == MMC_RSP_R2) {
 		r1 = mmc_spi_readdata(mmc, cmd->response, 1, 16);
 		for (i = 0; i < 4; i++)
-			cmd->response[i] = swab32(cmd->response[i]);
+			cmd->response[i] = be32_to_cpu(cmd->response[i]);
 		debug("r128 %x %x %x %x\n", cmd->response[0], cmd->response[1],
 		      cmd->response[2], cmd->response[3]);
 	} else if (!data) {
@@ -205,7 +205,7 @@ static int mmc_spi_request(struct mmc *mmc, struct mmc_cmd *cmd,
 		case SD_CMD_SEND_IF_COND:
 		case MMC_CMD_SPI_READ_OCR:
 			spi_xfer(spi, 4 * 8, NULL, cmd->response, 0);
-			cmd->response[0] = swab32(cmd->response[0]);
+			cmd->response[0] = be32_to_cpu(cmd->response[0]);
 			debug("r32 %x\n", cmd->response[0]);
 			break;
 		case MMC_CMD_SEND_STATUS:
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH 1/1 endian dependency fix

Hi Yoshinori,

You should read the patch submission rules
(http://www.denx.de/wiki/U-Boot/Patches)
before posting patches.

- Use the imperative tense in your summary line

I mean, "fix blah blah" rather than "blah blah fix"

- If applicable, prefix the summary line with a word describing what area of code is being affected followed by a colon.

In this case, "mmc: ..."

Ditto in your MS7206SE series.

Best Regards
Masahiro Yamada

#2 lore raw

PATCH 1/1 endian dependency fix

Hi, all.

Masahiro, thank you for the explanation.

Yoshinori, please resend patches after read patch submission rules.

Best regards,
Nobuhiro

2014-02-18 19:19 GMT+09:00 Masahiro Yamada <[email protected]>:

Quoted 26 lines

Hi Yoshinori,

You should read the patch submission rules
(http://www.denx.de/wiki/U-Boot/Patches)
before posting patches.

- Use the imperative tense in your summary line

I mean, "fix blah blah" rather than "blah blah fix"

- If applicable, prefix the summary line with a word describing what area of code is being affected followed by a colon.

In this case, "mmc: ..."

Ditto in your MS7206SE series.

Best Regards
Masahiro Yamada

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 3 lines
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
#3 lore raw

PATCH 1/1 endian dependency fix

At Wed, 19 Feb 2014 10:45:33 +0900,

Quoted 7 lines · Nobuhiro Iwamatsu

Hi, all.

Masahiro, thank you for the explanation.

Yoshinori, please resend patches after read patch submission rules.

OK.
I'll resend after reading wiki.

Thanks.

Quoted 37 lines

Best regards,
Nobuhiro

2014-02-18 19:19 GMT+09:00 Masahiro Yamada <[email protected]>:

Quoted 26 lines

Hi Yoshinori,

You should read the patch submission rules
(http://www.denx.de/wiki/U-Boot/Patches)
before posting patches.

- Use the imperative tense in your summary line

I mean, "fix blah blah" rather than "blah blah fix"

- If applicable, prefix the summary line with a word describing what area of code is being affected followed by a colon.

In this case, "mmc: ..."

Ditto in your MS7206SE series.

Best Regards
Masahiro Yamada

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 3 lines
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
Signature · 2 lines
Yoshinori Sato
<[email protected]>