Skip to contentSkip to conversation

workqueue: Remove unused __cancel_delayed_work

PATCH New Tan Xiaojun 2 participants 2 messages Feb 15, 2014 – Feb 18, 2014 Workqueue

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 workqueue: Remove unused __cancel_delayed_work

We use safer cancel_delayed_work() instead of __cancel_delayed_work, and no one will use __cancel_delayed_work. So remove it.

---
 include/linux/workqueue.h | 15 ---------------
 1 file changed, 15 deletions(-)
include/linux/workqueue.h +0 -15
index 594521b..edc9410 100644
@@ -605,21 +605,6 @@ static inline bool keventd_up(void)
 	return system_wq != NULL;
 }
 
-/*
- * Like above, but uses del_timer() instead of del_timer_sync(). This means,
- * if it returns 0 the timer function may be running and the queueing is in
- * progress.
- */
-static inline bool __deprecated __cancel_delayed_work(struct delayed_work *work)
-{
-	bool ret;
-
-	ret = del_timer(&work->timer);
-	if (ret)
-		work_clear_pending(&work->work);
-	return ret;
-}
-
 /* used to be different but now identical to flush_work(), deprecated */
 static inline bool __deprecated flush_work_sync(struct work_struct *work)
 {
Signature · 1 line
1.8.0
maintainer
#1 lore raw

PATCH 1/1 workqueue: Remove deprecated __cancel_delayed_work()

Hello, Tan.

The description didn't seem to give enough details so I applied with updated description.

Thanks a lot!
------ 8< ------

Quoted 1 line

From 90d88bd75424dff51e2072fd2f8fa85ee893aa17 Mon Sep 17 00:00:00 2001

From: Tan Xiaojun <[email protected]>
Date: Sat, 15 Feb 2014 13:19:51 +0800

__cancel_delayed_work() was deprecated by 136b5721d75a ("workqueue:
deprecate __cancel_delayed_work()") as cancel_delayed_work() was updated so that it could be used from all contexts. Enough time has passed since the deprecation. Let's remove it.

tj: description update

---
 include/linux/workqueue.h | 15 ---------------
 1 file changed, 15 deletions(-)
include/linux/workqueue.h +0 -15
index 594521b..edc9410 100644
@@ -605,21 +605,6 @@ static inline bool keventd_up(void)
 	return system_wq != NULL;
 }
 
-/*
- * Like above, but uses del_timer() instead of del_timer_sync(). This means,
- * if it returns 0 the timer function may be running and the queueing is in
- * progress.
- */
-static inline bool __deprecated __cancel_delayed_work(struct delayed_work *work)
-{
-	bool ret;
-
-	ret = del_timer(&work->timer);
-	if (ret)
-		work_clear_pending(&work->work);
-	return ret;
-}
-
 /* used to be different but now identical to flush_work(), deprecated */
 static inline bool __deprecated flush_work_sync(struct work_struct *work)
 {
Signature · 1 line
1.8.5.3