Skip to contentSkip to conversation

clk: return probe defer when DT clock not yet ready

PATCH RESEND In review Jean-Francois Moine 4 participants 5 messages Nov 25, 2013 – Feb 25, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v3 1/1 clk: return probe defer when DT clock not yet ready

At probe time, a clock device may not be ready when some other device wants to use it.

This patch lets the functions clk_get/devm_clk_get return a probe defer when the clock is defined in the DT but not yet available.

---
resend v3:
- base kernel 3.14.0-rc1
- __clk_get() failure is fixed
resend v2: remove ASoc from subject (thank you, Mark)
resend: - patch subject change from
[PATCH v3 1/2] ASoC: kirkwood: clk: probe defer when clock not yet ready
- base kernel 3.13.0-rc1
v2: fix __clk_get() failure (from Russell King)

---
 drivers/clk/clk.c    | 2 +-
 drivers/clk/clkdev.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/clk/clk.c +1 -1
index 5517944..32d84e9 100644
@@ -2472,7 +2472,7 @@ EXPORT_SYMBOL_GPL(of_clk_del_provider);
 struct clk *__of_clk_get_from_provider(struct of_phandle_args *clkspec)
 {
 	struct of_clk_provider *provider;
-	struct clk *clk = ERR_PTR(-ENOENT);
+	struct clk *clk = ERR_PTR(-EPROBE_DEFER);
 
 	/* Check if we have such a provider in our array */
 	list_for_each_entry(provider, &of_clk_providers, link) {
drivers/clk/clkdev.c +2 -0
index 48f6721..a360b2e 100644
@@ -167,6 +167,8 @@ struct clk *clk_get(struct device *dev, const char *con_id)
 		clk = of_clk_get_by_name(dev->of_node, con_id);
 		if (!IS_ERR(clk))
 			return clk;
+		if (PTR_ERR(clk) == -EPROBE_DEFER)
+			return clk;
 	}
 
 	return clk_get_sys(dev_id, con_id);
Signature · 1 line
1.9.0.rc3
Reviewed-by Tested-by on v3 1/1
#1 lore raw
Quoted 7 lines · Jean-Francois Moine

At probe time, a clock device may not be ready when some other device wants to use it.

This patch lets the functions clk_get/devm_clk_get return a probe defer when the clock is defined in the DT but not yet available.

Hope this can be merged for v3.15. Thanks.

#2 lore raw
In reply to Jean-Francois Moine
Quoted 5 lines · On Mon, 25 Nov 2013 19:47:04 +0100 Jean-Francois Moine <[email protected]> wrote:

At probe time, a clock device may not be ready when some other device wants to use it.

This patch lets the functions clk_get/devm_clk_get return a probe defer when the clock is defined in the DT but not yet available.

Hi Mike,

Any news about this patch?

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#3 lore raw
Quoted 6 lines · Jean-Francois Moine
Quoted 3 lines · On Mon, 25 Nov 2013 19:47:04 +0100 Jean-Francois Moine <[email protected]> wrote:

At probe time, a clock device may not be ready when some other device wants to use it.

Quoted 6 lines
Quoted 2 lines

This patch lets the functions clk_get/devm_clk_get return a probe defer when the clock is defined in the DT but not yet available.

Hi Mike,

Any news about this patch?

Mike,

Can you please have a look at this patch so that either you or I can take this. It /is/ required so that subsystems can correctly identify whether a clock is missing because it's not specified in DT, or whether the clock is missing because it's specified in DT but doesn't yet exist.

This patch has been hanging around for ages and deserves some attention.

Thanks.

Signature · 3 lines
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".
#4 lore raw

PATCH RESEND v3 1/1 clk: return probe defer when DT clock not yet ready

Quoting Russell King - ARM Linux (2014-02-19 10:53:15)

Quoted 14 lines · Jean-Francois Moine
Quoted 6 lines
Quoted 3 lines · On Mon, 25 Nov 2013 19:47:04 +0100 Jean-Francois Moine <[email protected]> wrote:

At probe time, a clock device may not be ready when some other device wants to use it.

Quoted 6 lines
Quoted 2 lines

This patch lets the functions clk_get/devm_clk_get return a probe defer when the clock is defined in the DT but not yet available.

Hi Mike,

Any news about this patch?

Quoted 8 lines

Mike,

Can you please have a look at this patch so that either you or I can take this. It /is/ required so that subsystems can correctly identify whether a clock is missing because it's not specified in DT, or whether the clock is missing because it's specified in DT but doesn't yet exist.

This patch has been hanging around for ages and deserves some attention.

I only saw this patch now thanks to another thread. I have some aggressive mail filtering going on and I guess maybe the original ASoC subject had something to do with that?

Oh well. I've pull this patch into clk-next for testing. I'll see if anything goes boom.

Thanks for the patch and longsuffering patience!

Regards,
Mike

Quoted 3 lines

Thanks.