Designware:RC BARs setup related fix
PATCH 1/1 Designware:RC BARs setup related fix
The Synopsys PCIe core provides one pair of 32-bit BARs (BAR 0 and BAR 1). The BARs can be configured as follows:
- One 64-bit BAR: BARs 0 and 1 are combined to form a single 64-bit BAR.
- Two 32-bit BARs: BARs 0 and 1 are two independent 32-bit BARs
This patch corrects 64-bit, non-prefetchable memory BAR configuration implemented in dw driver.
--- drivers/pci/host/pcie-designware.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/pci/host/pcie-designware.c +1 -1
@@ -800,7 +800,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp)/* setup RC BARs */ dw_pcie_writel_rc (pp,0x00000004 ,PCI_BASE_ADDRESS_0 ); -dw_pcie_writel_rc (pp,0x00000004 ,PCI_BASE_ADDRESS_1 ); +dw_pcie_writel_rc (pp,0x00000000 ,PCI_BASE_ADDRESS_1 );/* setup interrupt pins */ dw_pcie_readl_rc (pp,PCI_INTERRUPT_LINE , &val);
Signature · 1 line
1.7.0.1
Quoted 9 lines · Mohit Kumar
The Synopsys PCIe core provides one pair of 32-bit BARs (BAR 0 and BAR 1). The BARs can be configured as follows:
- One 64-bit BAR: BARs 0 and 1 are combined to form a single 64-bit BAR.
- Two 32-bit BARs: BARs 0 and 1 are two independent 32-bit BARsThis patch corrects 64-bit, non-prefetchable memory BAR configuration implemented in dw driver.
Quoted 6 lines
Signed-off-by Mohit Kumar <[email protected]>Cc Pratyush Anand <[email protected]>Cc Jingoo Han <[email protected]>Cc Arnd Bergmann <[email protected]>
Applied to pci/host-designware for v3.15, thanks!
I update the summary to the following; let me know if it's not accurate:
PCI: designware: Fix RC BAR to be single 64-bit non-prefetchable memory BAR
Quoted 24 lines
--- drivers/pci/host/pcie-designware.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/pci/host/pcie-designware.c +1
-1@@ -800,7 +800,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp)/* setup RC BARs */ dw_pcie_writel_rc (pp,0x00000004 ,PCI_BASE_ADDRESS_0 ); -dw_pcie_writel_rc (pp,0x00000004 ,PCI_BASE_ADDRESS_1 ); +dw_pcie_writel_rc (pp,0x00000000 ,PCI_BASE_ADDRESS_1 );/* setup interrupt pins */ dw_pcie_readl_rc (pp,PCI_INTERRUPT_LINE , &val);Signature · 6 lines
1.7.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Bjorn,
Quoted 19 lines
-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:24 AM
To: Mohit KUMAR DCG
Cc: [email protected]; Pratyush ANAND; Arnd Bergmann; spear-devel; [email protected]
Subject: Re: [PATCH 1/1] Designware:RC BARs setup related fixQuoted 1 line · Mohit Kumar
The Synopsys PCIe core provides one pair of 32-bit BARs (BAR 0 and BAR
1).
Quoted 8 lines
The BARs can be configured as follows:
- One 64-bit BAR: BARs 0 and 1 are combined to form a single 64-bit BAR.
- Two 32-bit BARs: BARs 0 and 1 are two independent 32-bit BARsThis patch corrects 64-bit, non-prefetchable memory BAR configuration implemented in dw driver.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Mohit Kumar <[email protected]>Cc Pratyush Anand <[email protected]>Cc Jingoo Han <[email protected]>Cc Arnd Bergmann <[email protected]>Applied to pci/host-designware for v3.15, thanks!
- thanks
Quoted 5 lines
I update the summary to the following; let me know if it's not accurate:
PCI: designware: Fix RC BAR to be single 64-bit non-prefetchable memory
BAR
- yes, it looks better
Thanks,
Mohit
Quoted 52 lines
-----Original Message-----
From: Mohit KUMAR [mailto:[email protected]]
Sent: Thursday, February 20, 2014 9:43 AM
To: Bjorn Helgaas
Cc: [email protected]; Pratyush ANAND; Arnd Bergmann; spear-devel; [email protected]
Subject: RE: [PATCH 1/1] Designware:RC BARs setup related fixHello Bjorn,
Quoted 5 lines
-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:24 AM
To: Mohit KUMAR DCG
Cc: [email protected]; Pratyush ANAND; Arnd Bergmann; spear-devel;
Quoted 15 lines
[email protected]
Subject: Re: [PATCH 1/1] Designware:RC BARs setup related fixQuoted 2 lines · Mohit Kumar
The Synopsys PCIe core provides one pair of 32-bit BARs (BAR 0 and BAR
1).
Quoted 8 lines
The BARs can be configured as follows:
- One 64-bit BAR: BARs 0 and 1 are combined to form a single 64-bit BAR.
- Two 32-bit BARs: BARs 0 and 1 are two independent 32-bit BARsThis patch corrects 64-bit, non-prefetchable memory BAR configuration implemented in dw driver.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Mohit Kumar <[email protected]>Cc Pratyush Anand <[email protected]>Cc Jingoo Han <[email protected]>Cc Arnd Bergmann <[email protected]>Applied to pci/host-designware for v3.15, thanks!
- thanks
Quoted 5 lines
I update the summary to the following; let me know if it's not accurate:
PCI: designware: Fix RC BAR to be single 64-bit non-prefetchable
memory BAR- yes, it looks better
Thanks,
Mohit
Bjorn Helgaas
maintainerQuoted 1 line · Mohit KUMAR DCG
I assume you meant that you want this patch to go to the stable kernels? I added the appropriate tag to the patch:
This won't apply cleanly to v3.11 because there were unrelated changes to these lines. If you want it in v3.11, please send the appropriate patch to [email protected].
Bjorn
Quoted 52 lines
Quoted 52 lines
-----Original Message-----
From: Mohit KUMAR [mailto:[email protected]]
Sent: Thursday, February 20, 2014 9:43 AM
To: Bjorn Helgaas
Cc: [email protected]; Pratyush ANAND; Arnd Bergmann; spear-devel; [email protected]
Subject: RE: [PATCH 1/1] Designware:RC BARs setup related fixHello Bjorn,
Quoted 5 lines
-----Original Message-----
From: Bjorn Helgaas [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:24 AM
To: Mohit KUMAR DCG
Cc: [email protected]; Pratyush ANAND; Arnd Bergmann; spear-devel;
Quoted 15 lines
[email protected]
Subject: Re: [PATCH 1/1] Designware:RC BARs setup related fixQuoted 2 lines · Mohit Kumar
The Synopsys PCIe core provides one pair of 32-bit BARs (BAR 0 and BAR
1).
Quoted 8 lines
The BARs can be configured as follows:
- One 64-bit BAR: BARs 0 and 1 are combined to form a single 64-bit BAR.
- Two 32-bit BARs: BARs 0 and 1 are two independent 32-bit BARsThis patch corrects 64-bit, non-prefetchable memory BAR configuration implemented in dw driver.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Mohit Kumar <[email protected]>Cc Pratyush Anand <[email protected]>Cc Jingoo Han <[email protected]>Cc Arnd Bergmann <[email protected]>Applied to pci/host-designware for v3.15, thanks!
- thanks
Quoted 5 lines
I update the summary to the following; let me know if it's not accurate:
PCI: designware: Fix RC BAR to be single 64-bit non-prefetchable
memory BAR- yes, it looks better
Thanks,
Mohit