Skip to contentSkip to conversation

blk-mq: remove obsolete comments

PATCH In review Shaohua Li 2 participants 3 messages Feb 19, 2014 – Feb 20, 2014 Block layer

lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

PATCH 1/1 blk-mq: remove obsolete comments

We now have blk_mq_stop/start_queues API, delete the obsolete comments.

---
 block/blk-mq.c |    5 -----
 1 file changed, 5 deletions(-)
block/blk-mq.c +0 -5
Index: linux/block/blk-mq.c
===================================================================
@@ -598,11 +598,6 @@ static void __blk_mq_run_hw_queue(struct
 			queued++;
 			continue;
 		case BLK_MQ_RQ_QUEUE_BUSY:
-			/*
-			 * FIXME: we should have a mechanism to stop the queue
-			 * like blk_stop_queue, otherwise we will waste cpu
-			 * time
-			 */
 			list_add(&rq->queuelist, &rq_list);
 			blk_mq_requeue_request(rq);
 			break;
#1 lore raw
Quoted 2 lines · Shaohua Li

We now have blk_mq_stop/start_queues API, delete the obsolete comments.

We do have the API, but the big question is if we want to require every driver to manually call it each time we get a busy return here.

author
#2 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Shaohua Li

We now have blk_mq_stop/start_queues API, delete the obsolete comments.

We do have the API, but the big question is if we want to require every driver to manually call it each time we get a busy return here.

block layer can't know if driver is ready to handle request, so I'm afraid driver should manually call it.

Thanks,
Shaohua