Skip to contentSkip to conversation

Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

PATCH In review K. Y. Srinivasan 2 participants 9 messages Feb 20, 2014 – Feb 21, 2014 Hyper-V/Azure core and drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/hv/vmbus_drv.c +2 -0
index b37c91b..2352ae48 100644
@@ -899,10 +899,12 @@ static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *ctx)
 	switch (res->type) {
 	case ACPI_RESOURCE_TYPE_IRQ:
 		irq = res->data.irq.interrupts[0];
+		break;
 
 	case ACPI_RESOURCE_TYPE_ADDRESS64:
 		hyperv_mmio_start = res->data.address64.minimum;
 		hyperv_mmio_size = res->data.address64.address_length;
+		break;
 	}
 
 	return AE_OK;
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Is this for 3.14-final or 3.15?

I ask this every time, someday you will let me know ahead of time...

#2 lore raw
Quoted 13 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:06 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 2 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

Quoted 8 lines
Quoted 4 lines
---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Is this for 3.14-final or 3.15?

I ask this every time, someday you will let me know ahead of time...

I am sorry Greg. This is for 3.14-final.

Regards,

K. Y

#3 lore raw
In reply to K. Y. Srinivasan
Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Fails to apply to my char-misc-next branch (if you want it in 3.14-final, that's where it belongs...):
checking file drivers/hv/vmbus_drv.c
Hunk #1 FAILED at 899.
1 out of 1 hunk FAILED

#4 lore raw
Quoted 18 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:47 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 5 lines

Fails to apply to my char-misc-next branch (if you want it in 3.14-final, that's where it belongs...):
checking file drivers/hv/vmbus_drv.c
Hunk #1 FAILED at 899.
1 out of 1 hunk FAILED

I will rebase it send it to you shortly.

Thanks,

K. Y

#5 lore raw
In reply to Greg KH
Quoted 18 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:47 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 5 lines

Fails to apply to my char-misc-next branch (if you want it in 3.14-final, that's where it belongs...):
checking file drivers/hv/vmbus_drv.c
Hunk #1 FAILED at 899.
1 out of 1 hunk FAILED

Greg,

This patch is based on this commit:

commit 90f3453585479d5beb75058da46eb573ced0e6ac

I just got your char-misc-next branch and it does not have the needed commit.

Regards,

K. Y

#6 lore raw
Quoted 37 lines

-----Original Message-----
From: [email protected] [mailto:driverdev-devel- [email protected]] On Behalf Of KY Srinivasan
Sent: Thursday, February 20, 2014 4:19 PM
To: Greg KH
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 16 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:47 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 5 lines

Fails to apply to my char-misc-next branch (if you want it in 3.14-final, that's where it belongs...):
checking file drivers/hv/vmbus_drv.c
Hunk #1 FAILED at 899.
1 out of 1 hunk FAILED

Greg,

Quoted 8 lines

This patch is based on this commit:

commit 90f3453585479d5beb75058da46eb573ced0e6ac

I just got your char-misc-next branch and it does not have the needed commit.

Greg,

The commit referenced above was checked into your char-misc.git tree on the 7th of Feb. Can you check in this patch to the same tree. I could resend this patch.

Regards,

K. Y

Quoted 8 lines

Regards,

K. Y
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

#7 lore raw
In reply to KY Srinivasan
Quoted 26 lines · KY Srinivasan
Quoted 18 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:47 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 5 lines

Fails to apply to my char-misc-next branch (if you want it in 3.14-final, that's where it belongs...):
checking file drivers/hv/vmbus_drv.c
Hunk #1 FAILED at 899.
1 out of 1 hunk FAILED

Greg,

Quoted 8 lines

This patch is based on this commit:

commit 90f3453585479d5beb75058da46eb573ced0e6ac

I just got your char-misc-next branch and it does not have the needed commit.

Then I guess this isn't 3.14-final material, right?

Please resend it when you have determined which branch it should go into, it's out of my queue now.

greg k-h

#8 lore raw
Quoted 45 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 6:21 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

Quoted 8 lines · KY Srinivasan
Quoted 8 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Thursday, February 20, 2014 3:47 PM
To: KY Srinivasan
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI

specified

Quoted 25 lines
Quoted 10 lines

resources

Quoted 6 lines · K. Y. Srinivasan

Fix a bug in the resource walking code.

---
 drivers/hv/vmbus_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 5 lines

Fails to apply to my char-misc-next branch (if you want it in 3.14-final, that's where it belongs...):
checking file drivers/hv/vmbus_drv.c
Hunk #1 FAILED at 899.
1 out of 1 hunk FAILED

Greg,

This patch is based on this commit:

commit 90f3453585479d5beb75058da46eb573ced0e6ac

Quoted 6 lines
Quoted 1 line

I just got your char-misc-next branch and it does not have the needed commit.

Then I guess this isn't 3.14-final material, right?

Please resend it when you have determined which branch it should go into, it's out of my queue now.

Thanks Greg, I will resend the patch. Please apply it to char-misc.git tree.

Regards,

K. Y