ext3: remove unneeded check in ext3_ordered_writepage()
PATCH 1/1 ext3: remove unneeded check in ext3_ordered_writepage()
We already know "ret" is zero so there is no need to do:
if (!ret) ret = err;
We can just assign ret directly instead.
Signed-off-by Dan Carpenter <[email protected]>
fs/ext3/inode.c +2 -5
@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page,* block_write_full_page() succeeded. Otherwise they are unmapped, * and generally junk. */ -if (ret =0 ) { - err =walk_page_buffers (handle, page_bufs,0 ,PAGE_CACHE_SIZE , +if (ret =0 ) + ret =walk_page_buffers (handle, page_bufs,0 ,PAGE_CACHE_SIZE ,NULL , journal_dirty_data_fn); -if (!ret) - ret = err; - }walk_page_buffers (handle, page_bufs,0 ,PAGE_CACHE_SIZE ,NULL , bput_one); err =ext3_journal_stop (handle);
Quoted 6 lines · Dan Carpenter
We already know "ret" is zero so there is no need to do:
if (!ret) ret = err;We can just assign ret directly instead.
Thanks. I've added the patch to my tree.
Honza
Quoted 22 lines
Signed-off-by Dan Carpenter <[email protected]>fs/ext3/inode.c +2
-5@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page,* block_write_full_page() succeeded. Otherwise they are unmapped, * and generally junk. */ -if (ret =0 ) { - err =walk_page_buffers (handle, page_bufs,0 ,PAGE_CACHE_SIZE , +if (ret =0 ) + ret =walk_page_buffers (handle, page_bufs,0 ,PAGE_CACHE_SIZE ,NULL , journal_dirty_data_fn); -if (!ret) - ret = err; - }walk_page_buffers (handle, page_bufs,0 ,PAGE_CACHE_SIZE ,NULL , bput_one); err =ext3_journal_stop (handle);
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR