Skip to contentSkip to conversation

ncftp: fix cross-compilation test

PATCH New Romain Naour 4 participants 8 messages Feb 21, 2014 – Feb 26, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

The configure script needs to be regenerated to fix the cross-compilation test.

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

---
 package/ncftp/ncftp.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
package/ncftp/ncftp.mk +8 -0
index ff6c70a..841c82b 100644
@@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
 NCFTP_LICENSE = Clarified Artistic License
 NCFTP_LICENSE_FILES = doc/LICENSE.txt
 
+NCFTP_DEPENDENCIES = host-autoconf
+
+define NCFTP_RUN_AUTOCONF
+       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
+endef
+
+NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
+
 ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
 	NCFTP_TARGET_BINS += ncftpget
 endif
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

Dear Romain Naour,

Quoted 10 lines · Romain Naour

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

The configure script needs to be regenerated to fix the cross-compilation test.

Quoted 7 lines

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

---
 package/ncftp/ncftp.mk | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

In reply to Romain Naour
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

Quoted 7 lines

The configure script needs to be regenerated to fix the cross-compilation test.

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

In reply to Romain Naour
Quoted 10 lines · Romain Naour

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

The configure script needs to be regenerated to fix the cross-compilation test.

Quoted 6 lines

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

---
 package/ncftp/ncftp.mk | 8 ++++++++

Looks like the patch file itself got lost in this revision...

Regards,
Arnout

Quoted 22 lines
 1 file changed, 8 insertions(+)
package/ncftp/ncftp.mk +8 -0
index ff6c70a..841c82b 100644
@@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
 NCFTP_LICENSE = Clarified Artistic License
 NCFTP_LICENSE_FILES = doc/LICENSE.txt
 
+NCFTP_DEPENDENCIES = host-autoconf
+
+define NCFTP_RUN_AUTOCONF
+       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
+endef
+
+NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
+
 ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
 	NCFTP_TARGET_BINS += ncftpget
 endif
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#4 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

Hi Arnout,
Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :

Quoted 11 lines · Romain Naour
Quoted 10 lines

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

The configure script needs to be regenerated to fix the cross-compilation test.

Quoted 7 lines
Quoted 6 lines

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

---
  package/ncftp/ncftp.mk | 8 ++++++++

Looks like the patch file itself got lost in this revision...

Thanks to the advice of ThomasP, the patch file is no longer necessary since the configure script is regenerated correctly by autoconf. I tested this patch in the same conditions as for ncftp build errors (with a chrootwhere ncurses was not installed on the host)

Best regards,
Romain

Quoted 28 lines

Regards,
Arnout

Quoted 22 lines
  1 file changed, 8 insertions(+)
package/ncftp/ncftp.mk +8 -0
index ff6c70a..841c82b 100644
@@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
  NCFTP_LICENSE = Clarified Artistic License
  NCFTP_LICENSE_FILES = doc/LICENSE.txt
 
+NCFTP_DEPENDENCIES = host-autoconf
+
+define NCFTP_RUN_AUTOCONF
+       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
+endef
+
+NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
+
  ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
  	NCFTP_TARGET_BINS += ncftpget
  endif
#5 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

Quoted 20 lines · Romain Naour

Hi Arnout,
Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :

Quoted 18 lines · Romain Naour
Quoted 17 lines

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

The configure script needs to be regenerated to fix the cross-compilation test.

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

---
  package/ncftp/ncftp.mk | 8 ++++++++
Quoted 6 lines
Quoted 1 line

Looks like the patch file itself got lost in this revision...

Thanks to the advice of ThomasP, the patch file is no longer necessary since the configure script is regenerated correctly by autoconf. I tested this patch in the same conditions as for ncftp build errors (with a chrootwhere ncurses was not installed on the host)

OK, now I understand.

I'm going to send a follow-up patch to clarify this. Otherwise, an
eventual version bumper will have a hard time understanding what is going on.

Regards,
Arnout

Quoted 33 lines

Best regards,
Romain

Quoted 27 lines

Regards,
Arnout

Quoted 21 lines
  1 file changed, 8 insertions(+)
package/ncftp/ncftp.mk +7 -0
index ff6c70a..841c82b 100644
@@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
  NCFTP_LICENSE = Clarified Artistic License
  NCFTP_LICENSE_FILES = doc/LICENSE.txt
  +NCFTP_DEPENDENCIES = host-autoconf
+
+define NCFTP_RUN_AUTOCONF
+       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
+endef
+
+NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
+
  ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
      NCFTP_TARGET_BINS += ncftpget
  endif
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#6 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

Hi Arnout, All
Le 25/02/2014 18:13, Arnout Vandecappelle a ?crit :

Quoted 22 lines · Romain Naour
Quoted 21 lines

Hi Arnout,
Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :

Quoted 19 lines · Romain Naour
Quoted 10 lines

The cross-compilation test is based on the ability to run a test program on the host, which is wrong.

If it runs, then the configure script concludes that we're doing native compilation,
if it doesn't run, we're doing cross-compilation.

The configure script needs to be regenerated to fix the cross-compilation test.

Quoted 7 lines

Fixes
http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log

---
   package/ncftp/ncftp.mk | 8 ++++++++

Looks like the patch file itself got lost in this revision...

Quoted 9 lines
Quoted 4 lines

Thanks to the advice of ThomasP, the patch file is no longer necessary since the configure script is regenerated correctly by autoconf. I tested this patch in the same conditions as for ncftp build errors (with a chrootwhere ncurses was not installed on the host)

OK, now I understand.

I'm going to send a follow-up patch to clarify this. Otherwise, an
eventual version bumper will have a hard time understanding what is going on.

You are right, the problem is not obvious and
I should have written a comment in addition to the commit log.

I wonder if any other packages can be affected by this issue ? At least we know that autoconf 2.13 is not safe for cross-compilation...

Thank you for clarifying this issue :)

Best regards,
Romain

Quoted 23 lines
Quoted 22 lines
Quoted 21 lines
Quoted 21 lines
   1 file changed, 8 insertions(+)
package/ncftp/ncftp.mk +7 -0
index ff6c70a..841c82b 100644
@@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
   NCFTP_LICENSE = Clarified Artistic License
   NCFTP_LICENSE_FILES = doc/LICENSE.txt
   +NCFTP_DEPENDENCIES = host-autoconf
+
+define NCFTP_RUN_AUTOCONF
+       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
+endef
+
+NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
+
   ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
       NCFTP_TARGET_BINS += ncftpget
   endif
#7 lore raw

PATCH v3 1/1 ncftp: fix cross-compilation test

Quoted 2 lines · Romain Naour

I wonder if any other packages can be affected by this issue ? At least we know that autoconf 2.13 is not safe for cross-compilation...

The first autoconf version after 2.13 is 2.50, and this solves the
cross-compilation issue (see release notes). 2.50 was released on May 21, 2001. Seems unlikely that there are many packages that are distributed with such an ancient autoconf...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F