Skip to contentSkip to conversation

linux-headers: cross compile fix

PATCH New Noam Camus 3 participants 5 messages Feb 23, 2014

lore
Share & tools
lore

Noam Camus

author
#0 lore raw

PATCH 1/1 linux-headers: cross compile fix

Otherwise compiler not found errors occured.

---
 package/linux-headers/linux-headers.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/linux-headers/linux-headers.mk +1 -0
index 30d3076..632b94f 100644
@@ -25,6 +25,7 @@ define LINUX_HEADERS_INSTALL_STAGING_CMDS
 			HOSTCFLAGS="$(HOSTCFLAGS)" \
 			HOSTCXX="$(HOSTCXX)" \
 			INSTALL_HDR_PATH=$(STAGING_DIR)/usr \
+			CROSS_COMPILE="$(TARGET_CROSS)" \
 			headers_install)
 endef
 
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 linux-headers: cross compile fix

Dear Noam Camus,

Quoted 12 lines · Noam Camus

Otherwise compiler not found errors occured.

---
 package/linux-headers/linux-headers.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/linux-headers/linux-headers.mk +0 -0
index 30d3076..632b94f 100644

package/linux-headers/linux-headers.mk define LINUX_HEADERS_INSTALL_STAGING_CMDS · line 31

Quoted 7 lines
package/linux-headers/linux-headers.mk +1 -0
@@ -25,6 +25,7 @@ define LINUX_HEADERS_INSTALL_STAGING_CMDS
 			HOSTCFLAGS="$(HOSTCFLAGS)" \
 			HOSTCXX="$(HOSTCXX)" \
 			INSTALL_HDR_PATH=$(STAGING_DIR)/usr \
+			CROSS_COMPILE="$(TARGET_CROSS)" \
 			headers_install)
 endef
 

Doesn't look harmful in principle, but it seems to have worked until now without CROSS_COMPILE="$(TARGET_CROSS)". Can you expand the commit log by explaining in which case you have seen errors, and which errors. The linux-headers package is used daily to build toolchains by all Buildroot users, so I'd like to understand how your situation is different. Is it that the ARC kernel headers need something special? But we are building ARC toolchains everyday in the autobuilders, with no problem. That's why I'd like to have more details.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 linux-headers: cross compile fix

See Inline

-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
Sent: Sunday, February 23, 2014 11:51 AM
To: Noam Camus
Cc: buildroot at busybox.net
Subject: Re: [Buildroot] FW: [PATCH] linux-headers: cross compile fix

Dear Noam Camus,

Quoted 13 lines · Noam Camus

Otherwise compiler not found errors occured.

---
 package/linux-headers/linux-headers.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/linux-headers/linux-headers.mk +0 -0
index 30d3076..632b94f 100644

package/linux-headers/linux-headers.mk define LINUX_HEADERS_INSTALL_STAGING_CMDS · line 31

Quoted 7 lines
package/linux-headers/linux-headers.mk +1 -0
@@ -25,6 +25,7 @@ define LINUX_HEADERS_INSTALL_STAGING_CMDS
 			HOSTCFLAGS="$(HOSTCFLAGS)" \
 			HOSTCXX="$(HOSTCXX)" \
 			INSTALL_HDR_PATH=$(STAGING_DIR)/usr \
+			CROSS_COMPILE="$(TARGET_CROSS)" \
 			headers_install)
 endef
 

Doesn't look harmful in principle, but it seems to have worked until now without CROSS_COMPILE="$(TARGET_CROSS)". Can you expand the commit log by explaining in which case you have seen errors, and which errors. The linux-headers package is used daily to build toolchains by all Buildroot users, so I'd like to understand how your situation is different. Is it that the ARC kernel headers need something special? But we are building ARC toolchains everyday in the autobuilders, with no problem. That's why I'd like to have more details.
Thomas

[Noam Camus]
Sorry for long lines I am still looking for better email client than my outlook.
Just use target linux-headers-rebuild and you will get many errors that buildroot silently ignores. You alternatively may add intentionally BAD CROSS_COMPILE if you don't have ARC setup handy and see that Toolchain building is not stopped due to this error.
For example here is my log:
---------------------------------------
rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_rsynced rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_built rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_staging_installed rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_target_installed rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_images_installed rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_host_installed

Quoted 1 line
Quoted 1 line
Quoted 1 line

linux-headers custom Syncing from source dir /home/noamc/workspace/sb/EZdk-nps/ldk/build/buildroot/../sources/linux-nps

rsync -au --cvs-exclude --include core /home/noamc/workspace/sb/EZdk-nps/ldk/build/buildroot/../sources/linux-nps/ /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

linux-headers custom Building
linux-headers custom Installing to staging directory

(cd /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom; PATH="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/bin:/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/bin:/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/sbin/:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/npsdb/ezutils:/home/noamc/bin:/home/npsdb/ezutils" PERLLIB="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/lib/perl" /usr/bin/make -j9 ARCH=arc HOSTCC="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/bin/ccache /usr/bin/gcc" HOSTCFLAGS="" HOSTCXX="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/bin/ccache /usr/bin/g++" INSTALL_HDR_PATH=/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/arceb-ezchip-linux-uclibc/sysroot/usr headers_install) /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
make[3]: arc-linux-uclibc-gcc: Command not found
make[3]: Entering directory `/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom'
make[3]: arc-linux-uclibc-gcc: Command not found
CHK include/generated/uapi/linux/version.h
make[3]: Leaving directory `/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom'

Quoted 1 line
Quoted 1 line
Quoted 1 line

linux-headers custom Installing to target

---------------------------------------------------------
Regards,
Noam
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering http://free-electrons.com

#3 lore raw

PATCH 1/1 linux-headers: cross compile fix

Dear Noam Camus,

Quoted 1 line · Noam Camus

See Inline

No need to say that. Just strip from the original message the parts that have become irrelevant.

Quoted 7 lines

Doesn't look harmful in principle, but it seems to have worked until now without CROSS_COMPILE="$(TARGET_CROSS)". Can you expand the commit log by explaining in which case you have seen errors, and which errors. The linux-headers package is used daily to build toolchains by all Buildroot users, so I'd like to understand how your situation is different. Is it that the ARC kernel headers need something special? But we are building ARC toolchains everyday in the autobuilders, with no problem. That's why I'd like to have more details.
Thomas

[Noam Camus]
Sorry for long lines I am still looking for better email client than my outlook.

Aah, yes, indeed. But I've been told that it might be possible, with some configuration, to tweak the Outlook behavior to make it more or less reasonable for discussions on open-source mailing list. Though I've never used Outlook myself, so I can't say much more than that.

Quoted 15 lines

Just use target linux-headers-rebuild and you will get many errors that buildroot silently ignores. You alternatively may add intentionally BAD CROSS_COMPILE if you don't have ARC setup handy and see that Toolchain building is not stopped due to this error.
For example here is my log:
---------------------------------------
rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_rsynced rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_built rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_staging_installed rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_target_installed rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_images_installed rm -f /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/.stamp_host_installed

Quoted 1 line
Quoted 1 line
Quoted 1 line

linux-headers custom Syncing from source dir /home/noamc/workspace/sb/EZdk-nps/ldk/build/buildroot/../sources/linux-nps

rsync -au --cvs-exclude --include core /home/noamc/workspace/sb/EZdk-nps/ldk/build/buildroot/../sources/linux-nps/ /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

linux-headers custom Building
linux-headers custom Installing to staging directory

Quoted 9 lines

(cd /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom; PATH="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/bin:/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/bin:/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/sbin/:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/npsdb/ezutils:/home/noamc/bin:/home/npsdb/ezutils" PERLLIB="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/lib/perl" /usr/bin/make -j9 ARCH=arc HOSTCC="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/bin/ccache /usr/bin/gcc" HOSTCFLAGS="" HOSTCXX="/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/bin/ccache /usr/bin/g++" INSTALL_HDR_PATH=/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/host/usr/arceb-ezchip-linux-uclibc/sysroot/usr headers_install) /home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 25: arc-linux-uclibc-gcc: command not found
/home/noamc/workspace/sb/EZdk-nps/ldk/build/output_arc/build/linux-headers-custom/scripts/gcc-version.sh: line 26: arc-linux-uclibc-gcc: command not found

Ah, right. The problem is that our linux-headers package does not depend on any cross-compiler, not even gcc-initial. It happens that since host-gcc-initial is before linux-headers in the alphabetical order, you normally have a cross-compiler available by the time the linux-headers package is installed, but this is not explicitly guaranteed by the package dependencies.

This problem was already raised on the LKML a number of years ago:
https://lkml.org/lkml/2007/10/10/140, with apparently no solution coming up.

A possible solution is to adjust your patch so that it explicitly adds host-gcc-initial as a dependency of linux-headers.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 linux-headers: cross compile fix

In reply to Noam Camus

Noam, All,

On 2014-02-23 12:33 +0000, Noam Camus spake thusly:

Quoted 43 lines

See Inline

-----Original Message-----
From: Thomas Petazzoni [mailto:thomas.petazzoni at free-electrons.com]
Sent: Sunday, February 23, 2014 11:51 AM
To: Noam Camus
Cc: buildroot at busybox.net
Subject: Re: [Buildroot] FW: [PATCH] linux-headers: cross compile fix

Dear Noam Camus,

Quoted 13 lines · Noam Camus

Otherwise compiler not found errors occured.

---
 package/linux-headers/linux-headers.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/linux-headers/linux-headers.mk +0 -0
index 30d3076..632b94f 100644

package/linux-headers/linux-headers.mk define LINUX_HEADERS_INSTALL_STAGING_CMDS · line 31

Quoted 7 lines
package/linux-headers/linux-headers.mk +1 -0
@@ -25,6 +25,7 @@ define LINUX_HEADERS_INSTALL_STAGING_CMDS
 			HOSTCFLAGS="$(HOSTCFLAGS)" \
 			HOSTCXX="$(HOSTCXX)" \
 			INSTALL_HDR_PATH=$(STAGING_DIR)/usr \
+			CROSS_COMPILE="$(TARGET_CROSS)" \
 			headers_install)
 endef
 

Doesn't look harmful in principle, but it seems to have worked until now without CROSS_COMPILE="$(TARGET_CROSS)". Can you expand the commit log by explaining in which case you have seen errors, and which errors. The linux-headers package is used daily to build toolchains by all Buildroot users, so I'd like to understand how your situation is different. Is it that the ARC kernel headers need something special? But we are building ARC toolchains everyday in the autobuilders, with no problem. That's why I'd like to have more details.
Thomas

Quoted 3 lines

[Noam Camus]
Just use target linux-headers-rebuild and you will get many errors that buildroot silently ignores.

It's not Buildroot that ignores those errors, it's the Linux buildsystem itself that ignores them, since they are harmless at the time of installing headers.

Quoted 3 lines

You alternatively may add intentionally BAD CROSS_COMPILE if you don't have ARC setup handy and see that Toolchain building is not stopped due to this error.

The cross-compiler is not used at the time of 'make headers-install'. So, those are spurious errors of the Linux buildsystem.

They can/should be safely ignored.

(Side note: ARC is not the only arch that exhibit this behaviour. IIRC, cris, hexagon, ia64, parisc, score and xtensa behave the same, with ia64 in an aggaravated way.)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'