lua: needs dynamic library support (dlopen)
PATCH 1/1 lua: needs dynamic library support (dlopen)
Fixes
http://autobuild.buildroot.net/results/e76/e765f992ad721a094579140c153ff71f20753265/
--- package/dnsmasq/Config.in | 4 ++++ package/efl/libedje/Config.in | 5 +++-- package/haserl/Config.in | 5 +++++ package/lighttpd/Config.in | 4 ++++ package/lua/Config.in | 4 ++++ 5 files changed, 20 insertions(+), 2 deletions(-)
package/dnsmasq/Config.in +4 -0
@@ -32,9 +32,13 @@ config BR2_PACKAGE_DNSMASQ_IDN config BR2_PACKAGE_DNSMASQ_LUA bool "Lua scripting support" select BR2_PACKAGE_LUA + depends on !BR2_PREFER_STATIC_LIB # lua help Enable Lua scripting for dnsmasq +comment "Lua scripting support needs a toolchain w/ dynamic library" + depends on BR2_PREFER_STATIC_LIB + config BR2_PACKAGE_DNSMASQ_CONNTRACK bool "conntrack marking support" select BR2_PACKAGE_LIBNETFILTER_CONNTRACK
package/efl/libedje/Config.in +3 -2
@@ -1,6 +1,6 @@ -comment "libedje needs a toolchain w/ threads" +comment "libedje needs a toolchain w/ threads, dynamic library" depends on !BR2_avr32 - depends on !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB config BR2_PACKAGE_LIBEDJE bool "libedje"
@@ -13,6 +13,7 @@ config BR2_PACKAGE_LIBEDJE select BR2_PACKAGE_LUA depends on !BR2_avr32 # libevas depends on BR2_TOOLCHAIN_HAS_THREADS # libevas + depends on !BR2_PREFER_STATIC_LIB # lua help A graphical layout and animation library for animated resizable, compressed and scalable themes.
package/haserl/Config.in +5 -0
@@ -13,10 +13,15 @@ if BR2_PACKAGE_HASERL config BR2_PACKAGE_HASERL_WITH_LUA bool "Lua support" depends on BR2_PACKAGE_HASERL_VERSION_0_9_X + depends on !BR2_PREFER_STATIC_LIB select BR2_PACKAGE_LUA help Enable Lua support for haserl +comment "Lua support needs a toolchain w/ dynamic library" + depends on BR2_PACKAGE_HASERL_VERSION_0_9_X + depends on BR2_PREFER_STATIC_LIB + choice prompt "Haserl version" default BR2_PACKAGE_HASERL_VERSION_0_9_X
package/lighttpd/Config.in +4 -0
@@ -48,7 +48,11 @@ config BR2_PACKAGE_LIGHTTPD_WEBDAV config BR2_PACKAGE_LIGHTTPD_LUA bool "lua support" select BR2_PACKAGE_LUA + depends on !BR2_PREFER_STATIC_LIB # lua help Enable Lua support. Needed to support mod_magnet +comment "lua support needs a toolchain w/ dynamic library" + depends on BR2_PREFER_STATIC_LIB + endif
package/lua/Config.in +4 -0
@@ -1,5 +1,9 @@ +comment "lua needs a toolchain w/ dynamic library" + depends on BR2_PREFER_STATIC_LIB + config BR2_PACKAGE_LUA bool "lua" + depends on !BR2_PREFER_STATIC_LIB # dlopen select BR2_PACKAGE_HAS_LUA_INTERPRETER help Lua is a powerful, fast, light-weight, embeddable scripting language.
PATCH 1/1 lua: needs dynamic library support (dlopen)
Dear Thomas De Schampheleire,
Quoted 5 lines · Thomas De Schampheleire
Fixes
http://autobuild.buildroot.net/results/e76/e765f992ad721a094579140c153ff71f20753265/Signed-off-by Thomas De Schampheleire <[email protected]>
Quoted 7 lines
--- package/dnsmasq/Config.in | 4 ++++ package/efl/libedje/Config.in | 5 +++-- package/haserl/Config.in | 5 +++++ package/lighttpd/Config.in | 4 ++++ package/lua/Config.in | 4 ++++ 5 files changed, 20 insertions(+), 2 deletions(-)
No, that's not the correct fix. The correct fix is a variant of
http://patchwork.ozlabs.org/patch/313208/, which as suggested by Peter should use BR2_PREFER_STATIC_LIB as a condition, and not BR2_BINFMT_FLAT.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 lua: needs dynamic library support (dlopen)
Thomas Petazzoni <[email protected]> schreef:
Quoted 16 lines
Dear Thomas De Schampheleire,
Quoted 5 lines · Thomas De Schampheleire
Fixes
http://autobuild.buildroot.net/results/e76/e765f992ad721a094579140c153ff71f20753265/Signed-off-by Thomas De Schampheleire <[email protected]>Quoted 7 lines
--- package/dnsmasq/Config.in | 4 ++++ package/efl/libedje/Config.in | 5 +++-- package/haserl/Config.in | 5 +++++ package/lighttpd/Config.in | 4 ++++ package/lua/Config.in | 4 ++++ 5 files changed, 20 insertions(+), 2 deletions(-)
Quoted 4 lines
No, that's not the correct fix. The correct fix is a variant of
http://patchwork.ozlabs.org/patch/313208/, which as suggested by Peter should useBR2_PREFER_STATIC_LIBas a condition, and notBR2_BINFMT_FLAT.
Ok, understood.
Francois, what are your plans with that patch?
Thanks,
Thomas
PATCH 1/1 lua: needs dynamic library support (dlopen)
2014-02-23 18:49 GMT+01:00 Thomas De Schampheleire <[email protected]>:
Quoted 17 lines
Thomas Petazzoni <[email protected]> schreef:
Quoted 16 lines
Dear Thomas De Schampheleire,
Quoted 12 lines · Thomas De Schampheleire
Fixes
http://autobuild.buildroot.net/results/e76/e765f992ad721a094579140c153ff71f20753265/Signed-off-by Thomas De Schampheleire <[email protected]>--- package/dnsmasq/Config.in | 4 ++++ package/efl/libedje/Config.in | 5 +++-- package/haserl/Config.in | 5 +++++ package/lighttpd/Config.in | 4 ++++ package/lua/Config.in | 4 ++++ 5 files changed, 20 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 4 lines
No, that's not the correct fix. The correct fix is a variant of
http://patchwork.ozlabs.org/patch/313208/, which as suggested by Peter should useBR2_PREFER_STATIC_LIBas a condition, and notBR2_BINFMT_FLAT.Ok, understood.
Francois, what are your plans with that patch?
http://patchwork.ozlabs.org/patch/313208/ is a V1 with BR2_BINFMT_FLAT. I've already send a V2, see
http://patchwork.ozlabs.org/patch/314145/ --> lua: refactor install steps
http://patchwork.ozlabs.org/patch/314146/ --> lua: handles BR2_PREFER_STATIC_LIB
Note: V1 fixes only compilation issue, V2 handles compilation, linking, and installation
Fran?ois
Quoted 5 lines
Thanks,
Thomas
PATCH 1/1 lua: needs dynamic library support (dlopen)
Dear Fran?ois Perrad,
Quoted 8 lines · Fran?ois Perrad
Quoted 7 lines
Quoted 4 lines
No, that's not the correct fix. The correct fix is a variant of
http://patchwork.ozlabs.org/patch/313208/, which as suggested by Peter should useBR2_PREFER_STATIC_LIBas a condition, and notBR2_BINFMT_FLAT.Ok, understood.
Francois, what are your plans with that patch?
Quoted 7 lines
http://patchwork.ozlabs.org/patch/313208/ is a V1 with
BR2_BINFMT_FLAT. I've already send a V2, see
http://patchwork.ozlabs.org/patch/314145/ --> lua: refactor install steps
http://patchwork.ozlabs.org/patch/314146/ --> lua: handlesBR2_PREFER_STATIC_LIBNote: V1 fixes only compilation issue, V2 handles compilation, linking, and installation
Generally speaking, I would recommend you (and I believe I already did) to write more detailed commit logs. It would clearly help to get your patches merged. Your first patch has absolutely no information, and your second patch only references the autobuilder failure.
As a rule of thumb, if your patch is not trivial, there should at least be 2 or 3 paragraphs of text in the commit log. If there is not 2 or 3 paragraphs, then you should, before sending the patch, wonder if there is really enough information for an external reviewer to understand what's going on.
I really, really appreciate all your contributions, and I would like to see them merged faster. And to help achieve this, better commit logs is definitely a key thing.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com