Skip to contentSkip to conversation

ASoC: fsl: imx-pcm-fiq: Remove unneeded 'out' label

PATCH Applied Fabio Estevam 2 participants 2 messages Feb 24, 2014

Subsystems (4)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ASoC: fsl: imx-pcm-fiq: Remove unneeded 'out' label

From: Fabio Estevam <[email protected]>

Instead of jumping to the 'out' label, just return the error code immediately.

---
 sound/soc/fsl/imx-pcm-fiq.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
sound/soc/fsl/imx-pcm-fiq.c +3 -4
index 6553202..7abf6a0 100644
@@ -270,18 +270,17 @@ static int imx_pcm_new(struct snd_soc_pcm_runtime *rtd)
 		ret = imx_pcm_preallocate_dma_buffer(pcm,
 			SNDRV_PCM_STREAM_PLAYBACK);
 		if (ret)
-			goto out;
+			return ret;
 	}
 
 	if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream) {
 		ret = imx_pcm_preallocate_dma_buffer(pcm,
 			SNDRV_PCM_STREAM_CAPTURE);
 		if (ret)
-			goto out;
+			return ret;
 	}
 
-out:
-	return ret;
+	return 0;
 }
 
 static int ssi_irq = 0;
Signature · 1 line
1.8.1.2
maintainer Applied
#1 lore raw
Quoted 3 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Instead of jumping to the 'out' label, just return the error code immediately.

Applied, thanks.